From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B7CD27702D for ; Mon, 27 Apr 2026 23:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777332778; cv=none; b=WLO8XYIS2YwAIFDKV5A7QD8LmPPZSEiZ63bK85rWzf+WLfAAVljagokzO5FufoJOzfONXPkJa+pfcpUUrwGBgB/2QeTYYBDKfwuWQcZODFBW6WtgClg8CqQ82gZRXQLV56FboykL9Fvp69VCxIMtbPW/odqo7Q6KkNeNPhBnQvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777332778; c=relaxed/simple; bh=26JcQONhsnOoI3eYTKhqy18PwJWdR4v9SHzJaJb9hhI=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=bzBoSjGJxuJntnjhVjMqFvruIcEyIqroaamFhpS7JMwwKzXioZR6kNBlurPnwStw7RKmXVWkBr9B6o2xgxhKgI8CBBGWgTBrtYH7H3S234i2VKrMJlBZ/Vlomzgl3kwgIvCbgEUG/0Im5uo/a96DDl79ayMLe+lLo487gD5Myco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=PGECWZjM; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="PGECWZjM" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8ef45a6d9dfso757093685a.0 for ; Mon, 27 Apr 2026 16:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1777332776; x=1777937576; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=AacrbQWeONsXwYeqMAMp8ZNpTduvDnpFQOhYm8v5DdI=; b=PGECWZjMVMuvoHZEqtbcT9v16+X5abPB6pFB+QMndGI/JN3GIG0J2s6/R/1ir23f9z Rnx1dk84bc/GRU4Q6LDApegzMdvstZEW/bjUcUEtIRR9xKaWO5Oj6wGaLauocTTGuoRh DWvvYx6P31mcZborlxcUm13iRU2S8aO5AIsYhVSzwuPRPH6UgJdZHCyhYtete7ZojZu1 cRQf9nnX8HqOJHrnmOt3WNOKO04bAJMQqB0hSJpLTdnhhozP/Z6OSc/nYQhJrHR9c0DS eiE3+RXp1ef2jFxL77nf5iM3BdB7F/I+jjbCYV0L3e2quvuVKqnBCU9MsqtnkuqCCd96 ShjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777332776; x=1777937576; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AacrbQWeONsXwYeqMAMp8ZNpTduvDnpFQOhYm8v5DdI=; b=H5uMgKu3UWjdFBwPo+Q4lGHXfadwxwS7IDG+gxCopMIzdT1FkNbddpeiKrdSyWMm1E W9G9RgX2qffUHzR6ToJP9dKuZ1q0dTkpIKeNcsC8MuDwciGlwsC+fUPomeI4P7wHZxC2 0I9SXfW18QdDLgYZ2Y9k/PxLY2AmBz8d7xCt1K56H6MRkBveCTsEF6sRWtUmbnaj9u+i EPWON02Lt7431vSw46Es5vTsr9iErLzKD2Vp0SAQF4as4fBG/KgfD38iQqFEv6gYhft2 tXKhT+OJvaq0utszYZJyoHRNU0EYkbfGT6yQ/7AzNvHwwUTzyyqKkdFXyAu313TuTdhy p58g== X-Forwarded-Encrypted: i=1; AFNElJ/eSuogIJeXGM6nPTmk3RjAmtNwFGyyt5k/nJtQEs1X54nsgIMbxv6er1C3XhYxydZ93h+GzQ/NkLyVL8I=@vger.kernel.org X-Gm-Message-State: AOJu0YwmCiSAi8eZt1t7UwYi+bmK6L0XQh1eehRxcpzA6+T8HvEc6dVo B/DMsicFkWDb2X9iB4DhLYxd3vxDV0k8ILMwIGn1jrvbuMuUeSkC9MItETLdPsZgEeK9thMWMBr KZPw= X-Gm-Gg: AeBDiesKOIv1MGOZRaZpQ31t8ytnI56NXF/Q7WPMTnqdqv7fq8QERs98Qs8hmkbVHrZ CjAcPcqYjTSX9+zG81ZmSaW/K0Qr3rZvC4PpyZg9iOPSTjdvrNETn0GH5LCLB5xhHIKfCNM719K UgIF/aUbwKRcz6oeh+/Z6s5jfp9TJ8jDe6fF5yGBaM8WkgG0+apJa6XrKuRgspaWCvR+k20Nx1N bqEfOUqClcc110hFn/DRSnhgAKPAW75TTHVayllVNYDoCICA2bcoxKGTROdHq8ERYiS4GNPR9py n1Q1h/c43mog4b/30qbyE43xOZMyNiEpSMG/2zS5IMlroyRFXvaaK35fouv7kCDXIzGxIsA2RiL w+rsFcJJmGBsglZ/dA+xHIG8L6Ez8TpLZkOGqMeZogOZmXrXFCaLUw8+I4+H1iR0AwmsguWcPsw XjclhbFX9OTnJWk2l2pFBhd1KWihT8xu0rf9vFEBCiqDahgMaFpfb0G24Y8Qw5chuCLYnrVw9R8 UMy6D4= X-Received: by 2002:a05:620a:7111:b0:8ce:5a30:9523 with SMTP id af79cd13be357-8f7d6f3dd9bmr106905485a.4.1777332776436; Mon, 27 Apr 2026 16:32:56 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8f7c49c4953sm52474885a.3.2026.04.27.16.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 16:32:55 -0700 (PDT) Date: Mon, 27 Apr 2026 19:32:55 -0400 Message-ID: <0a65e27845468d7b0b57810086a563d3@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260427_1759/pstg-lib:20260427_ 820/pstg-pwork:20260427_1759 From: Paul Moore To: David Windsor , Stephen Smalley Cc: Ondrej Mosnacek , selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selinux: don't reserve xattr slot when we won't fill it References: <20260426232349.844289-1-dwindsor@gmail.com> In-Reply-To: <20260426232349.844289-1-dwindsor@gmail.com> On Apr 26, 2026 David Windsor wrote: > > Move lsm_get_xattr_slot() below the SBLABEL_MNT check so we don't leave > a NULL-named slot in the array when returning -EOPNOTSUPP; filesystem > initxattrs() callbacks stop iterating at the first NULL ->name, silently > dropping xattrs installed by later LSMs. > > Signed-off-by: David Windsor > --- > security/selinux/hooks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Good catch, thanks. These seems like a stable candidate so I've merged it into selinux/stable-7.1 and we likely send it up to Linus later this week. > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 97801966bf32..4ff118a9395f 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -2966,7 +2966,7 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir, > { > const struct cred_security_struct *crsec = selinux_cred(current_cred()); > struct superblock_security_struct *sbsec; > - struct xattr *xattr = lsm_get_xattr_slot(xattrs, xattr_count); > + struct xattr *xattr; > u32 newsid, clen; > u16 newsclass; > int rc; > @@ -2992,6 +2992,7 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir, > !(sbsec->flags & SBLABEL_MNT)) > return -EOPNOTSUPP; > > + xattr = lsm_get_xattr_slot(xattrs, xattr_count); > if (xattr) { > rc = security_sid_to_context_force(newsid, > &context, &clen); > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > -- > 2.53.0 -- paul-moore.com