From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753806AbdL1OdA (ORCPT ); Thu, 28 Dec 2017 09:33:00 -0500 Received: from mout.web.de ([212.227.17.12]:54334 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbdL1Ocy (ORCPT ); Thu, 28 Dec 2017 09:32:54 -0500 To: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, Jonathan Hunter , Laxman Dewangan , Linus Walleij , Paul Gortmaker , Thierry Reding From: SF Markus Elfring Subject: [PATCH] pinctrl: tegra: Delete two error messages for a failed memory allocation in tegra_pinctrl_probe() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <0a67035f-e089-85f6-adff-14e41c957ab6@users.sourceforge.net> Date: Thu, 28 Dec 2017 15:32:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:47t4IHrsDHwGwgTvV0Lj+k9f903VXKh9Ar7tdKYeGOP5uSBiKoR x84xXOzbf8h63b9w97FRhMjKgCDIYdfsgtbRaufuxOHU0HsnkUkSxq2XthM8kUstKvacCq9 cKGwXeM2UxlAfD8YTM9NxbKTqjxPSBMXupsO0GHBvxGrHFDRJDyDltOIlcPK3hnuACX+0Po Gjsu0Glu5DaSmw1F4uJpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:93G6XiifeQ8=:EjnMlkvlVFkRCuy3Rc6nbc RLt1hzriQ0+DopCGTe1btPg+WvPjeS7Ll7scM5a1O1KC+7mMJ3P47XIizsz/yGX9F1GDV2ger MdytJT75UCoSXyvzfA3dPc7N7R8TLEZUdznZD8pzBVnV5CfwOXZHCSqpo9APDx/oYonr12Vnj qlUnDCYlehN0KwLb1G3xx3UftMDseilrnxk4FpUHAh09YEpYskRY2gJXfzeuwEnvfROpgL626 t5D5NmOf9dFQdnHqokmtLGvp0N1+K/IKExZWRwzEQJpSgCX02bskibgR6G4/kcKTAn90/iDwl Dr1On71hVqissX2P8iAz4hYkn9CdMsaFXVgLURobLVLSZV++aVnZjMnjgF3qGqmxKDS3LZSKd nIn2U3og1glUJP/eiYwPB5aHaFoNbbbwTrI27TaIORcL33bFL433JAzyYNON+2EV7DT2MjcXC NrlxqrftmOSZeyHZlFhIIvHtwkQGtZbyJeGfSjHRH5tORcgWyLgREkuH7NQGi9XMHSKCpIun1 ekUrxUWjjWQXqMx7NiUjinqFkpzRKck7QR1exKbFjvLSif+DOu+QeC8qrcVojaRVlpvyXupjs tM1k7ONRxl+gudckPLZJvp/Ogpsn7uz0zsE51fdM7uS3J+06dVLIyKhQIjSsSd5itM0YP9vlQ FJHuIqEAQ/T7GdsBoPnrvGbi3cJk8Uc3TCiGpWTC9ZU7kny6PSAHJZUunGZyv38CNFGfTfVp2 2wh/Fslz/OTQsdkVWyOjDm97ivCyRxck1UEX4BtOecBBiOF8/R5+1eWIHwtNrnvB1WEwgosHn eX0gBvHkYVjRHpGuDDjXDqesL91oabIiBGYrNTAMGLrcnpe5hQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 28 Dec 2017 15:15:08 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/tegra/pinctrl-tegra.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 51716819129d..72c718e66ebb 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -666,10 +666,9 @@ int tegra_pinctrl_probe(struct platform_device *pdev, int fn, gn, gfn; pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL); - if (!pmx) { - dev_err(&pdev->dev, "Can't alloc tegra_pmx\n"); + if (!pmx) return -ENOMEM; - } + pmx->dev = &pdev->dev; pmx->soc = soc_data; @@ -722,10 +721,8 @@ int tegra_pinctrl_probe(struct platform_device *pdev, pmx->regs = devm_kzalloc(&pdev->dev, pmx->nbanks * sizeof(*pmx->regs), GFP_KERNEL); - if (!pmx->regs) { - dev_err(&pdev->dev, "Can't alloc regs pointer\n"); + if (!pmx->regs) return -ENOMEM; - } for (i = 0; i < pmx->nbanks; i++) { res = platform_get_resource(pdev, IORESOURCE_MEM, i); -- 2.15.1