From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945Ab1AKFXV (ORCPT ); Tue, 11 Jan 2011 00:23:21 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:63404 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178Ab1AKFW4 (ORCPT ); Tue, 11 Jan 2011 00:22:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=XxbjKhBVVXrMJrs42tUmV9Ti79N6ImxhEsApzg8v9KszUP+TabfzfOrnIsSpg2TMMN XF9rH0jqB5l+GsVnM1bcCrn4RfznPpf18/rWGjSwcV5+c2epNX0g7d27zxzvJ8T3i4nz VKKNPFOMTQexIAOf7S+crkZORAf1zcjtAj2fw= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KAMEZAWA Hiroyuki , Hugh Dickins , Mel Gorman , KOSAKI Motohiro , Johannes Weiner , Minchan Kim , Dan Magenheimer , Andi Kleen , Nick Piggin , Al Viro Subject: [PATCH v3 5/7] truncate: Change remove_from_page_cache Date: Tue, 11 Jan 2011 14:22:09 +0900 Message-Id: <0a67c9d4b1a2cdcc2a7b43147d73766c986531f4.1294723009.git.minchan.kim@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series changes remove_from_page_cache's page ref counting rule. Page cache ref count is decreased in delete_from_page_cache. So we don't need decreasing page reference by caller. Cc: Dan Magenheimer Cc: Andi Kleen Cc: Nick Piggin Cc: Al Viro Acked-by: Hugh Dickins Acked-by: Mel Gorman Reviewed-by: KAMEZAWA Hiroyuki Reviewed-by: Johannes Weiner Reviewed-by: KOSAKI Motohiro Signed-off-by: Minchan Kim --- mm/truncate.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index 9ee5673..85404b0 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -108,13 +108,12 @@ truncate_complete_page(struct address_space *mapping, struct page *page) cancel_dirty_page(page, PAGE_CACHE_SIZE); clear_page_mlock(page); - remove_from_page_cache(page); + delete_from_page_cache(page); ClearPageMappedToDisk(page); - /* this must be after the remove_from_page_cache which + /* this must be after the delete_from_page_cache which * calls cleancache_put_page (and note page->mapping is now NULL) */ cleancache_flush_page(mapping, page); - page_cache_release(page); /* pagecache ref */ return 0; } -- 1.7.0.4