From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78725381AF1 for ; Wed, 4 Mar 2026 12:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772626750; cv=none; b=dDeUF8vPVEX0NCyh5B9tCt4VF6LXoxXCxHH2eoCnyLaAOJg6uQ19kQW5NK9jhTnoAyWYkGkPUJL+YOG8zafo8OOSDpFUQh96unLvC71nI8B5Cz6poehC/EQO6dbDvv9HdHVo69zbxIjXOxUdu6R197C4IJWK12ZD9LXjFRntgfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772626750; c=relaxed/simple; bh=uDyeW1xDHKAVVTn8tKC88jlYDnAsMDuTF6SIjgt7eLg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TyVjM8yQM+r4hCTwF2flNmNUSsI8O6/LHNKYWcps5jsSs5+BSCOu/nzLOMLfVzIMXQyrGPhwRx1fxFDkg1vad8QscswsI4Ortcw/gs6Ux7bwaIRewWGmQy7l9d6xhb2uw+vpBGmFNm5Ns1RSQ6iGRgICwT38/gam4BTJ7VsYGTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FNipxwmR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gPLgMYwP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FNipxwmR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gPLgMYwP" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624BVdmh1677919 for ; Wed, 4 Mar 2026 12:19:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uxsB5NCYJ9Wco9EkS82OhpVjd4FUOfck6CfUcK9bWk8=; b=FNipxwmRoZDqij/1 gNq+1TLME3dHhg342F64Rh+fXPYNGsS8N3uzJM8pGNiMOs2XETbyEqOOEyDT4GlG KIGY0PRuHdQW9dLfUaxGmYy3T0g0eh3Rt6vnFRU4zdMH5yBpjyOxoxC0fsVJGq/u X4Osm1dqzhGIY/J0DX1DHiX6nXroA6lHvo54T19UDXdbDxaDtLJJDBYtySroiLh4 7WLj1ZqV8lsCOkmLV1YV3vTwQpDG4SRjcIS29tc9cxZ4qAFeX2kVH+OwAkGLaiki xdLc89Hd4jhSLzzahmXKOihPwGCDCk2OJla4boH+JBIHVlkFwJ7aUlF4Y7ovDvcy YsCjYA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp73has6r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 12:19:08 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899f6011df3so17530926d6.0 for ; Wed, 04 Mar 2026 04:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772626748; x=1773231548; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uxsB5NCYJ9Wco9EkS82OhpVjd4FUOfck6CfUcK9bWk8=; b=gPLgMYwPLOMdVy0x7Jg5d6E93tmMal/8EhOPEetKaitE/oqComI8lJ+d8hQbydrI8P NzTGlWHTNcMUq+8FSGeN3l2jpe5oRcmPLpeC6TvBF0CtrkJ7HXULjaN+o/af/4tkxwAh x2DqvcYXqIN5t+TSAwMB5G0HORjlzDHONi7UB06PUYsizQBn8RmkFrLwdAtL3uMW+ecv ajpF9tsNKCzQIiqHZ0u6BijBvnni75XXFoYyfwUvxpNjH8nCl/9OAtTAxnLJCyEEUjTn Cexn5mhTCDYNAwf+84iRa7a59FKkKspffm4gGc6603VyEUq5tTG+M1vVljKDHQTIccJh U0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772626748; x=1773231548; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uxsB5NCYJ9Wco9EkS82OhpVjd4FUOfck6CfUcK9bWk8=; b=dnGN0l5ifMcdRPwvAd8tWroyBXKsgYFcFvBX67LA61+vpZbIMs60oggMLgl4PAmMuw KLPXa+GYc+/gAYZKsJAs/AtEYnvFYzJTX/7Fym3b4R6YZXiCAuWJUbu93GftjkTb3Azg uresRKWycN8hBBLe2ds1Fe86Qa6RKPQiuujQ+sW724k4fy9U/1V/llbLYTCBAgw6jP04 PRZbyC+AvfhV6OrjvGkaJ5CdVJ62foLrxo4YvBer8ngD+Wf0q25nXTVXJPmEFKPAQtZp X2I7Bi7YbmpweA6cWUTUpE+afODhJpjeeus7vV28ndes9mfdDT60m2zqmiLoe/VE+53o mRmw== X-Forwarded-Encrypted: i=1; AJvYcCXbraGDeKpGR7pb9zexQfWC4ivxtL9VVZFZf8vrl731oGUH1Qv4cWG+hq7vyuB0Zes582con/7gdFl7hLw=@vger.kernel.org X-Gm-Message-State: AOJu0YzpKAdsMUZ7FnoPHERBFVrMDrR71dm5uG+Gxwuj5lQrpxJo2Ctn XYb1/+N3FAGczr5Z3B0Bxiro02VRESDZJe7uA8qrdcuTa9tJcJZlOqiIeQ9GLM4KhUp0A0hFT9F R/GtPprhKJBCIsaeubrrIcjthuineg96xII1doUXss+9wWbUK6onrpeAgme6qYWFkysQ= X-Gm-Gg: ATEYQzzE6NpUrYVRhqrFaOGR/gJnO8gcbavGl8pfaKQUUQQxNFi3R8Zn3+n0uoq1lhz +z/ykXWEHkA1aT91aCv4EBBhiGPyT0C8TogDnCAOiYhcL+WxAD4l9/wIJD2ss7iHELojHNjnOVO 0bu9W7KFCztlEpiw1l8u8VKMw3mmoLC5aOWg/7D7T5+r/G1Jf6MNvImleqlgmK9En8KYBMbIlrZ n59YYdB/DR1rP9+8TnDGRWfR82iLd/mvbT4mf09oqXGAAHor4yI324W6/KKBc9ehUfHGf2I6W8i akHsCAdMI+ef0j3I4tvysE/drBK0awuFuFhNygDOt1srPtuzWHbLsTGPkvzx5KbY6J+hfdQrFhc t/oizjftprnJOH180QeCT1X8BHLshpQaqf2YY0DPDg9rI4pq+6bCccsedTS7QYiKdEgNBD75Azv S9ihI= X-Received: by 2002:a05:6214:4c84:b0:89a:c:97cf with SMTP id 6a1803df08f44-89a19989f7dmr14654576d6.1.1772626747802; Wed, 04 Mar 2026 04:19:07 -0800 (PST) X-Received: by 2002:a05:6214:4c84:b0:89a:c:97cf with SMTP id 6a1803df08f44-89a19989f7dmr14654246d6.1.1772626747219; Wed, 04 Mar 2026 04:19:07 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b93c7eaa49dsm274435766b.18.2026.03.04.04.19.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 04:19:06 -0800 (PST) Message-ID: <0a703589-48cc-4717-a629-4424ff55b7bf@oss.qualcomm.com> Date: Wed, 4 Mar 2026 13:19:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] phy: qcom: qmp-combo: Move pipe_clk on/off to common To: Val Packett , Vinod Koul , Kishon Vijay Abraham I , Bjorn Andersson , Wesley Cheng , Neil Armstrong Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260228220634.22778-2-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260228220634.22778-2-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: eSoyg6g27ERdZ01CGncDu1Z8Yd5N7oY- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA5NyBTYWx0ZWRfX1RxyCBnDHgRj drf3BPm1+U10g6JBFXVGL8zXLvaVtFOhhT5S89cUqmYMMclYO05m8aOayKEbdUG2shVY2x6K/mi t4IshUJnWizS53YehVEGyGTlimvTF70nTugaY4vuSQXafPyiyn4ajQsIafsWWkYb5jnTXtTAxe/ Id/DOyLyBZk7n9nclyp8O4u8FlH2KdQjpTWZf9WdzMY9xT/Aq5bMilVvr96Fj+eFWlpsJcO7U91 kKES4SG9/At8Ox3XhC/oCODvc9KxpoGkQnxJxsr6UluAp8OvVGFkqJ9oA8bQNv5PqiDfwzxhV6t 9VPUrH2tgqhfNKous9UQAuxVB1qGGzPLlXEK+i4PzxcErdztpX1NyZ2lX9gEhSGqgxORun1NCwx 9nFq5wDvQCT3sWHBbsY1wlWo6AVkUuMsWGtpiLGHYt/bMQp9f96SpwFDX//C6oz9kKVcrH58tPw 4MhI1PxXRO4NSI/5qEw== X-Proofpoint-ORIG-GUID: eSoyg6g27ERdZ01CGncDu1Z8Yd5N7oY- X-Authority-Analysis: v=2.4 cv=BpWQAIX5 c=1 sm=1 tr=0 ts=69a8233c cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=2YwZb52RRteD79CL59QA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040097 On 2/28/26 11:05 PM, Val Packett wrote: > Keep the USB pipe clock working when the phy is in DP-only mode, because > the dwc controller still needs it for USB 2.0 over the same Type-C port. > > Tested with the BenQ RD280UA monitor which has a downstream-facing port > for data passthrough that's manually switchable between USB 2 and 3, > corresponding to 4-lane and 2-lane DP respectively. > > Note: the suspend/resume callbacks were already gating the enable/disable > of this clock only on init_count and not usb_init_count! > > Signed-off-by: Val Packett > --- > See https://lore.kernel.org/all/389ca5d3-a698-4dac-911c-39ba057e3d17@oss.qualcomm.com/ for more info. > BTW https://lore.kernel.org/all/20260205160240.748371-2-loic.poulain@oss.qualcomm.com/ helped with coldplug. > > v2: Reorder disables as suggested > v1: https://lore.kernel.org/all/20250927093915.45124-2-val@packett.cool/ > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 93f1aa10d400..28428a8d1192 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -3691,6 +3691,13 @@ static int qmp_combo_com_init(struct qmp_combo *qmp, bool force) > if (ret) > goto err_assert_reset; > > + /* In DP-only mode, the pipe clk is still required for USB2 */ > + ret = clk_prepare_enable(qmp->pipe_clk); > + if (ret) { > + dev_err(qmp->dev, "pipe_clk enable failed err=%d\n", ret); > + return ret; I didn't notice this before - please add this hunk diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index 28428a8d1192..cdcfad2e86b1 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -3695,7 +3695,7 @@ static int qmp_combo_com_init(struct qmp_combo *qmp, bool force) ret = clk_prepare_enable(qmp->pipe_clk); if (ret) { dev_err(qmp->dev, "pipe_clk enable failed err=%d\n", ret); - return ret; + goto err_disable_clocks; } qphy_setbits(com, QPHY_V3_DP_COM_POWER_DOWN_CTRL, SW_PWRDN); @@ -3756,6 +3756,8 @@ static int qmp_combo_com_init(struct qmp_combo *qmp, bool force) return 0; +err_disable_clocks: + clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); err_assert_reset: reset_control_bulk_assert(cfg->num_resets, qmp->resets); err_disable_regulators: Konrad