mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, Kees Cook <kees@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/6] netdevice: convert private flags > BIT(31) to bitfields
Date: Tue, 13 Aug 2024 13:53:20 +0200	[thread overview]
Message-ID: <0a73afa3-f834-4b77-9762-6431cd40f3e2@intel.com> (raw)
In-Reply-To: <20240812110413.2ed0d275@kernel.org>

From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 12 Aug 2024 11:04:13 -0700

> On Mon, 12 Aug 2024 14:09:31 +0200 Alexander Lobakin wrote:
>>> The kdoc scripts says:
>>>
>>> include/linux/netdevice.h:2392: warning: Excess struct member 'priv_flags_fast' description in 'net_device'
>>>
>>> I thought you sent a kernel-doc patch during previous cycle to fix this,
>>> or was that for something else?  
>>
>> Oh crap.
>> The patch I sent expands struct_group_tagged() only.
>> If I do the same for the regular struct_group(), there'll clearly be a
>> ton of new warnings.
>> I think I'll just submit v4 with removing this line from the kdoc?
> 
> No preference on direction, but not avoiding the warning would be great.
> 
> I reckon whether kdoc is useful for the group will depend case by case.
> Best would be if we made the kdoc optional in this particular case.
> But dunno if you have cycles so you can just delete.

I have some cycles, but I dunno if we can make some kdoc fields
description optional, I didn't work with the kdoc script that deep.

Thanks,
Olek


 


  reply	other threads:[~2024-08-13 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 15:27 [PATCH net-next v3 0/6] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-08-08 15:27 ` [PATCH net-next v3 1/6] netdevice: convert private flags > BIT(31) to bitfields Alexander Lobakin
2024-08-10  5:27   ` Jakub Kicinski
2024-08-12 12:09     ` Alexander Lobakin
2024-08-12 18:04       ` Jakub Kicinski
2024-08-13 11:53         ` Alexander Lobakin [this message]
2024-08-08 15:27 ` [PATCH net-next v3 2/6] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-08-08 15:27 ` [PATCH net-next v3 3/6] netdev_features: convert NETIF_F_LLTX to dev->lltx Alexander Lobakin
2024-08-08 15:27 ` [PATCH net-next v3 4/6] netdev_features: convert NETIF_F_NETNS_LOCAL to dev->netns_local Alexander Lobakin
2024-08-08 15:27 ` [PATCH net-next v3 5/6] netdev_features: convert NETIF_F_FCOE_MTU to dev->fcoe_mtu Alexander Lobakin
2024-08-08 15:27 ` [PATCH net-next v3 6/6] net: netdev_features: remove NETIF_F_ALL_FCOE Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a73afa3-f834-4b77-9762-6431cd40f3e2@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
    --cc=pabeni@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®