mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v6 3/4] regulator: qcom-rpmh: readback voltage/bypass/mode set during bootup
Date: Tue, 1 Sep 2026 11:49:42 +0200	[thread overview]
Message-ID: <0a73bc50-71f4-43f8-9d95-14a763d63c61@oss.qualcomm.com> (raw)
In-Reply-To: <20260801-b4-read-rpmh-v5-v6-3-9fcb54928523@oss.qualcomm.com>

On 8/1/26 10:00 AM, Kamal Wadhwa wrote:
> Currently, during regulator registration, regulator framework sends an
> unnecessary `min-microvolts` request for the rpmh-regulator device. This
> happens because in current design, we do not have a way to readback the
> voltage settings that was set during the bootloader stage.
> 
> Fix this by using the rpmh_read() API to read the regulator voltage
> settings done during boot and make it available to regulator framework
> from the very first read after the bootup.
> 
> Also use this API to read the mode/bypass settings as well. This will
> provide the regulator framework a sense of the initial settings done by
> bootloader and thus preventing any redundant writes for any setting post
> bootup incase the same setting was already applied during bootup.
> 
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> ---

SC8180X Primus hangs with this patch applied and so does SM8150 HDK.

Interestingly, SDM845 DB845c doesn't

I think we may need to opt some platforms out of this..

Konrad

  reply	other threads:[~2026-09-01  9:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01  8:00 [PATCH v6 0/4] regulator: qcom-rpmh: Support RPMH address reads and use it for rpmh-regulators Kamal Wadhwa
2026-08-01  8:00 ` [PATCH v6 1/4] soc: qcom: rpmh: Add support to read back resource settings Kamal Wadhwa
2026-08-01  8:00 ` [PATCH v6 2/4] regulator: qcom-rpmh: Fix PMIC5 BOB bypass mode handling Kamal Wadhwa
2026-08-01  8:00 ` [PATCH v6 3/4] regulator: qcom-rpmh: readback voltage/bypass/mode set during bootup Kamal Wadhwa
2026-09-01  9:49   ` Konrad Dybcio [this message]
2026-09-07 12:59     ` Kamal Wadhwa
2026-09-08  7:46       ` Konrad Dybcio
2026-09-20 15:45     ` Dmitry Baryshkov
2026-09-20 19:49       ` Kamal Wadhwa
2026-08-01  8:00 ` [PATCH v6 4/4] regulator: qcom-rpmh: Fix coding style issues Kamal Wadhwa
2026-08-07 14:28 ` [PATCH v6 0/4] regulator: qcom-rpmh: Support RPMH address reads and use it for rpmh-regulators Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a73bc50-71f4-43f8-9d95-14a763d63c61@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®