From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB510C7EE22 for ; Mon, 8 May 2023 18:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233105AbjEHSz4 (ORCPT ); Mon, 8 May 2023 14:55:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjEHSzv (ORCPT ); Mon, 8 May 2023 14:55:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 362FE5FE6 for ; Mon, 8 May 2023 11:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=sFmS593k5JYIG6Y6mBz5lD1bpF/IGbDpeAilaPVo3QY=; b=me1Q7wHVbMu89bCBKN9JpNQFuh P9duQkiJTguZq8JfDcCbDAg7ZTeXUVf6sO2ak/+q6S5OHB7+7G9Rs3mh96QXHZ3bWy5kCW/gpcavh 1BIDIVA5QcxFTz9+uG271nTeU4gKAHseXkeuMzd63dYqObnzkLVS9/C84rBIHQYtQkRwhr/IFan5u y7zWeg4mrfdtoPzlXLa4xuAnfv1KLMooa7WAXOuapgpsnKP+IC+/NaMVv8TXyb7IPC/E1UlJFKSgs NVAe/Sh1CfB0CWGp6PzlTERICaySsQPW4H6rWOQISBhmn8Z5qU+i3DNHEu+yyivL1x/N0N0Aa8Wxu /a0+rcVw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pw61T-0019u5-2U; Mon, 08 May 2023 18:55:47 +0000 Message-ID: <0a75a41e-6458-8f7a-67cd-89eb05eb822f@infradead.org> Date: Mon, 8 May 2023 11:55:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] driver core: device.h: add some missing kerneldocs To: James Seo , Greg Kroah-Hartman , "Rafael J . Wysocki" Cc: linux-kernel@vger.kernel.org References: <20230508154849.1946589-1-james@equiv.tech> Content-Language: en-US From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/23 09:13, James Seo wrote: > On Mon, May 08, 2023 at 08:48:50AM -0700, James Seo wrote: >> Add the missing kerneldocs (except for DEVICE_ATTR_IGNORE_LOCKDEP(), >> which is only meaningful on debug builds with CONFIG_DEBUG_LOCK_ALLOC >> not #defined, and is aliased to DEVICE_ATTR() otherwise). >> >> Signed-off-by: James Seo >> --- > > I just noticed that there shouldn't be a "not" before "#defined" in the > last line of the commit message. Apologies. > Other than that (above), LGTM. Tested-by: Randy Dunlap Acked-by: Randy Dunlap -- ~Randy