From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Ilya Maximets <i.maximets@ovn.org>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kees Cook <kees@kernel.org>, Adrian Moreno <amorenoz@redhat.com>,
Jiri Benc <jbenc@redhat.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Matteo Perin <matteo.perin@canonical.com>
Subject: Re: [PATCH net v2 1/4] net: netlink: fix sending unassigned nsid after assigned one
Date: Thu, 21 May 2026 14:34:36 +0200 [thread overview]
Message-ID: <0a77c5c1-8680-447e-b9aa-c73600b107ae@6wind.com> (raw)
In-Reply-To: <20260520172317.175168-2-i.maximets@ovn.org>
Le 20/05/2026 à 19:22, Ilya Maximets a écrit :
> If the current skb is not shared, it is re-used directly for all the
> sockets subscribed to the notification. If we have remote all-nsid
> socket receiving a message first, then the 'nsid_is_set' will be
> set to 'true'. If the nsid is NOT_ASSIGNED for the next socket in
> the list, the 'nsid_is_set' will remain 'true' and the negative value
> is be delivered to the user space. All subsequent nsid values will be
> delivered as well, since there is no code path that sets the flag
> back to 'false'.
>
> Fix that by always dropping the flag to 'false' first.
>
> Fixes: 7212462fa6fd ("netlink: don't send unknown nsid")
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-05-21 12:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 17:22 [PATCH net v2 0/4] netlink: fixes for cross-namespace nsid reporting Ilya Maximets
2026-05-20 17:22 ` [PATCH net v2 1/4] net: netlink: fix sending unassigned nsid after assigned one Ilya Maximets
2026-05-21 12:34 ` Nicolas Dichtel [this message]
2026-05-20 17:22 ` [PATCH net v2 2/4] net: netlink: don't set nsid on local notifications Ilya Maximets
2026-05-21 12:36 ` Nicolas Dichtel
2026-05-21 14:00 ` Jiri Benc
2026-05-21 14:25 ` Nicolas Dichtel
2026-05-21 16:01 ` Ilya Maximets
2026-05-22 7:25 ` Nicolas Dichtel
2026-05-22 7:25 ` Nicolas Dichtel
2026-05-20 17:22 ` [PATCH net v2 3/4] tools: ynl: support listening on all nsids Ilya Maximets
2026-05-20 17:22 ` [PATCH net v2 4/4] selftests: net: add a test case for nsid in all nsid notifications Ilya Maximets
2026-05-22 7:30 ` Nicolas Dichtel
2026-05-21 15:23 ` [PATCH net v2 0/4] netlink: fixes for cross-namespace nsid reporting Jakub Kicinski
2026-05-21 15:50 ` patchwork-bot+netdevbpf
2026-05-23 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a77c5c1-8680-447e-b9aa-c73600b107ae@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jbenc@redhat.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matteo.perin@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox