From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550A0C76196 for ; Tue, 28 Mar 2023 08:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbjC1IWd (ORCPT ); Tue, 28 Mar 2023 04:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbjC1IWb (ORCPT ); Tue, 28 Mar 2023 04:22:31 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EA55593 for ; Tue, 28 Mar 2023 01:22:12 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id t10so46100386edd.12 for ; Tue, 28 Mar 2023 01:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679991731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TjLk7s/ILNPy05fW3mtB8q+T3+ZfJadYGXeEI//OHA4=; b=nbVgsIqDmhYjo2zpI1NxF9G7P13ZUCoomofgad9VxdCmVGj6Nu3tBawyjCSeRg1jxG VfmoFSaRMJgNmxHFUVX94hkTRg6MBrIBXssSDToYHfi4JpviP6q2Mi8s6G7SWIg8MNFD TWxJUDigcLS9p/mKxugg4jOd6JbZDVbtlVCUg0ngqdgG87zhDsgJIKkRTgU2EEG/uw1e hf4nwVFHC6l69V4pdCKqi9jwACf/df8FDrNXCyAjPoLOwsEqZcGND0g3S4oCTwv/UaKZ z7VWSxEG6gxsUK3WjBOm99ekdolfW75Wp80rZDW8hgXqd8iiBX0qGdU4j1PVjndDzS51 yEDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679991731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TjLk7s/ILNPy05fW3mtB8q+T3+ZfJadYGXeEI//OHA4=; b=otDohtDCI33IBeRhQY4oCNibrkL4zSQp0KwWPdhcaWJSU3nf72BnhVqhnJTHFib0HT d5dqvcxLCwzjZEk+702J8vMZXZbLHQzRV8XFgaTbUtretvPj9CuEnHoEFlTUvHrME27G XsUu7gRZwgohLwXO3DGt5ilRCWMB0PrTb8pPa8WofqKkSHkGYPqoyFoO74Bb/4VVqlD8 Nj1+K0pii9GftbkMQuyXHz4LXfegm4+nvHB3gnZVT3+Ci/v9JtpCXG9Bb+yfVbiNqf9Q 4Eet4+ZIVUs4vG1cNMU9zXiCzeffmkLwMmAIkZJynA1lWjqqvlLsDHVd8jeVMjjxyXWS rwIw== X-Gm-Message-State: AAQBX9c83WA9SuKuf2CiGftf8a3/yT7J4sZqcEr0ftk3CsJgz8gz6NOK TWxNL2bAwrMsH1SnExGN8r2L7w== X-Google-Smtp-Source: AKy350bZ4edHuT+xY2SDY2CDRsHlxVx3YYIulDNRVyIMWIfCBo1UlW2mN+FmnKM1kDtckc9i+joyjQ== X-Received: by 2002:aa7:c249:0:b0:4fb:395a:6aa4 with SMTP id y9-20020aa7c249000000b004fb395a6aa4mr14791797edo.31.1679991730921; Tue, 28 Mar 2023 01:22:10 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9e92:dca6:241d:71b6? ([2a02:810d:15c0:828:9e92:dca6:241d:71b6]) by smtp.gmail.com with ESMTPSA id r12-20020a50c00c000000b00501d2f10d19sm11134313edb.20.2023.03.28.01.22.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 01:22:10 -0700 (PDT) Message-ID: <0a77e40f-1b6a-38ed-78df-9259959fd2c1@linaro.org> Date: Tue, 28 Mar 2023 10:22:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3] ASoC: dt-bindings: ak4458: Convert to dtschema Content-Language: en-US To: Saalim Quadri , broonie@kernel.org, daniel.baluta@nxp.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, shengjiu.wang@nxp.com Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230327213250.29199-1-danascape@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230327213250.29199-1-danascape@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/03/2023 23:32, Saalim Quadri wrote: > Convert the AK4458 audio DAC bindings to DT schema. > > Signed-off-by: Saalim Quadri > --- > Changes: > V1 -> V2: Use the correct way for dsd-path property > Drop ak4458 label form example > V2 -> V3: ak4458 is the only one that does not support dsd-path, so we > do not require to define an array > > .../devicetree/bindings/sound/ak4458.txt | 28 -------- > .../bindings/sound/asahi-kasei,ak4458.yaml | 65 +++++++++++++++++++ > 2 files changed, 65 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt > create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ak4458.txt b/Documentation/devicetree/bindings/sound/ak4458.txt > deleted file mode 100644 > index 0416c14895d6..000000000000 > --- a/Documentation/devicetree/bindings/sound/ak4458.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -AK4458 audio DAC > - > -This device supports I2C mode. > - > -Required properties: > - > -- compatible : "asahi-kasei,ak4458" or "asahi-kasei,ak4497" > -- reg : The I2C address of the device for I2C > - > -Optional properties: > -- reset-gpios: A GPIO specifier for the power down & reset pin > -- mute-gpios: A GPIO specifier for the soft mute pin > -- AVDD-supply: Analog power supply > -- DVDD-supply: Digital power supply > -- dsd-path: Select DSD input pins for ak4497 > - 0: select #16, #17, #19 pins > - 1: select #3, #4, #5 pins > - > -Example: > - > -&i2c { > - ak4458: dac@10 { > - compatible = "asahi-kasei,ak4458"; > - reg = <0x10>; > - reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW> > - mute-gpios = <&gpio1 11 GPIO_ACTIVE_HIGH> > - }; > -}; > diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml > new file mode 100644 > index 000000000000..3842e75d9921 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4458.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AK4458 audio DAC > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + enum: > + - asahi-kasei,ak4458 > + - asahi-kasei,ak4497 > + > + reg: > + maxItems: 1 > + > + avdd-supply: > + description: Analog power supply > + > + dvdd-supply: > + description: Digital power supply > + > + reset-gpios: > + maxItems: 1 > + > + mute-gpios: > + maxItems: 1 > + description: > + GPIO used to mute all the outputs What happened to dsd-path? Do not remove properties from the bindings without some valid reason. > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: > + asahi-kasei,ak4458 This is one line - const: foo bar > + > + then: > + properties: > + dsd-path: false > + Best regards, Krzysztof