From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750794AbdAXQ4q (ORCPT ); Tue, 24 Jan 2017 11:56:46 -0500 Received: from mail-eopbgr50084.outbound.protection.outlook.com ([40.107.5.84]:24202 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750716AbdAXQ4o (ORCPT ); Tue, 24 Jan 2017 11:56:44 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH] tile: fix build failure To: Sudip Mukherjee References: <1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk> CC: , Peter Zijlstra , Sudip Mukherjee From: Chris Metcalf Message-ID: <0a7c53b5-0d1f-baa1-b159-b188e68e8f26@mellanox.com> Date: Tue, 24 Jan 2017 11:56:30 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: DM3PR14CA0002.namprd14.prod.outlook.com (10.164.193.140) To AM4PR0501MB2754.eurprd05.prod.outlook.com (10.172.216.10) X-MS-Office365-Filtering-Correlation-Id: 67809e42-1aa0-417c-3ec1-08d44479f810 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM4PR0501MB2754; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;3:Qe0uDACVbAhDYCA+0UkD7KeKxg+kIuiaq1U5Lsq/osNEABeU4FKrncHnxQxefWSJkxdbOD06CWmA/YbJbvdClmfXKG9jL2nBjZvfSEU+6hqSk7tYb/IoeIxDOtC0hg0ywcZrxp4EzoBQ4VxugXX7vmRQaEdtaRk7ooXmIY5jCkx+Kmd4L/+ZLyZRMBXiiA4+Irm1KoPiISJejmnHabDhbpqwwZxIPwWQtfd8xePqbgDRoodJYSx3GtvSj3hS/pyoTDxQOY7v14A5jBaNPhidyQ== X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;25:pJENXaPTKCyyy4yIKooN0hcfK+w3GzrUzl05UEKBBItkBwdRBq3vMY0y23gc3vWITD+/sPZv+JMBpFct2sfMfu1M+1g8gXz8u4F/IAHMgEa5HdB5ulepwRWGZpFZcSRZutyTeRuKctmzrc1jC7/E6TWBpdnKpC8P9jbBUgn8cLfVM5YjytxKR4NJ65cqdegsLBNSQRz88dagwPu+xx4CAxXfy4jnC/8OubeIVNY62y1kfo7vPpd1u2hRga9ipaIT18T0nJ2eZOkiQFskAvAZN1USi6BfzKAq1tz5dGb+TQJMK+laxD4G023a+4kEPZTluEGm5QbVkNF75L+qUsJG4yHeIf90t+nAjfzbOQhftwCJXJYyLMWGqEjY+bxnI7pEjt0nRqZjvNUjsZUxYajvHRRvrwbxilrGTIhetuwNzBWp4yKFl76BSTNB9ktrTNIqV/ALciaYYMlOZKaHjpxX+ZU1XflTvCCp+O6CTffY2JiKl1gfwXkAgC3osKALahVkMnMIOgab/Ctv6n8hgFtLYTYv0oLzgNuFjt9DZwHMc5mALShwth0bHaQjkrEW3ZXWjj0XlQ3FXnmFoLdxkoUH7KcWzjzrPfVnUiKc0yx43h6j8cRSW4ycqQvnlIMf24n7HLJ/2O8tDIG/t5aTduVfyAwiUANDQUAcr4N8F/0hI3GRquDXjg1zMDvgafe5KKuxD4l+amjVsduAkn31qew7S1AevEBrFsmhJZTgZVa+XZOvlMPwykfopKBMG5yEvcDDyQC3SCQT8QhVwm2SqF42GLArl1FklJfmy14CvmjYBUqLcXB784rYw98leWjU0/Vg1xqRvPoE8JBJk/UqxBPnXz+rjETt0WreA3d+YNrf8jpDFC0GeUGmYPrTceayPZjO X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;31:1GcRmhnq331PP9eIriJwh3MrIdBCQpVmsf4AVddmZmmlXziHJhoBCWqKZjxWYLJx2uOf5c0eMtSbEh6XJeSV5dpMHOJLIMF2Ni4c+eJzOrMsqD4wU11SCFvnC65K/FR+Auzi05PnmIKsIJxyRX0LNlld1uFi4PKg8mGthjtVeajfNwudS8B3qe3O2YgQUXXADxGqIjr1i+zRpuzQaofDIg0hrKtt1Ii6h13c81ZUBx8B2PANk4rblLNwsRngZLjQ3DMtLrjVyN4H6OydKqv3DA==;20:olNFonh4Ds1TtFurI+7J0YjBPGt94HDnPWqzEarzO1pWY//hFPoT5jc2Rz5o19Fi1+QiBiDjWFx/yAAA8r5Pt5SCOvO7SHOCKjgb6CPPbYicKmrUvaRONo5LdmW8aVAwWC1gxkwv0tEZAibXr63Pkx9x4YfApkxETpEJc6gMGxJvtYHKA6Gpq/Dm2y/7B20hO+dAcSPt1hE/6mb2AXDoGWEasf0kq4jzy6qmd7INf85ma+1Nr4N7bmUWRHJDAshy6oTK8Bv2zuGRWGxxdDR3+VPXvHgSx22ZIU6jfHs7kDKnwyiVBFJZXcuXy4T5GBzBu9SK3F8BCWhZuUA43pwFvxtGQBUf8JD0W+YvDuTiwHIDVdPaS4Rxso9cTHvu84VtVhgU1S8ftQUpSKZXAqGW5Fwh8KXlAJUAj25RfTgW11Q9VmtjK3BEhP+ahl8dQtOZ6oFVMCrqGrp48cZBHyuw2MnvO1Y/9fzO+xlQ6aiaOcaEJr6IGyE0222VffkQI77c X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(6072148);SRVR:AM4PR0501MB2754;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0501MB2754; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;4:CbJ4KtvuT/JL5r8dg1v5CDF3j42Lne2s1D3YWR0/3APl7CXA5KmJbIgC2xv4xop8dbYBbMAUlITj50wr3Ss7Fu4C2N+JZSumQQKvIuhGcQ/PlaYOEbbzeThDHKOWUAMXl4BG8ODTMgumceimrO2FiCeLJTqDImHhwFMLTv8v2PJQC5tAPU7oD3MRu6hpQHMojXdk1ZMSc+f5LS2wTvSWKFBZkOne1jq/nBdXlaCg3GmKwMtrU4482H0jvKEsZTATz9zi1zmeS9HZyX3nSEGgZ0C/efsrQFAv4PxBVDrdQITLKGiWFoZPc/qEu1U0RxalL4ws9kpPuj5AOUXhUyvWhl8Bniu7ygTMVYQaXOQeGO1D/aYDveIOsLDe6kyli7WG8J+h9FnshYX/YW5QK8Iip4tLRVqoviCG6bswseU45fRdgiCjS1t0nRHbLqvx4btb/EtMghz5UZtjrQ2HS1/lEBkIrN3uahUQmlsuAG/Yfo39Qn05dna2wxEzH5FCiD3uK0CTUDCYeb4NRYDToCII0BJtzvq8xU0DL28M/LdU6CEM/hPlBxn2HnDdlRtyISYlp37frEaFr7XjxFKGe7Y7yV7FockV3purwIRcV7FARcXCVJuCN3ilgTGNT0Hv41PLD76z+CVWaoSBBfZf9i2gAw== X-Forefront-PRVS: 0197AFBD92 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39860400002)(39450400003)(39840400002)(39850400002)(39410400002)(189002)(377454003)(199003)(24454002)(101416001)(6486002)(3846002)(6116002)(229853002)(38730400001)(25786008)(50986999)(90366009)(77096006)(6306002)(39060400001)(76176999)(23746002)(54906002)(31686004)(42186005)(8676002)(81156014)(230700001)(4326007)(36756003)(64126003)(50466002)(81166006)(54356999)(68736007)(2906002)(2950100002)(106356001)(6916009)(6666003)(33646002)(31696002)(65826007)(65806001)(47776003)(86362001)(83506001)(65956001)(105586002)(66066001)(5660300001)(189998001)(97736004)(92566002)(110136003)(53936002)(4001350100001)(7736002)(305945005)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB2754;H:[10.15.7.185];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0501MB2754;23:WZMYtu8M6NoD/cX08XLoIVYhmseLT9+Pbrx?= =?Windows-1252?Q?gA8twoPl/hmeGlmhdCw3/LnR2eNRCK/Y+YP33MDGIzE4q5aiA9iiLwxI?= =?Windows-1252?Q?Xtv+7OpJVrNGhbrTsHjvtNol8y3lGAb+BCv+vkP++/7HkjgeW3qW/zqo?= =?Windows-1252?Q?j8pnV6Ihe/EzzqSVTAWkbcZYFXuQr4sAowYhd6v22ydmdPFL6nDoCQ2r?= =?Windows-1252?Q?e0U5cN8FN32m9Z/E2Tkl5gOow8mq0ucgpoGVY8YQF1MsaWWBZEwUcton?= =?Windows-1252?Q?CfS7U7fdN4psY7p2NmpgZ6jwj77u4Fcz24VcXfR5EQXggD77hjnhxhSV?= =?Windows-1252?Q?0zgngV2WYkUYYzoeLg5g+lKa33LPXAhXZSB/lLWtw7Kx9Q8VkTOskLeV?= =?Windows-1252?Q?Z2B1G9xJUCqJgEh8PS156AXK08QEl41ePHspk77i06VKdJ/YIBeolge/?= =?Windows-1252?Q?QSL6njD4OfPB0Q8KOuo+ThxY9YXY2ROIU3CybU9fHOMC8bv+s88wiUzM?= =?Windows-1252?Q?ajxvgLD0+EYNTpvRg7T6Iv4Q9R3XOVHAQS9+KzOeq5LEprinbt76SJDS?= =?Windows-1252?Q?US/TvGyaR+7qVdZDQ0CFNz+brC9jeSRSEjl848AuWpOBXUWSRdngd3Hc?= =?Windows-1252?Q?+8NcW6ZVr8B4fh+B09OWaYTEnFxESviky3sNdyPGA4plbkJYak4VARBl?= =?Windows-1252?Q?rDt2GMKG2T16ugpuWlw9Uh0o1HvAeQx53iavZD8oZbFfxtCzMoei3s/b?= =?Windows-1252?Q?nSIP3gthkOelydhYxuN7medJtgtNqOPydBUeQTzkEP9dxXP57w+SEve9?= =?Windows-1252?Q?AK/isYnpXS1g8F+Ll5S7iMHNbB9TRpM8QUrqp09to0I/jQ75/dzkcf79?= =?Windows-1252?Q?1YNOTwqUYlUOxZOVO/G8OixMTuYOYTFJruGk2yef/LujK2Gux79nF88l?= =?Windows-1252?Q?mwN4noE1eYcWzx0NfECXL8FEJQKtE345ghz74psf2QwlIRMDOh9Y5WPs?= =?Windows-1252?Q?AGLDcxqGECcAK5lZy+T5C4c2nQBeH2/zlBsZmc7MOC1dqB0vA/+iwY8M?= =?Windows-1252?Q?3TLHIFHlWSJC1e6mQl6YhrFXsP4B6bDo39dVCwyUhJea1OMkbMnHVOgF?= =?Windows-1252?Q?l0kIv3FIC1v+pS5v9aEsqXeqhUK8NcfxypslUVzybMJ0NB9aa7SA7577?= =?Windows-1252?Q?0M1KSdOn9Odcr1m4ZzwbeGUusES86jUx+E6gEbfIcolZKdDr+fl0jSNZ?= =?Windows-1252?Q?KjpPU60SrJ8o+vBSh8vXI46Sf9/o1ImyT4kD5991Cpc5qnYwPp/0jBcE?= =?Windows-1252?Q?sabEQU4Gx2hnS9QZKxEPxnaDgfm+ROGevnYl6kvKGaffitAUnq6UOdFX?= =?Windows-1252?Q?YPApjZVGBD+mX6W712z5m1EUDOjgk+bo8GMR/dqEForSUX4fyE3Ugszi?= =?Windows-1252?Q?NoWmAUsTv3mrOsjS28N0JUL7n5elKNoIv3nQzVErdDJ1ZplwiVVsgiKC?= =?Windows-1252?Q?h55SG4/h3xn1hj2rEOoFz+JMr3+Wvs2WdrXyeEomVa1P4bF/LH7zlAh+?= =?Windows-1252?Q?DNZurF/wBFW7wkFYB4+l+vbIOY1SOhW/CZyhvjkLiUizJKPbGuTFCc5S?= =?Windows-1252?Q?DfCFSYDMo1SuuCr9uq5kt8eCTQUrwsIEPyyMK2flPN1bHe8SXZORnyBY?= =?Windows-1252?Q?nf8cExe1OxsGRkSOFYQ/Gq65qFSoTfos=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;6:mYZ34WMQHaF5tpZhoo/h1fbXaH+oqfJH3S6J8L/UD1x4TP3MqBkiMTPn9KH7EbdW4A/Xo/NfmUDeXvEg6CAQn12/A6rFi4YtiheaA7/Q6zTmK+mXMQ0LhluXtBv/Q1Wa79jJWGGEAcm+l7vFIIT+QTsAPzjUX89oA3vXnEu45tP1k+cVOSgASeYuyxsERaGXMsHfHjYukhm6Oeyf02h7ZFYLf7Qvn2CJ0aTHqWaT0Q+C93HZNAvsOwyWtDb3Hcge/LDit2+YS7JKztzbmiNxRp3KaWjzcruMkOpqjgktUuWuFf/6R2OXOU2qJCk3VyyX0niQYhzVMcw42yWpM4giizYfAXILyGEbos6oqool/GFMtBgcH098EB8yMkIJqPpQwDUod9DXEG7SNpNkMzxY6mFRi0yQS4Xen7KeiriBhars1i30NJ3I/OH2izN9s6kdW2TJYuvrTGT6o5KwrzwDNw==;5:2g7Q8QO42r2rHzKRvmb/oQcNIglwOKCswpC5DOak4RsWZVOACdc9DFJw0i3+0UrknPjkjhAJtEc7i8FBGqS2+9MDt4YToJf3qJ/lPFJQJVDYS8BT/Eoi+0vcMPUlxC919mJ4PbG0Iyd6xakmg5qOPQ==;24:/zIYOk/Bbh5s7kd4P261Dvq0dgFHrhEScWINKr1MeCXV0MMkuOxqF7MbBENq7p8Mwm2CTGyNMLaklOc0pLH0ZQCgkTppm1Anuc85DZnjQ4A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;7:Xh2l74LWThfHYH6YbEAYsSOzYcbGxzi0R6y/QjI4JpCzDtpyGsDqZfkpdZyRyys2V5FWDiMVw4AzEUtCtW3ARbLs17lA3NOqEjsrlVqpEgs5MStRhc604y6ubwW6oIpDg51K++9uImuta8f+8WGc2uXXHOdtrnnpX1Zhwq00F1bsKf5q8XRRB4EMjZVlSR9OG55juA2aWGt0/+UbduQ34CHQrrdjn5MzEVHnkiVEnj0wkS2NUf/eUTpviDPhJTs42NMCXlpBHwUHw4oETv00plgsGehncUi1TnKnIWb3JbSAVhkFJ70labhSqjCx/7cX4xR/p0WGKkF20mhK6e70Kv9q3sCdDX9Z8eAaPwKlh+LrQTRmp8ab26msvH5nTkszZs2niQj/OrcLUil6jXcxckVugM7XfYBZt3W++0Scz0QIdiGGwoWTtKof6q7+Hyedt5JhGJcV8RKRSKfQREJhUA== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2017 16:56:39.7518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2754 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2017 11:39 AM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > The build of tilegx allmodconfig was failing with errors like: > ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64' > static inline u64 mul_u32_u32(u32 a, u32 b) > ^~~ > ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32' > static inline u64 mul_u32_u32(u32 a, u32 b) > ^~~ > ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32' > static inline u64 mul_u32_u32(u32 a, u32 b) > ^~~ > In file included from ../fs/ubifs/ubifs.h:26:0, > from ../fs/ubifs/shrinker.c:42: > ../include/linux/math64.h: In function 'mul_u64_u32_shr': > ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of > function 'mul_u32_u32' [-Werror=implicit-function-declaration] > > The simplest solution was to include the types header file. > > Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends") > Cc: Peter Zijlstra > Signed-off-by: Sudip Mukherjee > --- > > build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687 > > arch/tile/include/asm/div64.h | 1 + > 1 file changed, 1 insertion(+) Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com