mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>, "Christopherson,,
	Sean" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Subject: Re: [PATCH 0/2] KVM: VMX: Fixes for faults on ENCLS emulation
Date: Thu, 6 Apr 2023 09:19:53 +0000	[thread overview]
Message-ID: <0a7d019d98058a119eff9f12ea185855f4e1e02b.camel@intel.com> (raw)
In-Reply-To: <20230405234556.696927-1-seanjc@google.com>

On Wed, 2023-04-05 at 16:45 -0700, Sean Christopherson wrote:
> Found-by-inspection (when reviewing Binbin's patch) fixes for incorrect
> emulation of faults when KVMintercepts and emulates (sort of) ENCLS.
> 
> Very much compile tested only.  Ideally, someone with SGX hardware can
> confirm that these patches are correct, e.g. my assessment that KVM needs
> to manually check CR0.PG is based purely of SDM pseudocode.

Thanks for the patches.  I don't have a "ready" SGX environment at hand, but
I'll try to test or ask someone else to test after Easter holiday.

> 
> Sean Christopherson (2):
>   KVM: VMX: Inject #GP on ENCLS if vCPU has paging disabled (CR0.PG==0)
>   KVM: VMX: Inject #GP, not #UD, if SGX2 ENCLS leafs are unsupported
> 
>  arch/x86/kvm/vmx/sgx.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> 
> base-commit: 27d6845d258b67f4eb3debe062b7dacc67e0c393
> -- 
> 2.40.0.348.gf938b09366-goog
> 


  parent reply	other threads:[~2023-04-06  9:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 23:45 Sean Christopherson
2023-04-05 23:45 ` [PATCH 1/2] KVM: VMX: Inject #GP on ENCLS if vCPU has paging disabled (CR0.PG==0) Sean Christopherson
2023-04-06  8:54   ` Huang, Kai
2023-04-21  9:18     ` Huang, Kai
2023-04-05 23:45 ` [PATCH 2/2] KVM: VMX: Inject #GP, not #UD, if SGX2 ENCLS leafs are unsupported Sean Christopherson
2023-04-06  9:17   ` Huang, Kai
2023-04-06 18:00     ` Sean Christopherson
2023-04-12 11:15       ` Huang, Kai
2023-04-12 14:38         ` Sean Christopherson
2023-04-12 22:28           ` Huang, Kai
2023-04-21  9:17         ` Huang, Kai
2023-04-06  9:19 ` Huang, Kai [this message]
2023-06-03  0:55 ` [PATCH 0/2] KVM: VMX: Fixes for faults on ENCLS emulation Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a7d019d98058a119eff9f12ea185855f4e1e02b.camel@intel.com \
    --to=kai.huang@intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®