From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-131.mta0.migadu.com [91.218.175.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE91379EC8 for ; Wed, 12 Aug 2026 11:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786534119; cv=none; b=ikvMS9Eduu3JnA7sbqwATvEvwDQ5J4RdcXgO1JHiZ1Pmqj5DCAkGSqRmIp4rG7TTcGJ/dp4QOvDM8tmYknL/WSRgv+AZy74XL9YVUYEsxEmFYHsF5fExS1xjZEWWMZ555EmFhnalnT9ow+uxFduY6o5s0rFxlEBXRoTHfiXwIZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786534119; c=relaxed/simple; bh=THI+tD1piJf+gjuYAlK9wo233bpWJjlibMyCV4Ey5B0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nsNzAkZtu9GVk8w7QA+QCCytVj5WVU6Sz2279Ay+hucBET6VtvWtaNSVLPPGfw3eno1iaOhhoUyldlhyC6ZU2qd7HdSeJv+ERgawdAU3ooMEgI8rsRA4cGNCwsfZNqm3iiqKre69NjIjyblqI7ad1Q1eybqX9s1dTrHYw68Xx6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com; spf=pass smtp.mailfrom=chenxiaosong.com; dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com header.b=AlfyA9r9; arc=none smtp.client-ip=91.218.175.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chenxiaosong.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com header.b="AlfyA9r9" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=THI+tD1piJf+gjuYAlK9wo233bpWJjlibMyCV4Ey5B0=; c=simple/simple; d=chenxiaosong.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786534112; v=1; x=1787138912; b=AlfyA9r9UZMcb2uM2xLzsciySa3uZCqZaIbqUyC9nN54Ja4liCKCSkDTWzt5RvwoPI4GhEim UVQ4DZEjWzHbZJFSmWkZGm868aZumlaCBQ0IZ3QMA5OHBFklsjHsSKmBhz4duJh2jqlZTOcVUpO IpfFcu7SniWPuxj8xwdR2tNjJnHYkxBdSSARvJN4hFrtmZl5QVe+Qdm9H10XPhQI52ijOwpN8lc mRQQi84qTLFHoW5HYQuiTSHEZN0ADXsMqflp411vxupbyAVbPfPV8ayPnBBfyr+YdfA6TAzqCKu GHyIgfp4uCSIENJ+f0XVIMFBwkWMeNPSmb2gvEYcY+07A== X-Envelope-To: linux-kernel@vger.kernel.org Received: from [172.21.20.206] (116.128.244.171) by smtp.migadu.com with ESMTPS id a6551322dfdde081; Wed, 12 Aug 2026 11:28:22 +0000 Message-ID: <0a841287-9810-43c9-8e7a-d8894d23cbef@chenxiaosong.com> Date: Wed, 12 Aug 2026 19:28:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] ksmbd: add KUnit tests for the DACL declared-size boundary To: Hang Nan <2122295973@qq.com>, Namjae Jeon , Steve French Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org References: <8970140c-1de1-4989-b32c-ea485be00b79@chenxiaosong.com> <20260812103945.82495-1-2122295973@qq.com> Content-Language: en-US From: ChenXiaoSong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for your patches. So far, I have found the following two areas that could be improved. I will finish the review as soon as possible. On 8/12/26 18:39, Hang Nan wrote: > diff --git a/fs/smb/server/Kconfig b/fs/smb/server/Kconfig > index 08d8b7a965a6..05d16052b9a7 100644 > --- a/fs/smb/server/Kconfig > +++ b/fs/smb/server/Kconfig > +config SMB_SERVER_KUNIT_TEST > + tristate "KUnit tests for SMB3 server helpers" if !KUNIT_ALL_TESTS > + depends on SMB_SERVER && KUNIT && SHMEM > + default KUNIT_ALL_TESTS > + It would be better to use `SMB_KUNIT_TESTS` directly. We do not need to add a new config. > diff --git a/fs/smb/server/Makefile b/fs/smb/server/Makefile > index a3e9306055e8..dff9d3cd43bd 100644 > --- a/fs/smb/server/Makefile > +++ b/fs/smb/server/Makefile > +ksmbd-$(CONFIG_SMB_SERVER_KUNIT_TEST) += smbacl_kunit_test.o obj-$(CONFIG_SMB_KUNIT_TESTS) += smbacl_kunit_test.o The kunit tests should be built as a separate .ko instead of being linked into ksmbd.ko. -- ChenXiaoSong Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en