From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384B520B1F5 for ; Wed, 4 Dec 2024 15:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733325931; cv=none; b=LMhoF1HAOZ5Upd+LcJfgLEQrYhVXIWU4+u6EJhyzVzYrDeAv2dCrWwOL1YntbbdtouIv5Dp1imMB1xTN5v0QkpW+DXPXXVlSQG9adTaXXlh7df7XrIj1+K1ryrqT2O7ju3JdicbZwWXHbjcutBZuGCZ/+lrMRbnB5Q5kiyOPw64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733325931; c=relaxed/simple; bh=ItfF21lgCpkme/udRWq5VgMzq0q4roB7rTlqXhTLIG8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=WWqxR+nmyIMNSyDlltGAnfmyMDU0hAQAB0MKxQFKolyuKHzUf6l3ir1JeiwdoYFseseFaAZOewPKfMvgP5NUdEO9WO7dRoZFF6+aA1KIdWwLZoyQ/TRTQiMatYjGKh2fVxvFKTIYge//vjWtDV8gGoiSK5MiouRcOmxWe+Nqvec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LT4VMiVw; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LT4VMiVw" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4349f160d62so57056585e9.2 for ; Wed, 04 Dec 2024 07:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733325926; x=1733930726; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=S8/NXif9wJVFj2hQElb83aSq+sssv9oaN1dht0koEM4=; b=LT4VMiVwV9n/VgwbBo7nHKV4aG1r5hOCvSDgEijFyOkZUMwhXmqb7FFy0bqcb3cHku Pt4ugU0bflv/xeQn3c2ld0UAtbZO7VzRiKBUH5ZUF2F1BM9nIwL9PLsz8jjwYZDdzTHy lstoHHwcTMnHsL2NcljgG0PDEFnlYPuExeWTPK7X6e2tOiL6nSLmLl6lkcN8Bcq+F2FQ u7lSdb+gv8cOttffoouSu2HeLJSwyc0i5VK77g5dRoilMnLRq4OPEkilqjOPZHpyCn/Y DCQG7pmrvWeqrCpcYNqcHdA9pU16BDDrxRgLXXZ7oaGgvQyBmGvZQEf4iPnYhdlErt80 VdLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733325926; x=1733930726; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=S8/NXif9wJVFj2hQElb83aSq+sssv9oaN1dht0koEM4=; b=lN8LucVjboZ6owUcHghOw5S1LmVK3+8N07/kjggPb0UGraiOCDdgoNaFmq49RA4V87 z+EY+5kUmePBx0rpjmtelIna6zWj0qvjtrD7HBmvqHSderqGDPT5akgWimAG0vqhAjk8 oDMxdPaUgZ3/VPToLEs1tkOM397gNvJDf9NdmbkEoquAgBTMF+DDA59BqFAudCPaViuV oIT3G9g7LiiI994AFyEF8P6syYj43k78rcqZ03+CLgkAJx3/MkIGMx7K6O519mM8gd4b dpiiCcLajSlnPuI0dLiOJnddZdM6vq1178VMMALfs5Kg1T8sAzoWK7QiGJoSmMVw+iUp nM3A== X-Forwarded-Encrypted: i=1; AJvYcCU7t2kqYCwzLSvMo6vzb7ebj9qlHJsVYQKwxxeDI/COOReOr3WuEZ/B5SjJeTwPifuQpC0wfP8MJ4XpnDA=@vger.kernel.org X-Gm-Message-State: AOJu0YwDXNzFx4founPUWo7Boq5TkboOGFVqtrIcyVPEd9TwIZQk7HdR XKEYiqPdumwbeCJ0l4j9WdpFv8rl6xHLRznAc1k8Tr0Y4IQ+iA6jBR84dUB/ZJQ= X-Gm-Gg: ASbGncvXJ48dqT7yhncPHNMKy+dNELVhq3l61aqbOKl0GNOWfXi7cwpmORQdOJGN5P9 +sK62d/64uzBGpCstWCMBso3B5Cmk3QVeWyI6hYBnFOJGSPIoARJFe5lTIRI0zDAvL8fJP6ToAt oRV4rmsGECgxexdNxDXnreDukabFJmssiGDDmW304e307Kqf8bqlDEhW/7xdZXB9FPxHnMpxfnW EiTCHgpL7hmRtQLdz2ZJ4V7gvwthcVCh9Drqn7YBK59Yk7q3/c1YNB5u2p4ikLY4dZ+2qq+Qz4f SA3Nwp7G0YSPxGv1DR9YlRGn X-Google-Smtp-Source: AGHT+IHZdt66nSwUCQIPlgcKC9J/gPvEuCIw+nsx+zth2Wzv3Qbr5bQfnlxx8iimG4axcn5Pscuwug== X-Received: by 2002:a5d:64ae:0:b0:385:f2a2:50df with SMTP id ffacd0b85a97d-385fd3e9e05mr5689269f8f.27.1733325926545; Wed, 04 Dec 2024 07:25:26 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:740:b323:3531:5c75? ([2a01:e0a:982:cbb0:740:b323:3531:5c75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385d80a77a0sm16812983f8f.58.2024.12.04.07.25.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 07:25:26 -0800 (PST) Message-ID: <0a85859a-9487-48fd-b1cb-a4a4195a8e63@linaro.org> Date: Wed, 4 Dec 2024 16:25:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v1 1/7] dt-bindings: i2c: qcom,i2c-geni: Document DT properties for QUP firmware loading To: Viken Dadhaniya , andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, broonie@kernel.or, andersson@kernel.org, konradybcio@kernel.org, johan+linaro@kernel.org, dianders@chromium.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org Cc: =quic_msavaliy@quicinc.com, quic_anupkulk@quicinc.com, Mukesh Kumar Savaliya References: <20241204150326.1470749-1-quic_vdadhani@quicinc.com> <20241204150326.1470749-2-quic_vdadhani@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241204150326.1470749-2-quic_vdadhani@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/12/2024 16:03, Viken Dadhaniya wrote: > Document the 'qcom,load-firmware' and 'qcom,xfer-mode' properties to > support SE(Serial Engine) firmware loading from the protocol driver and to > select the data transfer mode, either GPI DMA (Generic Packet Interface) > or non-GPI mode (PIO/CPU DMA). > > I2C controller can operate in one of two modes based on the > 'qcom,xfer-mode' property, and the firmware is loaded accordingly. > > Co-developed-by: Mukesh Kumar Savaliya > Signed-off-by: Mukesh Kumar Savaliya > Signed-off-by: Viken Dadhaniya > --- > .../devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > index 9f66a3bb1f80..a26f34fce1bb 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > @@ -66,6 +66,15 @@ properties: > required-opps: > maxItems: 1 > > + qcom,load-firmware: > + type: boolean > + description: Optional property to load SE (serial engine) Firmware from protocol driver. > + > + qcom,xfer-mode: > + description: Value 1,2 and 3 represents FIFO, CPU DMA and GSI DMA mode respectively. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3] In the code, FIFO mode is default if not specified, please precise it in the bindings aswell. Thanks, Neil > + > required: > - compatible > - interrupts > @@ -142,5 +151,7 @@ examples: > interconnect-names = "qup-core", "qup-config", "qup-memory"; > power-domains = <&rpmhpd SC7180_CX>; > required-opps = <&rpmhpd_opp_low_svs>; > + qcom,load-firmware; > + qcom,xfer-mode = <1>; > }; > ...