From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761174AbcIWRHi (ORCPT ); Fri, 23 Sep 2016 13:07:38 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:36025 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106AbcIWRHf (ORCPT ); Fri, 23 Sep 2016 13:07:35 -0400 Subject: Re: [PATCH] staging: android: ion: mark symbols static where possible To: Baoyou Xie , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com References: <1474636415-15115-1-git-send-email-baoyou.xie@linaro.org> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Laura Abbott Message-ID: <0a883dda-73e3-9785-9a0f-9ba7e5d762d2@redhat.com> Date: Fri, 23 Sep 2016 10:07:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474636415-15115-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2016 06:13 AM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous prototype for 'ion_carveout_allocate' [-Wmissing-prototypes] > drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no previous prototype for 'ion_carveout_free' [-Wmissing-prototypes] > drivers/staging/android/ion/ion_of.c:28:5: warning: no previous prototype for 'ion_parse_dt_heap_common' [-Wmissing-prototypes] > drivers/staging/android/ion/ion_of.c:54:5: warning: no previous prototype for 'ion_setup_heap_common' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > Acked-by: Laura Abbott > Signed-off-by: Baoyou Xie > --- > drivers/staging/android/ion/ion_carveout_heap.c | 10 +++++----- > drivers/staging/android/ion/ion_of.c | 12 ++++++------ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c > index c4f0795..a8ea973 100644 > --- a/drivers/staging/android/ion/ion_carveout_heap.c > +++ b/drivers/staging/android/ion/ion_carveout_heap.c > @@ -33,9 +33,9 @@ struct ion_carveout_heap { > ion_phys_addr_t base; > }; > > -ion_phys_addr_t ion_carveout_allocate(struct ion_heap *heap, > - unsigned long size, > - unsigned long align) > +static ion_phys_addr_t ion_carveout_allocate(struct ion_heap *heap, > + unsigned long size, > + unsigned long align) > { > struct ion_carveout_heap *carveout_heap = > container_of(heap, struct ion_carveout_heap, heap); > @@ -47,8 +47,8 @@ ion_phys_addr_t ion_carveout_allocate(struct ion_heap *heap, > return offset; > } > > -void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr, > - unsigned long size) > +static void ion_carveout_free(struct ion_heap *heap, ion_phys_addr_t addr, > + unsigned long size) > { > struct ion_carveout_heap *carveout_heap = > container_of(heap, struct ion_carveout_heap, heap); > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index de0899a..3486909 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -25,9 +25,9 @@ > #include "ion_priv.h" > #include "ion_of.h" > > -int ion_parse_dt_heap_common(struct device_node *heap_node, > - struct ion_platform_heap *heap, > - struct ion_of_heap *compatible) > +static int ion_parse_dt_heap_common(struct device_node *heap_node, > + struct ion_platform_heap *heap, > + struct ion_of_heap *compatible) > { > int i; > > @@ -51,9 +51,9 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, > return 0; > } > > -int ion_setup_heap_common(struct platform_device *parent, > - struct device_node *heap_node, > - struct ion_platform_heap *heap) > +static int ion_setup_heap_common(struct platform_device *parent, > + struct device_node *heap_node, > + struct ion_platform_heap *heap) > { > int ret = 0; > >