From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012008.outbound.protection.outlook.com [40.107.209.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B89348469 for ; Mon, 22 Dec 2025 16:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422283; cv=fail; b=tGVF3reKy8yUjkn5xDDw7/7xs4JbXL4llyU3RPPOWOyce7VId9pT3CsQxVSBwJz/NzH02CUoYEad5zxOufBNO4v4NwXYNZr0oPy5CdhWaj9u67H4gQsBqFP+2lXMn0Ce2CtNTC74R6zFD3Po5CgBKSr48f9dqxN4TQPzq4r/Me0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422283; c=relaxed/simple; bh=nA5oTMJTuH+wXn2a/+kiVv4arVrWiR7M75QL1uDblzk=; h=Message-ID:Date:To:Cc:References:Subject:From:In-Reply-To: Content-Type:MIME-Version; b=u6hRwtXazSftGFA0odA9EIpfdQrlgNL0VA0HxxMEOlC9Upn3C3oqH1WJLMzNN2hcACJz/Fx561M4TsCJOBqB5bzHn/KOJT9//qJvppKlD6a+6a2+dmOxH0+CPjS1lCCa2NnmO2aFA+8WrHuuvOAIE5bXrIGTeb0IFZCvujIiYRA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=citrix.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=OxNrO9N7; arc=fail smtp.client-ip=40.107.209.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=citrix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="OxNrO9N7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rrGhvcMFmZ/tRRpyfDT9udRhyVK39xDSPlPxtIN2otR125mu5aAiwhdu94QEbReP2EaBGILDfAYpRoYhEiLAptROqRmc34/q6ZIMJHuaDMzWkl97uP34Jc9XGRZ3L9Bg3J6zESQUXmlTqiC8PRKzNX44wvc3tTJuUlnIlYnMifHdVG0UiqED6GabxcJSmoKuO13408PWqKclvxEhoR1yt7e7vtYjnQ55vCO4cqgb1SUNy0YOa/dKWQyyjNZ8hFiyaXAervcuNOaP05E+dpUuawDbqSmC2uXLjFBTId/enbDqxDgCI7QVkVjnmn9Jl0VzltQffDSubei9HKqavtS3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nA5oTMJTuH+wXn2a/+kiVv4arVrWiR7M75QL1uDblzk=; b=q25+s20ccqBAe/rCsIukZ3t+B7ZnMoUwVk48osEWkKFHPdB6QPXXLq2//HsHO1gIeL1LLXwKJHyf1Z/9JQCnE5E/yrh/dTe1v1aMOM7m8nqgIHsUgTRUBixM9mRusvagXU2sgy0YqlTorpda2eftecf5nWppbS9CVAKVpPtQpXNAAy7GvJsGi7aeMi2Kjs5SRnoTAHDbUqdiLA5sYBYGgI2zwGK2Ve+tA5EtRTwNInJqtFLhlMQ3eyrPpUP5YxAX8FAKO2a6HSRl1mIoFDX2jlxp14wDbEFDZzxAgOwnFfDmljTHAXoZZNlwSK55Au+Sy3e1JIuhMoM2LAq6IvpH4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nA5oTMJTuH+wXn2a/+kiVv4arVrWiR7M75QL1uDblzk=; b=OxNrO9N7kCEd+lHJHydzmffRQj4Wqi5SdmkNiWR2WwvV8zzRzSW2mvsSP7N2yD8ei7Hm0aeXacT5cIDL0aIJ+sRMzCxIRkFecvwtVgjiOSG4VR5mMbFhSRlTs2Wffg7Ue0Yn8B/HrvsSyIZ+eMPgWhEh51x1zFD3XNTUbfZSTAQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by MW4PR03MB6617.namprd03.prod.outlook.com (2603:10b6:303:128::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.11; Mon, 22 Dec 2025 16:51:14 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%4]) with mapi id 15.20.9434.009; Mon, 22 Dec 2025 16:51:14 +0000 Message-ID: <0a8b8c63-54dc-4194-bdd8-28c9c3fedc54@citrix.com> Date: Mon, 22 Dec 2025 16:51:10 +0000 User-Agent: Mozilla Thunderbird To: hpa@zytor.com Cc: Andrew Cooper , bp@alien8.de, dave.hansen@linux.intel.com, edumazet@google.com, eric.dumazet@gmail.com, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, torvalds@linux-foundation.org, ubizjak@gmail.com, x86@kernel.org References: Subject: Re: [PATCH 2/2] x86/irqflags: Use ASM_OUTPUT_RM in native_save_fl() Content-Language: en-GB From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0426.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::17) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|MW4PR03MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: aab297f8-c5e9-4493-7714-08de417a5189 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UU9OOUdQTStBenFxL0gvcXJMMXRXZWNrMVM4SGJPNkk1OS9Ub3NzR0lnVm9W?= =?utf-8?B?ZUQxdnphelpYam5BUGhyL05lTThTZWNVd1hqVWR2YVhVWGhtSm1BV012b0di?= =?utf-8?B?UEEwejZROXljRG9aVUxoQ1F5Vlo2V2tETU5nTHhlM3NHTmtvczI0cmJlSWd1?= =?utf-8?B?b1lkYjl6KzVaNFcwVjF2SW83QzFzUTVNcjh6KzE4aU1aYVkzY3l3aVJVRktU?= =?utf-8?B?YXR5SnJZdnNxdklwaGZnSW92RWZUYlN5UW16cXYrYVVGV1NnR1NrbkViQW0v?= =?utf-8?B?Zmw3WUlmT1plUlVHZlNYaGprZjZELy9uYms1bnJ0bC9kVXZMTDYvT0dqL3pl?= =?utf-8?B?S0ZiSXZvRjQwdmU1YjVQMkxYcEJxcVVLQW9VcVlweTVBY2xiemZYNG5kZmcz?= =?utf-8?B?MXRyNTdsYXpiOVRYL3Y3SWJvbG00bUhzdHhqOVVwTnZSaXhaQy9NUkY0ditC?= =?utf-8?B?Zkt0SjZRU0JzNW81bGx3ZzZ0RUEzbmJTa1I0VFFUUmViZktrdnFLZ1hNeWhy?= =?utf-8?B?bmd1TGZrNHZodDFWZHdrY3pqdEkvajgxWHVxM3NCQTVyZWpjL0drSGN0VVla?= =?utf-8?B?U0JsYWJiOFhXOHY1bDdsWkdERnRqUStJbGxidTR4SFI2TTFoM09jS0tmdGc3?= =?utf-8?B?dExLNmhBV2FrQkwzOTI2SDlUd3ZYV1hta2dkcE40SDZKUkVhQ0ZiK2pzdW1y?= =?utf-8?B?Q1BNOEFadVlidnZJaHpwNzBjUmFHeThvcmVZS3pFSU50RWUweDYvSmFPU0Ra?= =?utf-8?B?ZHFpZDhiemYyVkRqS2tsMklKU0N6dVNtNXhzR2c1M3ZCTUZoOEVya3ZoMlp1?= =?utf-8?B?cEtSZS9yQmFQU2Z4N1ZCQXlVOXE0SnpjNHJUaE5JWHJOMzN6V3oxQldPYVhk?= =?utf-8?B?eldrSXh5M2Jud00vSExRYStBMGFFUHMrRkpMNXliWFBjcnJRVEVpNDZLWXY3?= =?utf-8?B?dGJhaG5KQkIyQXR5eGxTZUFzLy81N0RubUlMbzYyWFBkZU8wRjlZbENyT3FP?= =?utf-8?B?eVFFQzJWaWl4dDBBTUdyM1J0U0hrOE0rVEZ5M3FYeXFnZVZMcmZETFZETmRJ?= =?utf-8?B?TklsMUlObEVCaGRhU2JvZFhQUXZUdC9qTWJ0RWNQTEhQdmcvWG5LcHllVTRo?= =?utf-8?B?bnQ5d1orcjMxR3ZkVE1wcDJhSWVUS1BPMktQMzB2enZLY0ZzbHkyeDRiWmxW?= =?utf-8?B?dnNLSTB1ZEVJSTR6bG9EVnhNK0t3eGpLZW5QQkpmSUVscE5MZEJsVVM5azFY?= =?utf-8?B?THpPZ282b1l5ckpyeGpXSG8xcjBQZ24yRU03UHhGL0xDTUdQcXc4dThVK2h4?= =?utf-8?B?MkMvZHYrTTU4bUpoc0Y3bW5sK3EwTWFtZzFUZjRMM0drV2hTNFpkUTJ2MlFx?= =?utf-8?B?Vm13Qk5oTmlUeHN0bWhHOWdZRnk2MGFlaDVQeXJERTZIOUkrYm14aGRzL2xi?= =?utf-8?B?bjE1Um5oMGxuUDNQT09MdCsrdndvSzFSQzJDS0M1K1JEMHNoZzRPajFMbWxw?= =?utf-8?B?KzhrTWxjTFFtZElOekt0aDJZNGZmaDA0cUM5dGZDV1hqTlh5b0xiZkJtMHo5?= =?utf-8?B?MmdkNEpQTkgvU1hoaDJHR0dVMGE5NWxsUTFpY3VULzlzYjVSV1V2K1NtTHN6?= =?utf-8?B?bGhTaEhKU3JCbmk0VnNLV1dXZ3JvOFhpYzg5Z0wrYTc5Wkl2S2h6aDEvM1lU?= =?utf-8?B?WmhVUVRiZUtYMFBYZ1hUMEY2L1UxV2FqdmpLcjNNRW9zdDA0WHBybi8xZDR6?= =?utf-8?B?MlZvaEZzSEtQdm5BU0E2OFVrQThsZllwZDdCZGRRUWFvLzdQZTdaU01oeVdL?= =?utf-8?B?RzZrSkh3ZHdaT1hLRzBqd25CL0wxeDNqcDNKcy9hdzRPWG95SXdvMitWVmZE?= =?utf-8?B?djFjaEFtTFFDYjBQMU5vRTFHNVlhOGJqbUtScTFwazRyNk1nbDhVN01ScEx3?= =?utf-8?B?WnVSNmxlajkwK28zWWZTSk8yU09wWDVITzFNQkp6aExway9RYXV0YytodUFw?= =?utf-8?B?N2ZjeTZ3cXp3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDQzQzFhbGJlWHBlV0NJOHVSQXpDM2tITFN0T3RmMnhoYWRWYm9ia0w2QWdF?= =?utf-8?B?eEJvdkZsamp0Z1NvTk5HaUdUY2ljamJBVi8waHF1OEMvemlmaDI5bGZrS3FU?= =?utf-8?B?b2ltUmh1bnY4MEFsZG5ab2ZCZ2ZJODFZdVZEV21kSENLUWZzQ0Q0cElyMDZr?= =?utf-8?B?bERGU0w5M3oxY2pRNmtuaFpmd3NPbEdzK1ZGL0YwOEdUWnExZzlVM0JtVUR3?= =?utf-8?B?VktZSUhJVm5lRnQ5TjBtS1pxV1dpMjE5RllIQWhESWtnbitlMGw0SDdKUEZn?= =?utf-8?B?ZldjZDljajhTV2RSdktBc3E2d2xVNHhFNWwwaFVVUUplK1ZwM2FCZFE3WW9X?= =?utf-8?B?TU83MW1KNnNyMHh5K2JqaFkwWXFESUtDWCszQ0JiekV2aHhHS2x4WWh3RDF3?= =?utf-8?B?N1ZOUGZBUEpQbjlraXNMc2N5VzBhUkVqcDgyRE5MemZTY1dVbUtyQUdpSXZ5?= =?utf-8?B?eVdNL0VuMVJVQzhrY0EzUm9zRmVQa3JFRkpySGZvWWFvN1VuZ1R4MWJzbTlm?= =?utf-8?B?azIzUEk3WGxvcENOMVZ2RllBY0NKZEJSdUJyNFc4OUxDbFJqRlBzSkdJcE9a?= =?utf-8?B?RXJpdHJBWThxWkRzMVhieWdOL044TFloUnFxdTB1V3p6R011T2JpVml1MHpy?= =?utf-8?B?V3RJcWpEWEV0SVhqaUx6RmsxUHhpbVRIeVZOMWxMMWZRUENXLzZNcFpHejlO?= =?utf-8?B?M1VUWHJISXpsMDk0eVdseGpzVWF1b1NqZEo5UW5lZ0FEVFQrSzZYVXJoNHI3?= =?utf-8?B?V2M4SWh6NDVzZWxvTjk4MG5TeXdueGw0c1htQnUxanJXSVJNWFlxUTBkWEs2?= =?utf-8?B?VDg4eTUxOC90V1N4MWkxNEZMZ1c4QlNORHc2K0JCN0FrRk8zKzA0V1h6Nlp0?= =?utf-8?B?SmxHQVlNcThWWThHaVc4UHpwRjdoN1ZPRG4rVEgreXF0VE80YVZweEErVUVr?= =?utf-8?B?MmN5cGFoc2pJdTdodmdydmZkb3NvVzBQYXhmM1hrNG1ma0crSnBhTk9IaEpB?= =?utf-8?B?akF3MVhlN3I0VjFTemZ4NEgwTFVmSzlEWUhtNW10aS93UFhYZzhjcnpBYnF3?= =?utf-8?B?dk5VdHFaWWx1L0hSQUVSN244TklOZ2ErVzRUVEFreTZodVU4cTU3MnI4aWNU?= =?utf-8?B?d05xWlRGVjdvUmh2WkJSek1qMC95VTVsREowSGUyNDF5cFJyS1BwZUxxdkt2?= =?utf-8?B?eUkxL1NaWlVxUjN1ZTZoamRkYTJVUjVtNXh1R1hzaDJDWktiOXY3NWVWdS9z?= =?utf-8?B?QVRMWHg3bm5Pc1VpTDE0cEFoOU9FQllqbmR3bzBtbWU0bXdiY255ZFZxdVVO?= =?utf-8?B?czZOVmpjNHNwOWNSaGFFZ1F3SHF2R2syenBNaDlDSHg2b25oOW42cGdienZy?= =?utf-8?B?b0VQNmYrbWd0anA0c1lyL2x6U2J6ZWdONm4xYUpQNmI2UWNzdEkrZ2swRndy?= =?utf-8?B?emU0MHh5TnYrSnpTNlh6L0F3OWhTL042UG9peHZyZTVSNEJId29mL2F6a0Rj?= =?utf-8?B?empraXVtaU01M1V4U3ZXT1JlK3BqSHFlVVI5Ri8zaDRpNDg2dEVtczFFcVc1?= =?utf-8?B?N2xLeW9tdEFsVFBScGorNk5QYWRHRlZxbTZQbDlMbk1mUDd0TEluRFo4R2lJ?= =?utf-8?B?MVBIYlBUYkZUaWJWaitMN3RPTk8xK2VxcjJ0ZU1lQmpkMkpqTnI2dlhEWkxH?= =?utf-8?B?NGV0Wmc4TnJWeTJXR3R1amZFT04zNEp6MFJ3aE9sR2NvQjMxZXVhN01nOTFv?= =?utf-8?B?UVgxcTJ2VnBVNmZsdGg4RlR5c01Qdk5weU94MnFqb0hXVU55K2tUUWZJOGcz?= =?utf-8?B?bWZESmdYMHJZbVhFZ012bzFmN242a1huYzdtTzlmN0RSZGsvMi9vTmsxVWFF?= =?utf-8?B?RzBqa1NDblQ5bHdzUENqMWRWZ0F1TzgxcGdLOW9zT3hpQ1p0WTViSXlxRWtQ?= =?utf-8?B?R09TVUkwSnQvaE1BdC9ldzkzV016bWxRaWFCckhDbEtKOW5mYno1NktIS1VV?= =?utf-8?B?REpYZXVDMy9NeUFySXNBb3FQZmwrWGFCaWh4N0FaN0RRcFpyMS9JS2tlYnhF?= =?utf-8?B?MEl4OTVtdFBtSTQvd2NDZWtLSDFIODY2VHVkd0h0ckF0QTlMMzRqc2pwOElD?= =?utf-8?B?NkEyTEk5eVY1aXJvZWV6THFlc2hTYVlBVE5WZXNuRk5UcURTZHFQSFFjTnVa?= =?utf-8?B?NCt3UmpZc2ovNWlPdVJpNk9WVHNCODVIdmw3R2ZsQkNSWFVzNllvU08wR3V5?= =?utf-8?B?OG1KdkdwaDZjeXJTT3hyQ0gwTms5T3RiWmx0bkhnRkk5d04zRHFPbHFMdFI3?= =?utf-8?B?V2h5V0I4N3J6c2I3c2xDNHE0emwrREFMRmc2Q0J1cnNzWjd1OEtIUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: aab297f8-c5e9-4493-7714-08de417a5189 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2025 16:51:14.4892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ibtL92R8EfROSs47ZnESy0gOAmS8OioG1zkx++0QV59cSlWSByYnS+peMLobmjQ9ysOR9SsTdzhr7GPcXswGhbXjJRBff1XMVa46fhDiOgU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6617 >> But something like __builtin_ia32_readeflags_u64() is just entirely >> pointless. What is the supposed advantage over just doing inline >> assembly? > > Unless they are doing something like actually leaving it on the stack... yeah. It's not just pointless, it's actively dangerous.  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104971 At least with inline assembly, it's the programmer's fault when making a mistake like this. ~Andrew