From: Taeung Song <treeze.taeung@gmail.com>
To: David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Don Zickus <dzickus@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim()
Date: Sun, 9 Apr 2017 14:36:56 +0900 [thread overview]
Message-ID: <0a8f5343-25ab-8c58-ddc7-1217e4f1a0ed@gmail.com> (raw)
In-Reply-To: <dede13ee-c3b8-2ee6-aa2a-73f7e3b32dda@gmail.com>
Hi David,
On 04/09/2017 03:48 AM, David Ahern wrote:
> On 4/7/17 8:52 PM, Taeung Song wrote:
>> After reading command name from /proc/<pid>/status,
>> use ltrim() and rtrim() to strip command name, not using
>> just while loop, isspace() and etc.
>>
>> Cc: David Ahern <dsahern@gmail.com>
>> Cc: Don Zickus <dzickus@redhat.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>> ---
>> tools/perf/util/event.c | 11 ++---------
>> 1 file changed, 2 insertions(+), 9 deletions(-)
>>
>
> Acked-by: David Ahern <dsahern@gmail.com>
>
Thank you!
- Taeung
prev parent reply other threads:[~2017-04-09 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 0:52 [PATCH v2 0/5] Refactoring with ltrim() and rtrim() Taeung Song
2017-04-08 0:52 ` [PATCH v2 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim() Taeung Song
2017-04-12 5:42 ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-08 0:52 ` [PATCH v2 2/5] perf annotate: Use stripped line instead of raw disassemble line Taeung Song
2017-04-12 5:42 ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-08 0:52 ` [PATCH v2 3/5] perf ui browser: Refactor the code to parse color configs with ltrim() Taeung Song
2017-04-08 0:52 ` [PATCH v2 4/5] perf pmu: Refactor wordwrap() " Taeung Song
2017-04-08 0:52 ` [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() Taeung Song
2017-04-08 18:48 ` David Ahern
2017-04-09 5:36 ` Taeung Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a8f5343-25ab-8c58-ddc7-1217e4f1a0ed@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®