From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE3333F8C2 for ; Tue, 6 Jan 2026 18:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722674; cv=none; b=CoNN+bL6g5wNChQzj7D79wbAvbmEmahDlDfMdYH4aSxVi7RGfCd6h3cjnJSG8bt5wrqvsr0ZV1Pqd7r7wrkZVtRJe087Q0gXqCacLFTgZ6R1QK2bnqTjaA/YtqAgu8+wcV35LmAXxB1PxIKqUDrcSJYi7wPQA460BXdy8FhYE6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722674; c=relaxed/simple; bh=7Xx+IDm74UfQJab0hVpqGn/x5xl+7KB5LM6pqt9Pfgs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s/MmMvyyEmglILSUDlQw8kKjDCXTLYusT+kaQzUec3+DYsNcuMX+4qW0MvLgzkucmJar0+2jA7f53cwKp2jNBdODIfzzy1dEJJqT/92sUgcH4AhPRvDI8hSAZ92ogGO11503kzx7D6h1BZ0D0ukjWX5j/NpEePBGmKAxte6ka4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L8aLLcf7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xm/VlNCQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L8aLLcf7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xm/VlNCQ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606GjAbh731466 for ; Tue, 6 Jan 2026 18:04:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uoYjH/FXizvbeOKacVEztDQIaTsAgvnDV35VsNgOY4c=; b=L8aLLcf7fy9Fv06l cgN8+xPqbPeMO53insFnNUq6Vwv7Fi6XjsY35BRtTewuqq9l/WKlI3qeAoMNUTag jjV+fSrMZfpwEZ7MFkVYSfTewkZ8aLv/Z5mRhO6fODpGjyoqCTB6tWo674CI9mBi pYCi15RPnZZm8oIcRinJbzbU9p9FIcFhSq5yZe1tVHoFNWZc5KZBFaEpXKD6pHrV EjQZrdKlUu5P5wDbsYHHBqJXEsQSHGSxFvQuLZ0NpuDGSdhFd5LPSIZY0UVXuU2i aJm7TUICnuMrUQlJLCqwB4gouHFyseKGem8t+KY/nruCs3JY5zSgj+2WSa+k5zn1 0mvt9Q== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh66mg879-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 18:04:31 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ae26a77b76so478769eec.0 for ; Tue, 06 Jan 2026 10:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767722671; x=1768327471; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uoYjH/FXizvbeOKacVEztDQIaTsAgvnDV35VsNgOY4c=; b=Xm/VlNCQcY09lgkrV/5xVNESEIi9yAoougtow+Wcysv6TW6KVheUfba3dDUqT7CZpH 3sx3WW7FEJwyYHyMnPqNmwvsYNIUXdpth4k8kkaZcz1hhCn9dFphJyvmlmCF0jq8GIKs YZOda6549BaSxjAxUca7uX/soYEKm2gp64vTbi2MoZ3wqlkgHQQe1J44Hsf8IhIiuddN AL9j2ZyHkrKgIBpgUYuGjXL2LX6TOH7ZjhwD/0TfbJ5CHgq74IRQCBQCOMFLRkPBgZvZ uqHDGK99zwR81UaMar+EO6EP/I0zwxh0ChqXDcrZLLIhY4mVOEXnd0bkvhun8eOQuUy4 Ujjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767722671; x=1768327471; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uoYjH/FXizvbeOKacVEztDQIaTsAgvnDV35VsNgOY4c=; b=AknrEdlisY9ZEn1mqAG5wT70uoKi2ofMaAccLPPRWfi394JYMAy6mW6623FSHbYd/e iYN5J+fyMEeLp89TR3PMhwQxbKCaezxcVZv+5H6xbCquWMVPakznwUCKrJ2wfbZENqXe WvQNjJrDJlUBowZhjkhzU4o4Ckr6tMYNVyDJHGMjZv2kL7ajKTmfKrC44ETnMKdBa+8q BI9PQe4pc5vdgbR7G1u5IYhCkEG9ab3aaMDlKXYNW/sY1dAdUejtjA7SKO/KMHBlBcLn cbLCCP86glaz9OsgcmQ5NO/p0UBNVGbchusEHgT0BXErOZ5d0pvRLQbebgv/9kuobwN2 gSBg== X-Forwarded-Encrypted: i=1; AJvYcCVPI53IuEdCYeVlzccGDDqO0N2VfxJFZzlmYFWGz6SQuYa+FjM7z3kXE+KbGmxTAiXEpuJEDcUhR9xuL6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzKXk+ECHVut2cx7xcALJ1gmlMkC8TtrWETnuQgu7k+H2pDnyVW gwfrfLJ9/XZVf69PV9pv+veSAXwyBxh6IU/tEsITW8qVl2LEm6biAb4n15BKXxHtp5bjjNx6xH+ +iueKlucIFpO688oW9diNgjemuTTpQe1Tzs6ruynuN9zr8Tob0iAq029ygSjE9p6asIM= X-Gm-Gg: AY/fxX4p84jliV3yZFAAUXoY9vjFm7FWZlLqPfPxcqPQ2uyCNxlxwqfoe2FLsHlJYcP CnvBah67TvYA9GVqRTxMWlj8G2pL3xkDGh6R0Nj/hHToEMw9q/h5e4/9YQB5puBWZEbklnpLXFK rurmkYpX/8kSiZAR1PVOpmRe0NuY5DBu1zlyyXxHkU2vRUB9kEcC1IhUPfXyNzu1yehmEzqmMCH XXXK6UVTks14ubihhW7oTm498BDv2fm+oiIwTxVRCJIS2YZt6VkZdx7Y5XUCS/Wp4DOwccVsnCZ oMfrKzgkbyAgm95/1vdmBP067tG7OoP2lUSp8MKaFWzN+vUYqRfcd57zfFRcrdcI3hidXi1t7NU pvuv7L91m3Qp9++xaXl1qSXV5zol/O9VidpTjnzd59+bV X-Received: by 2002:a05:7301:1a04:b0:2ae:4f61:892e with SMTP id 5a478bee46e88-2b16f9293fcmr2664473eec.36.1767722670401; Tue, 06 Jan 2026 10:04:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsg6oBHLPeBiWqo2V9wrHF2AafFO/aPeVSn8WYZodXTtdnJzkxJvkIxgi7Yhd/Olvi/BswGg== X-Received: by 2002:a05:7301:1a04:b0:2ae:4f61:892e with SMTP id 5a478bee46e88-2b16f9293fcmr2664449eec.36.1767722669798; Tue, 06 Jan 2026 10:04:29 -0800 (PST) Received: from [172.20.10.12] ([172.56.240.157]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707b2256sm4044156eec.25.2026.01.06.10.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 10:04:29 -0800 (PST) Message-ID: <0a9bfef7-0d9c-4567-a430-81bae7b13aba@oss.qualcomm.com> Date: Tue, 6 Jan 2026 10:04:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] media: dt-bindings: Add CAMSS device for SM8750 To: Vladimir Zapolskiy , Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-2-646fee2eb720@oss.qualcomm.com> <20251127-smart-tuatara-of-downpour-88c16d@kuoka> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ewU38XA4xm9WlctBxYWWkLxuCKD8AMkz X-Authority-Analysis: v=2.4 cv=PoSergM3 c=1 sm=1 tr=0 ts=695d4eaf cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=J3Fo5nLEaHaPiRlpdRcYgw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4ttYkhS-lo2g2XGx6woA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDE1NiBTYWx0ZWRfX+Lbc97U7E0cs HUS99AKgOG9+tuumuNDQ2LNB1RgxwiFB415OuemA2oSvze9P+V41c1eAQy+EHR0OHhGMeGV2RUi WRFeFdMZWxlI5Vgzz0V2S9WqVKAu3gtvoYeplrhbhzHPgzwBBlyN3nBH4E61oGaiLL/8T2JRw28 /utvU41w1uGJnZwq74b4Wmk4++xgL6Zpaoq4GK8qLCszoKH5Yf9s01o5a3ZB/v+4/qk6Y7mwFOV 1hd9EJlk4LhRHj+zOF7yErNd1gkf98E/JYC0c+KMmHemfsjHDfx/ABcthqyT/YJlXpZrrlD3N3H kmS7wT1vdSAozbXmSEWDcN3VQt1acNBrnSEizRaDinuBq2O4rVBOojEKVEwels2y4Oj48gVudwE wgR1yO9dTLbTpoegBfaG3e4DgFnt1UbxWkKEVuLBNGFcMBFAxYuRVZOtd9BN8zT95o9ACKkECIB SHpbfNptzSVh51ES6Mw== X-Proofpoint-ORIG-GUID: ewU38XA4xm9WlctBxYWWkLxuCKD8AMkz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 clxscore=1015 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060156 On 12/3/2025 5:31 PM, Vladimir Zapolskiy wrote: > On 11/27/25 10:10, Krzysztof Kozlowski wrote: >> On Wed, Nov 26, 2025 at 01:38:35AM -0800, Hangxiang Ma wrote: >>> Add the compatible string "qcom,sm8750-camss" to support the Camera >> >> s/to support the/for the/ >> >> Bindings do not support hardware. >> >>> Subsystem (CAMSS) on the Qualcomm SM8750 platform. >>> >>> The SM8750 platform provides: >>> - 3 x VFE, 5 RDI per VFE >>> - 2 x VFE Lite, 4 RDI per VFE Lite >>> - 3 x CSID >>> - 2 x CSID Lite >>> - 6 x CSIPHY >>> - 2 x ICP >>> - 1 x IPE >>> - 2 x JPEG DMA & Downscaler >>> - 2 x JPEG Encoder >>> - 1 x OFE >>> - 5 x RT CDM >>> - 3 x TPG >>> >>> Signed-off-by: Hangxiang Ma >>> --- >>>   .../bindings/media/qcom,sm8750-camss.yaml          | 664 >>> +++++++++++++++++++++ >>>   1 file changed, 664 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml >>> b/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml > > > >>> + >>> +  vdd-csiphy0-0p88-supply: >> >> 88->8, so: vdd-csiphy0-0p8-supply: > > I would make a minor correction here, it'd be rather 0p9. Sure, thanks. > >> Same in other places. This is how it is called for every binding. >> >>> +    description: >>> +      Phandle to a 0.88V regulator supply to CSIPHY0 core block. >>> + >>> +  vdd-csiphy0-1p2-supply: >>> +    description: >>> +      Phandle to a 1.2V regulator supply to CSIPHY0 pll block. >>> + >>> +  vdd-csiphy1-0p88-supply: >>> +    description: >>> +      Phandle to a 0.88V regulator supply to CSIPHY1 core block. >