mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Luca Ceresoli <luca@lucaceresoli.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, rydberg@bitmath.org,
	linux@roeck-us.net, stefan.schoefegger@ginzinger.com,
	simon.budig@kernelconcepts.de, martink@posteo.de,
	a.mathur@samsung.com
Subject: Re: edt-ft5x06 question
Date: Fri, 17 Nov 2017 19:47:24 +0100	[thread overview]
Message-ID: <0aa205cc-b4f0-287b-25b2-1d8fc93b91e4@micronovasrl.com> (raw)
In-Reply-To: <2352100a-db85-e469-95b1-02d9180aba41@lucaceresoli.net>

Hi Luca,

Il 17/11/2017 18:16, Luca Ceresoli ha scritto:
> Hi Giulio,
> 
> On 15/11/2017 17:30, Giulio Benetti wrote:
>> Hi Luca,
>>
>> I had problems with e-mail filter, so I rebuilt yours by hand.
>> Forgive me.
>>
>> See below.
>>
>> Thanks
>> Kind regards
>>
>>> Hi Giulio,
>>>
>>> On 14/11/2017 22:42, Giulio Benetti wrote:
>>>> Hello everybody,
>>>>
>>>> I'm using ft5206 with edt-ft5x06.c driver,
>>>> but what I see is that registers with M09 or M06
>>>> seem different from focaltech ft5206
>>>> https://www.buydisplay.com/download/ic/FT5206.pdf
>>>>
>>>> For example, except address 0x80 for threshold register(thgroup),
>>>> all the others don't appear:
>>>> GAIN 0x30 or 0x92 should be 0x82(thcal maybe?)
>>>>
>>>> Can someone clarify this?
>>>
>>> Are you having any problems, or just investigating?
>>
>> I need to add some other IC register to calibrate sensibility with
>> different glasses, but starting from ft5x06 or other Focaltech standard
>> IC FW.
> 
> If I understood correctly you want to implement auto-calibration, and in
> order to do that you need the four extra registers, not mentioned in the
> Focaltech datasheet. Right?

Yes, I need them inside the driver.
And some of them could be useful also as attributes.

> 
>>>> Maybe M06 or M09 are a custom firmware for focaltech ft5x,
>>>> then it has different registers?
>>>
>>> All the FT5x06 are 8051-based chips designed to implement touchscreen
>>> controllers. The FT5x26 are similar but with a more powerful core
>>> (Cortex-M IIRC).
>>>
>>> As far as I could understand and guess, their register interface is
>>> fully implemented in firmware, so it could change completely from one
>>> panel to another. However all panels that I have seen seem to use
>>> firmwares with either the "M06" or the "M09" protocol, which are
>>> implemented in the Linux driver.
>>
>> In my case driver recognizes M09, but only address 0x80
>> register(thgroup) is correct.
>> The others:
>> GAIN: 0x92
>> GAIN: 0x93
>> GAIN: 0x94
>> GAIN: 0x95
>>
>> are not described in that datasheet.
> 
> What about all the other registers? The datasheet lists a few dozen, not
> only 0x80. Are they implemented in the panel you are working on?

Yes they are, but as Datasheet is signed, this makes me believe that 
that is the default firmware focaltech load in factory.
So yes, they're implemented in 4 different panels I have.

> 
>> The point is that datasheet seems to be official by Focaltech,
>> like if they deliver that IC with a standard FW inside.
>> I can't find a way to safely probe if it's a standard FW or from EDT M09
>> or M06.
> 
> Since everything is based on the programmed firmware, and there's no
> "standard" way to detect firmware version, every firmware detection is
> bound to be a hack. But there's no better way I'm afraid. Thus device
> tree seems the only reliable way...

I think the same.

> 
> However, did you check registers FIRMID, FT5201ID (CTPM Vendor ID) and
> ID_G_LIB_VERSION_H/L? According to their name they might hold
> interesting info.

Still not, I will.

> 
> And did you consider read the "additional registers" tentatively during
> probe to detect whether they are present? What effect would this have on
> chips without those registers?

This doesn't sound so good to me.
It gives me an'idea of unstability.

So how can I go on?
Do I try to write a specific focaltech-ft5x.c driver?

> 
> Bye,
> 


-- 
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

  reply	other threads:[~2017-11-17 18:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 16:30 Giulio Benetti
2017-11-15 22:29 ` Giulio Benetti
2017-11-17 17:16 ` Luca Ceresoli
2017-11-17 18:47   ` Giulio Benetti [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-14 21:42 Giulio Benetti
2017-11-15  8:50 ` Luca Ceresoli
2017-11-15  9:32 ` Simon Budig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aa205cc-b4f0-287b-25b2-1d8fc93b91e4@micronovasrl.com \
    --to=giulio.benetti@micronovasrl.com \
    --cc=a.mathur@samsung.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luca@lucaceresoli.net \
    --cc=martink@posteo.de \
    --cc=rydberg@bitmath.org \
    --cc=simon.budig@kernelconcepts.de \
    --cc=stefan.schoefegger@ginzinger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®