From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbdLNSWq (ORCPT ); Thu, 14 Dec 2017 13:22:46 -0500 Received: from merlin.infradead.org ([205.233.59.134]:34160 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754033AbdLNSWn (ORCPT ); Thu, 14 Dec 2017 13:22:43 -0500 Subject: Re: [PATCH] pinctrl: axp209: add missing Kconfig dependencies To: Quentin Schulz , linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@free-electrons.com, linux-sunxi@googlegroups.com References: <20171214094335.899-1-quentin.schulz@free-electrons.com> From: Randy Dunlap Message-ID: <0aa972ed-dc37-4d03-7e08-95cc32f7a45e@infradead.org> Date: Thu, 14 Dec 2017 10:22:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171214094335.899-1-quentin.schulz@free-electrons.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2017 01:43 AM, Quentin Schulz wrote: > This fixes some compilation issues. > > GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at > least for pinmux_ops and GPIOLIB for at least gpio_chip. > > Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features") > > Reported-by: Randy Dunlab > Signed-off-by: Quentin Schulz Acked-by: Randy Dunlap Thanks. > --- > drivers/pinctrl/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ce126955212c..1dd445116432 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -66,6 +66,10 @@ config PINCTRL_AS3722 > config PINCTRL_AXP209 > tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support" > depends on MFD_AXP20X > + depends on OF > + select PINMUX > + select GENERIC_PINCONF > + select GPIOLIB > help > AXP PMICs provides multiple GPIOs that can be muxed for different > functions. This driver bundles a pinctrl driver to select the function > -- ~Randy