From: Loys Ollivier <lollivier@baylibre.com>
To: Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] firmware: qcom: scm: Fix incorrect of_node_put call in scm_init
Date: Wed, 6 Dec 2017 10:54:32 +0100 [thread overview]
Message-ID: <0aae19bc-d1b8-3f61-0646-eaea021d8518@baylibre.com> (raw)
In-Reply-To: <1512489134-28220-1-git-send-email-lollivier@baylibre.com>
Please discard this patch. The if statement becoming a one liner, the
curly brackets should be removed. I will send a v2.
On 05/12/2017 16:52, Loys Ollivier wrote:
> When using other platform architectures, in the init of the qcom_scm
> driver, of_node_put is called on /firmware if no qcom dt is found.
> This results in a kernel error: Bad of_node_put() on /firmware.
>
> The call to of_node_put from the qcom_scm init is unnecessary as
> of_find_matching_node is calling it automatically.
>
> Remove this of_node_put().
>
> Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> ---
> drivers/firmware/qcom_scm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index af4c75217ea6..575930c80fba 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -633,7 +633,6 @@ static int __init qcom_scm_init(void)
> np = of_find_matching_node(fw_np, qcom_scm_dt_match);
>
> if (!np) {
> - of_node_put(fw_np);
> return -ENODEV;
> }
>
>
prev parent reply other threads:[~2017-12-06 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 15:52 Loys Ollivier
2017-12-06 9:54 ` Loys Ollivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aae19bc-d1b8-3f61-0646-eaea021d8518@baylibre.com \
--to=lollivier@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®