From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53C9EB64D9 for ; Wed, 12 Jul 2023 07:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbjGLHso (ORCPT ); Wed, 12 Jul 2023 03:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbjGLHsi (ORCPT ); Wed, 12 Jul 2023 03:48:38 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711131994 for ; Wed, 12 Jul 2023 00:48:36 -0700 (PDT) Received: from kwepemm600013.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R18ts4xp2zPkFx; Wed, 12 Jul 2023 15:46:13 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 12 Jul 2023 15:48:33 +0800 Subject: Re: [PATCH -next v2] ubifs: Fix some kernel-doc comments To: Yang Li , CC: , , Abaci Robot References: <20230712074637.129248-1-yang.lee@linux.alibaba.com> From: Zhihao Cheng Message-ID: <0ab0a5de-8530-7cbc-ded0-0ca9cfdfa5e9@huawei.com> Date: Wed, 12 Jul 2023 15:48:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20230712074637.129248-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2023/7/12 15:46, Yang Li дµÀ: > Add description of @time and @flags in ubifs_update_time(). > > to silence the warnings: > fs/ubifs/file.c:1383: warning: Function parameter or member 'time' not described in 'ubifs_update_time' > fs/ubifs/file.c:1383: warning: Function parameter or member 'flags' not described in 'ubifs_update_time' > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5848 > Signed-off-by: Yang Li > --- > > --change in v2: > According to Zhihao's suggestion, add a more accurate description to @flags. > > fs/ubifs/file.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index 436b27d7c58f..860497532555 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -1375,6 +1375,9 @@ static inline int mctime_update_needed(const struct inode *inode, > /** > * ubifs_update_time - update time of inode. > * @inode: inode to update > + * @time: timespec structure to hold the current time value > + * @flags: time updating control flag determines updating > + * which time fields of @inode > * > * This function updates time of the inode. > */ > Reviewed-by: Zhihao Cheng