From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBot8e47SBubUYw60wLQtk8EK1QS5waIW1rF2pP1NbO2xlQy4+Gz4MEG6Y666pbCAIPYP+zFF ARC-Seal: i=1; a=rsa-sha256; t=1516298628; cv=none; d=google.com; s=arc-20160816; b=k0vA0KZHZUltLIbFIpO93pJXN00gcRK+KI8MVEi5lcE7ivMSzs9i5e0hx85yzuPLSI /MmvkTSg+cRsAVuz/UfeQN935uRvIxiZIslyntMpiVNch4ob0Cd6NUmnCG/8lnt0jOi3 NEKTZKi3pGQquuIarp+SKfnmEty57h60A2sXy48fjE2kupoVR6S6QyO0xLPIDP5r2Ohb KdoysthLFaHKHOfnL75wai8B6CqO0ih/A7KcVKB1kZRHS5MCroHudLoXd5OPSMtGE1++ KFM9meHAC9UlW+FLiu+2opDK/MuuG/Z5ielCtnnm3oR09mfUV5tAXS/b9QyKqbkYDs8h lZxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=a5w9kUfr08i8fun2fEsD720B3jN4fdmbX7hJJccfRmI=; b=CNgYZ5y6yAtA1QmvQGJyxMN67e3+S2vty7a9sseWh4/yAoxlArnmP2kf8tnluHRvaw G3BsLeBZuA4PuWr0+/PkLd/BXC5S/yVkl6Bk4dfcIAaIxf+UpTCjEs2EMBiJu0IDkFJO s3QgJJ1EMfbwdP1KlWjFOVEcCajiPXroxNtgySqoCK+3c1gt3AHO8w4i657O8r3bpbpV HrqvaPWRLQQEpdBf62SqG1KDQGD2UlRsYVbLb+mVj9LnYOPKy14kK0d5PwTZhbTHueh6 LIRyYwRAPy7R+AfGHDciARz/SqmE3fyQCh1xr8KTmYaxwuoU97Wh5kGNFsCByQycc5fC 5YTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LVXm3eoq; dkim=pass header.i=@codeaurora.org header.s=default header.b=mB4JC6b9; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LVXm3eoq; dkim=pass header.i=@codeaurora.org header.s=default header.b=mB4JC6b9; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1FA2D6074C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC To: poza@codeaurora.org Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> <64127dba1cebab196c88a160191ebee0@codeaurora.org> From: Sinan Kaya Message-ID: <0ab49441-548e-a5bc-d76b-bdc6fa7495dc@codeaurora.org> Date: Thu, 18 Jan 2018 13:03:45 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <64127dba1cebab196c88a160191ebee0@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589954350531136532?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/18/2018 1:00 PM, poza@codeaurora.org wrote: >> I think you would put into include/linux/pci.h only if there is an external >> use of constant outside of drivers/pci directory. Otherwise, you should keep >> the setting inside one of the header files in drivers/pci directory. >> >> I don't see any other subsystem caring about DPC_FATAL definition. > > ok so you are suggesting to move only DPC_FATAL ? so then AER can stay where it is. Now that both AER and DPC handling is getting unified, I think it makes sense to keep all error codes (AER+DPC) together in drivers/pci/pci.h rather than having them split in aer.h and dpc.h. Otherwise, how would we avoid having a new error type defined with the existing values. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.