Re: [PATCH net-next v18 08/10] netlink: specs: Add ethernet port listing with ethtool

["Christophe Leroy (CS GROUP)" <chleroy@kernel.org>]

Le 27/09/2026 à 15:36, Maxime Chevallier a écrit :
> Ethernet network interfaces may have more than one front-facing port.
> The phy_port infrastructure was introduced to keep track of
> these ports, and allow userspace to know about the presence and
> capability of these ports. Add a ethnl netlink message to report this
> information.
> 
> Tested-by: Aleksei Sviridkin <f@lex.la>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

I'm not an expert in documentation language, but the content makes sense 
and looks consistant.

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   Documentation/netlink/specs/ethtool.yaml      | 55 +++++++++++++++++++
>   Documentation/networking/ethtool-netlink.rst  | 36 ++++++++++++
>   .../uapi/linux/ethtool_netlink_generated.h    | 22 ++++++++
>   3 files changed, 113 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 5dd4d1b5d94b..35e028c0be29 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -210,6 +210,11 @@ definitions:
>         -
>           name: discard
>           value: 31
> +  -
> +    name: port-type
> +    doc: type of physical connector
> +    type: enum
> +    entries: [mdi, sfp]
>   
>   attribute-sets:
>     -
> @@ -1905,6 +1910,32 @@ attribute-sets:
>           name: link
>           type: nest
>           nested-attributes: mse-snapshot
> +  -
> +    name: port
> +    attr-cnt-name: --ethtool-a-port-cnt
> +    attributes:
> +      -
> +        name: header
> +        type: nest
> +        nested-attributes: header
> +      -
> +        name: id
> +        type: u32
> +      -
> +        name: supported-modes
> +        type: nest
> +        nested-attributes: bitset
> +      -
> +        name: supported-interfaces
> +        type: nest
> +        nested-attributes: bitset
> +      -
> +        name: type
> +        type: u32
> +        enum: port-type
> +      -
> +        name: upstream-port
> +        type: u32
>   
>   operations:
>     enum-model: directional
> @@ -2859,6 +2890,30 @@ operations:
>               - worst-channel
>               - link
>         dump: *mse-get-op
> +    -
> +      name: port-get
> +      doc: Get ports attached to an interface
> +
> +      attribute-set: port
> +
> +      do:
> +        request:
> +          attributes:
> +            - header
> +            - id
> +        reply: &port-get-op-reply
> +          attributes:
> +            - header
> +            - id
> +            - supported-modes
> +            - supported-interfaces
> +            - type
> +            - upstream-port
> +      dump:
> +        request:
> +          attributes:
> +            - header
> +        reply: *port-get-op-reply
>   
>   mcast-groups:
>     list:
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index 393f2b6d3863..eba226c79ec3 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -247,6 +247,7 @@ Userspace to kernel:
>     ``ETHTOOL_MSG_RSS_CREATE_ACT``        create an additional RSS context
>     ``ETHTOOL_MSG_RSS_DELETE_ACT``        delete an additional RSS context
>     ``ETHTOOL_MSG_MSE_GET``               get MSE diagnostic data
> +  ``ETHTOOL_MSG_PORT_GET``              get port information
>     ===================================== =================================
>   
>   Kernel to userspace:
> @@ -305,6 +306,7 @@ Kernel to userspace:
>     ``ETHTOOL_MSG_RSS_CREATE_NTF``           additional RSS context created
>     ``ETHTOOL_MSG_RSS_DELETE_NTF``           additional RSS context deleted
>     ``ETHTOOL_MSG_MSE_GET_REPLY``            MSE diagnostic data
> +  ``ETHTOOL_MSG_PORT_GET_REPLY``           port information
>     ======================================== =================================
>   
>   ``GET`` requests are sent by userspace applications to retrieve device
> @@ -2537,6 +2539,39 @@ Within each channel nest, only the metrics supported by the PHY will be present.
>   See ``struct phy_mse_snapshot`` kernel documentation in
>   ``include/linux/phy.h``.
>   
> +PORT_GET
> +========
> +
> +Retrieve information about the physical connection points of a network device,
> +referred to as "ports". User needs to specify a PORT_ID for the DO operation,
> +in which case the DO request returns information about that specific port.
> +
> +As there can be more than one port, the DUMP operation can be used to list the
> +ports present on a given interface, by passing an interface index or name in
> +the dump request.
> +
> +Request contents:
> +
> +  ===================================== ======  ===============================
> +  ``ETHTOOL_A_PORT_HEADER``             nested  request header
> +  ``ETHTOOL_A_PORT_ID``                 u32     port id
> +  ===================================== ======  ===============================
> +
> +Kernel response contents:
> +
> +  ======================================= ======  =============================
> +  ``ETHTOOL_A_PORT_HEADER``               nested  request header
> +  ``ETHTOOL_A_PORT_ID``                   u32     the port's unique identifier,
> +                                                  per netdevice.
> +  ``ETHTOOL_A_PORT_SUPPORTED_MODES``      bitset  bitset of supported linkmodes
> +  ``ETHTOOL_A_PORT_SUPPORTED_INTERFACES`` bitset  bitset of supported MII
> +                                                  interfaces
> +  ``ETHTOOL_A_PORT_TYPE``                 u32     the port type
> +  ``ETHTOOL_A_PORT_UPSTREAM_PORT``        u32     If any, the index of the MII
> +                                                  port that feeds into this
> +                                                  port.
> +  ======================================= ======  =============================
> +
>   Request translation
>   ===================
>   
> @@ -2647,4 +2682,5 @@ are netlink only.
>     n/a                                 ``ETHTOOL_MSG_PHY_GET``
>     ``SIOCGHWTSTAMP``                   ``ETHTOOL_MSG_TSCONFIG_GET``
>     ``SIOCSHWTSTAMP``                   ``ETHTOOL_MSG_TSCONFIG_SET``
> +  n/a                                 ``ETHTOOL_MSG_PORT_GET``
>     =================================== =====================================
> diff --git a/include/uapi/linux/ethtool_netlink_generated.h b/include/uapi/linux/ethtool_netlink_generated.h
> index 8134baf7860f..660e0c08a766 100644
> --- a/include/uapi/linux/ethtool_netlink_generated.h
> +++ b/include/uapi/linux/ethtool_netlink_generated.h
> @@ -78,6 +78,14 @@ enum ethtool_pse_event {
>   	ETHTOOL_PSE_EVENT_SW_PW_CONTROL_ERROR = 64,
>   };
>   
> +/*
> + * type of physical connector
> + */
> +enum ethtool_port_type {
> +	ETHTOOL_PORT_TYPE_MDI,
> +	ETHTOOL_PORT_TYPE_SFP,
> +};
> +
>   enum {
>   	ETHTOOL_A_HEADER_UNSPEC,
>   	ETHTOOL_A_HEADER_DEV_INDEX,
> @@ -840,6 +848,18 @@ enum {
>   	ETHTOOL_A_MSE_MAX = (__ETHTOOL_A_MSE_CNT - 1)
>   };
>   
> +enum {
> +	ETHTOOL_A_PORT_HEADER = 1,
> +	ETHTOOL_A_PORT_ID,
> +	ETHTOOL_A_PORT_SUPPORTED_MODES,
> +	ETHTOOL_A_PORT_SUPPORTED_INTERFACES,
> +	ETHTOOL_A_PORT_TYPE,
> +	ETHTOOL_A_PORT_UPSTREAM_PORT,
> +
> +	__ETHTOOL_A_PORT_CNT,
> +	ETHTOOL_A_PORT_MAX = (__ETHTOOL_A_PORT_CNT - 1)
> +};
> +
>   enum {
>   	ETHTOOL_MSG_USER_NONE = 0,
>   	ETHTOOL_MSG_STRSET_GET = 1,
> @@ -893,6 +913,7 @@ enum {
>   	ETHTOOL_MSG_RSS_CREATE_ACT,
>   	ETHTOOL_MSG_RSS_DELETE_ACT,
>   	ETHTOOL_MSG_MSE_GET,
> +	ETHTOOL_MSG_PORT_GET,
>   
>   	__ETHTOOL_MSG_USER_CNT,
>   	ETHTOOL_MSG_USER_MAX = (__ETHTOOL_MSG_USER_CNT - 1)
> @@ -954,6 +975,7 @@ enum {
>   	ETHTOOL_MSG_RSS_CREATE_NTF,
>   	ETHTOOL_MSG_RSS_DELETE_NTF,
>   	ETHTOOL_MSG_MSE_GET_REPLY,
> +	ETHTOOL_MSG_PORT_GET_REPLY,
>   
>   	__ETHTOOL_MSG_KERNEL_CNT,
>   	ETHTOOL_MSG_KERNEL_MAX = (__ETHTOOL_MSG_KERNEL_CNT - 1)