mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dragos Tatulea <dtatulea@nvidia.com>
To: lirongqing <lirongqing@baidu.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Cindy Lu" <lulu@redhat.com>, "Kees Cook" <kees@kernel.org>,
	virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: fix wrong MLX5_ADDR_OF struct type in alloc_inout()
Date: Mon, 6 Jul 2026 09:09:48 +0200	[thread overview]
Message-ID: <0ae3c300-01b4-49e5-a094-1b4cccc4f114@nvidia.com> (raw)
In-Reply-To: <20260706060902.2341-1-lirongqing@baidu.com>



On 06.07.26 08:09, lirongqing wrote:
> From: Li RongQing <lirongqing@baidu.com>
> 
> In alloc_inout(), the qpc field offset was computed using
> MLX5_ADDR_OF(rst2init_qp_in, ...) in both the INIT2RTR_QP and
> RTR2RTS_QP cases. This is a copy-paste error: each case should use
> its own input structure type to get the correct qpc offset.
> 
> Fix the INIT2RTR_QP case to use MLX5_ADDR_OF(init2rtr_qp_in, ...)
> and the RTR2RTS_QP case to use MLX5_ADDR_OF(rtr2rts_qp_in, ...).
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index ad0d5fbb..eb431a1 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1080,7 +1080,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		MLX5_SET(init2rtr_qp_in, *in, opcode, cmd);
>  		MLX5_SET(init2rtr_qp_in, *in, uid, ndev->mvdev.res.uid);
>  		MLX5_SET(init2rtr_qp_in, *in, qpn, qpn);
> -		qpc = MLX5_ADDR_OF(rst2init_qp_in, *in, qpc);
> +		qpc = MLX5_ADDR_OF(init2rtr_qp_in, *in, qpc);
>  		MLX5_SET(qpc, qpc, mtu, MLX5_QPC_MTU_256_BYTES);
>  		MLX5_SET(qpc, qpc, log_msg_max, 30);
>  		MLX5_SET(qpc, qpc, remote_qpn, rqpn);
> @@ -1098,7 +1098,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		MLX5_SET(rtr2rts_qp_in, *in, opcode, cmd);
>  		MLX5_SET(rtr2rts_qp_in, *in, uid, ndev->mvdev.res.uid);
>  		MLX5_SET(rtr2rts_qp_in, *in, qpn, qpn);
> -		qpc = MLX5_ADDR_OF(rst2init_qp_in, *in, qpc);
> +		qpc = MLX5_ADDR_OF(rtr2rts_qp_in, *in, qpc);
>  		pp = MLX5_ADDR_OF(qpc, qpc, primary_address_path);
>  		MLX5_SET(ads, pp, ack_timeout, 14);
>  		MLX5_SET(qpc, qpc, retry_count, 7);

Thanks for the catch. Luckily those structs have the same layout.

Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>

Thanks,
Dragos

      reply	other threads:[~2026-07-06  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  6:09 lirongqing
2026-07-06  7:09 ` Dragos Tatulea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ae3c300-01b4-49e5-a094-1b4cccc4f114@nvidia.com \
    --to=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®