From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8A121FF49 for ; Thu, 7 Aug 2025 10:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754563827; cv=none; b=eyBPDNCMHgzjral10nk2LmkUxCSmz8xUYUJLZHCggqPdWpBrcvunW0vz2SH/L4gug5DwueTtiOZjj7BvhjYGEmq+wzinTLZzxmAoGyp8XFEAdR0QUM/k5HML60nUpnsOImLE4b8DojRoBiEgNtbiBphAQ/fPOwzBG8L/Nqrp1wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754563827; c=relaxed/simple; bh=Syfn0NEuvRi1yje0O/PsVJqRnUVtWUN/PEXoRX+j6eU=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=KlW+ztDkUk8kytI+yFLGRcD7V0D0FRhltQ2buIRf5mzOXbP8LrNwnaEBbjdPdu//4RdbAiVjrRQIWzlSBSgQ3+lefqAtH/F7A9UhKMQ+MM4pTOP0NcyRMkjRQu1z0iIKNVkV3aBecJ+dcRh9fKCnDbbAxlntgl7VuhF/6VPn4mI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=e2jZcK3M; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="e2jZcK3M" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250807105022epoutp033e54d6d66a33ac91180cb7070be0fdcf~ZdoAO8txq0652306523epoutp03x for ; Thu, 7 Aug 2025 10:50:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250807105022epoutp033e54d6d66a33ac91180cb7070be0fdcf~ZdoAO8txq0652306523epoutp03x DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1754563822; bh=4JuxWH0gBRJFGn1yRVR8bYk8LvsjMgUCt5sZEIKMU0w=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=e2jZcK3MhHShok6QY1JpZA90wrloAaNL1f4N67gVCrQ0cHt+aESjgPMQLu6lIPajZ 2o/Df62U5i3edTPAuG5HKG+UqZG6SD8MQXyyDyAY0Zuu/WxECQbBS9aTx1fFcHYPrI p3d02kLcxwAKqR9Os+i7I8n+CzqCmsa/sio/i6c8= Received: from epsnrtp02.localdomain (unknown [182.195.42.154]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPS id 20250807105021epcas5p3d0cb6d2d9e7317dda010087be19fcb1f~Zdn-wez1Y0694006940epcas5p3R; Thu, 7 Aug 2025 10:50:21 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.94]) by epsnrtp02.localdomain (Postfix) with ESMTP id 4byP7x017Dz2SSKb; Thu, 7 Aug 2025 10:50:21 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20250805052803epcas5p47a93b443b6c085e237adbafc4de1f3b7~Yx8BUYASz2721327213epcas5p4k; Tue, 5 Aug 2025 05:28:03 +0000 (GMT) Received: from FDSFTE361 (unknown [107.122.81.127]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250805052802epsmtip299b7db91253d19087c2c9b5618578ed1~Yx7-3VIlX0050500505epsmtip22; Tue, 5 Aug 2025 05:28:02 +0000 (GMT) From: "Bharat Uppal" To: "'Bart Van Assche'" , , , , , , , Cc: , , "'Nimesh Sati'" In-Reply-To: Subject: RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend Date: Tue, 5 Aug 2025 10:58:00 +0530 Message-ID: <0ae601dc05c9$b749ba60$25dd2f20$@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-in Thread-Index: AQExeeAfBfzr5YSvfr0wrrMUW8ELmAHKrEFuAhf3ztm1iYbGIA== X-CMS-MailID: 20250805052803epcas5p47a93b443b6c085e237adbafc4de1f3b7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P cpgsPolicy: CPGSC10-541,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250804113654epcas5p1dc2a495e16ff0f66eafc54be67550f23 References: <20250804113643.75140-1-bharat.uppal@samsung.com> > -----Original Message----- > From: Bart Van Assche > Sent: 04 August 2025 21:17 > To: Bharat Uppal ; linux-scsi=40vger.kernel.o= rg; > linux-kernel=40vger.kernel.org; James.Bottomley=40HansenPartnership.com; > martin.petersen=40oracle.com; alim.akhtar=40samsung.com; > avri.altman=40wdc.com; linux-samsung-soc=40vger.kernel.org > Cc: pankaj.dubey=40samsung.com; aswani.reddy=40samsung.com; Nimesh Sati > > Subject: Re: =5BPATCH=5D scsi: ufs: exynos: fsd: Gate ref_clk and put UFS= device in > reset on suspend >=20 > On 8/4/25 4:36 AM, Bharat Uppal wrote: > > +static int fsd_ufs_suspend(struct exynos_ufs *ufs) =7B > > + exynos_ufs_gate_clks(ufs); > > + hci_writel(ufs, 0 << 0, HCI_GPIO_OUT); > > + return 0; > > +=7D >=20 > Why '0 << 0' instead of just '0'? Isn't the latter easier to read? Thanks for reviewing. Indeed setting 0 is right, but in the same file ufs-exynos.c, I have seen = HCI_GPIO_OUT register configured using 0 << 0. My intent here is to maintain coding style within the file. With Regards Bharat Uppal >=20 > Thanks, >=20 > Bart.