From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16710C4167B for ; Thu, 9 Nov 2023 05:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232395AbjKIF2s (ORCPT ); Thu, 9 Nov 2023 00:28:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjKIF2p (ORCPT ); Thu, 9 Nov 2023 00:28:45 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C96C126A4; Wed, 8 Nov 2023 21:28:42 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2809a824bbbso382699a91.3; Wed, 08 Nov 2023 21:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699507722; x=1700112522; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=I0FoB1MaP553UDPCYqFN96OUEdvh9cUVbyhLaWy6KOA=; b=jlRQzpC6j2I6/E9IQl/LHZmVC4ysVxensZMkpAeEY1Ag3cMnpFxBobD1GPEORCWV2P kuXWJTJ5IbK+S+uDENMQ7UhwabTFcy8LuvflMheo3BDA4acW8OY3zoiEXuNR04B8zK1F /COcz+AoYIJGO+bG3RiucAcd/h9o8IHbWWdrSwINSUkvzDnPgDa6zMk602ksCJ8MGZB0 Va8W8hXYVkjlkYCKqhPGZDPmX0cHQG+LkvGsW+y7HF6HKRWvyXbd/26ohgs7OF/v1KXP yjZBFLIkiihZkEDjnxGcwDxpKANmU5IFBRllYnVBz+9n5HZFWPVH+zzSWDNYLDkTtz0B 2QVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699507722; x=1700112522; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I0FoB1MaP553UDPCYqFN96OUEdvh9cUVbyhLaWy6KOA=; b=CiT7WPUDFzThtOc52GyKU6OUc6670t2m4aWt9a7iI4dlr0OKnHN6CdrBmFxTClp21K dDeyhBYlDgQjhYnRO2WpA+4UX94ZIWaxWGNXXbCD4Qy3uM11xOQtCjoquh3KzEtlMB6L 0HuFWfAwJMGKZUPCh4pWhGMGyXamL60DaO9zaDYGGO4sYKguuBCW8qIbi5ytrMZ+QW65 bHUtAeWZAtHFicN9j6FFpGaQzJvzFmXDL5dvbJiRUnh4N4nileNLlgov1b4MwtKUKiLz uK4rEWCnBeilyUD3VDyQRrcNEG+aPsEwdEIhee1UILUCX9I/OyGCXBts3IUpJP4Wc8Cv XYog== X-Gm-Message-State: AOJu0YxODvRVTZ8QJGRVpCr0UFu1Qb3N3RqrBwsgaJDPq/mqwSylJhAy hKHISEvwH6Th9iG4k8x2acU39ybggzI= X-Google-Smtp-Source: AGHT+IGHqkOM1vdaS2LSFOD2DH1AIRHT2NP3YpnE6fTOkIS4ksVqi6jR+f/mzNXjyiU7/wtawxj9JQ== X-Received: by 2002:a17:90a:4e:b0:280:2438:120 with SMTP id 14-20020a17090a004e00b0028024380120mr689874pjb.45.1699507722072; Wed, 08 Nov 2023 21:28:42 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 27-20020a17090a031b00b0027cf4c554dasm458796pje.11.2023.11.08.21.28.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 21:28:41 -0800 (PST) Sender: Guenter Roeck Message-ID: <0ae6bcc2-a30d-4840-a21a-0de0b394c309@roeck-us.net> Date: Wed, 8 Nov 2023 21:28:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hwmon: Add a new macro sensor_sysfs_attr Content-Language: en-US To: Ma Jun , jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231109051429.2250774-1-Jun.Ma2@amd.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20231109051429.2250774-1-Jun.Ma2@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/23 21:14, Ma Jun wrote: > The attribute definiations like &sensor_dev_attr_xx_xx.dev_attr.attr > are widely used in drivers. So add a new macro sensor_sysfs_attr t > to make it easier to understand and use. > > For example, user can use the sensor_sysfs_attr(xx_xx) instead of > &sensor_dev_attr_xx_xx.dev_attr.attr > > Signed-off-by: Ma Jun > --- > include/linux/hwmon-sysfs.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/hwmon-sysfs.h b/include/linux/hwmon-sysfs.h > index d896713359cd..7feae637e3b5 100644 > --- a/include/linux/hwmon-sysfs.h > +++ b/include/linux/hwmon-sysfs.h > @@ -14,6 +14,10 @@ struct sensor_device_attribute{ > struct device_attribute dev_attr; > int index; > }; > + > +#define to_sensor_sysfs_attr(_name) \ > + (&sensor_dev_attr_##_name.dev_attr.attr) > + > #define to_sensor_dev_attr(_dev_attr) \ > container_of(_dev_attr, struct sensor_device_attribute, dev_attr) > No. This would just invite people to submit patches converting existing code to use this new macro. Instead of providing macros to support deprecated APIs, convert drivers to use an API which is not deprecated. This would for the most part avoid the need for including hwmon-sysfs.h in the first place and at the same time reduce driver code size significantly. Guenter