From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbdJRQwH (ORCPT ); Wed, 18 Oct 2017 12:52:07 -0400 Received: from mail-eopbgr50101.outbound.protection.outlook.com ([40.107.5.101]:45036 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751224AbdJRQwE (ORCPT ); Wed, 18 Oct 2017 12:52:04 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate() To: Pavel Tatashin , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, mhocko@kernel.org, ard.biesheuvel@linaro.org, mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org, mgorman@techsingularity.net, akpm@linux-foundation.org, steven.sistare@oracle.com, daniel.m.jordan@oracle.com, bob.picco@oracle.com References: <20171013173214.27300-1-pasha.tatashin@oracle.com> <20171013173214.27300-9-pasha.tatashin@oracle.com> From: Andrey Ryabinin Message-ID: <0ae84532-8dcb-10aa-9d69-79d7025b089e@virtuozzo.com> Date: Wed, 18 Oct 2017 19:55:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013173214.27300-9-pasha.tatashin@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM5PR0601CA0033.eurprd06.prod.outlook.com (2603:10a6:203:68::19) To HE1PR08MB2825.eurprd08.prod.outlook.com (2603:10a6:7:2e::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9783282c-3276-441c-b09b-08d516488c8f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:HE1PR08MB2825; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2825;3:rxCLS636JB2so9K+HpQE6YQE7K2wj1VGzKxObQ3CGc5VFWz2+DvH72+xMMHmXSwaUKVGgE7NA01ey/FuYMI0EiEbfElPg+OEz7HY7wcKjZD8M2qEPnz5gBc9I6/e5zenIywR/YR4wuWMHKvhu0wxDSBAeU1sTPwKQaS/5+IWrLfH4iHpL0COZLWvLgLxfVMp5S//oJkDbWsRJksSBa59RzdyQH6Oicm+P+5Cr0cAHDTFf2rwrfrJo3lKLu9+gN9v;25:eAeWUv6qhWSltn2/VK4RMIYiDxYRXcxSADU3K3ePs6fCUXdaUUFFkFhlMtgTADCZhOTZr3AUMwcJqxE3miB+FicxHsxQa7NzPwlUosj0jExZKKMvZ4b3Dal3Q9PZz+oolmEHJMhvUPM2U3QryN9vP8nfrNs2fJXphagfcvzxMHvewzLV8sY8lXjuv+nETHIfDAeBaO2USVg1sPypkwP4GhGiKEpgPH+vi3Q8ESJpz7y1brPsjMlgr0biBXZAop1wVSsfTyiWtPMugksjFMEVbtNtbjgxgy9z7Xgj52EOxlP1xbHkJ0Rr5wHbsvzRAjY95VTmd4IGoD53L8gLIBmCdA==;31:qbK1+N5TkzbidOWZuOzF5sP8temnv+Zs6VxpdlbXEOmUWhIMtDWQ8eZyrvzQzyLQhbhHIAJQ343PCEAV5GvSM4vkpiTjumAgHvz7rYbBFjE2z3JSKu4Bxw3dd6CIgqhICk3n7rXxATfLXfzf5fYI3FWs3bwB76pMldp9zCntIVLt+IX0N7Pk/65e4CdZhE6eKcGIJDm2zUvh/DD2JEFX0DSDaBokR4SgzPOTsk1uuYg= X-MS-TrafficTypeDiagnostic: HE1PR08MB2825: X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2825;20:3oM4z+B9sHmIw+RUO6ivMnVAdjH0t/g+gflWoZDBk1B5sH8Z9FPlIPJXBiwv1mqNpOjxFT89fuiP+WJpU7l/B6SsaLOdNJ1sryS3M/pVGp4IkKoxwDWWUdqja+erdsCAXMTvRSo1san5eLO3m4G5rrTv2jAvPFPU6lCDtDYZU9dIHgAEpJ19czyYdy7j0RZCfKjMG/hCyishsosN+DpER1CVP+nMS2WBxqoAwYiG+lw350VkwtscX5SO6vMaYtV/wVT3F6gNl1bXk7vImq2ZZdUixkCQ0o3by81uyI4bKk/5+NNRWYwqkuNew6/x2Az5W+/Dpswrf4PgK+CbDPWmnkHkK1ztcENwXUxBjcqkbUvvYOKGOa1ExOMgpXN33NgrKkjryafubEfQrNHDSL5FZzT664j2fGq2JPspD6D/RnU=;4:svyA0rLpLO5/WsgzWs+GG80JWJsxmYPeuTEy4QkLYMPxDESU6Dt1AWWg/hAyXTp3mq57ENpSkho9PeLBn+ezM0fzpLVxeGx9SNQZsiTPINrbjCSs6ETzcFxTlJpmccLJpdOplys3iONye7qWlKU7CEY1hw6qQRjR+CdQwge0bVsU3NzSxWYNQ5siEx5objfgrUbNcmuMIL7pVzlBIloDXnktFoBWECLtmHLg6Q1Qyz4d+8/kZ5cGnO3XfTTFyEGo/wJCBEjYVhSXp7UDwbfYvtuQX8mJxxmUMoQfWkb38K0= X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR08MB2825;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR08MB2825; X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(346002)(376002)(24454002)(189002)(199003)(377454003)(316002)(16576012)(2950100002)(230700001)(3846002)(6486002)(6116002)(7416002)(8936002)(77096006)(229853002)(8676002)(83506001)(16526018)(81156014)(65826007)(105586002)(33646002)(189998001)(81166006)(53936002)(97736004)(106356001)(31686004)(53546010)(58126008)(86362001)(25786009)(6246003)(2906002)(47776003)(31696002)(6666003)(64126003)(478600001)(50466002)(65956001)(65806001)(36756003)(68736007)(101416001)(5660300001)(76176999)(66066001)(23676002)(54356999)(7736002)(305945005)(50986999)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR08MB2825;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4TUIyODI1OzIzOkVWSmdFVEZIbjhVQllNZjVkQ0R5R1RGVkV5?= =?utf-8?B?bWV1bjRVUUlJcmRtS0NCanhoRHZqS2NXbWZwWk01Q0E1d0FZQmhUNWFwMG4w?= =?utf-8?B?UGpFV0ZtcWxtc2tYTVgrYVdIaklaZ2FzUTk2Z3BsbmlsVmpYd21IcjZXbmY2?= =?utf-8?B?bkw4QVBKblNCaUcwN3V2eFcvRGpZdCtNcmRucGJ2OVVoSm1DRlNDTHpsN0VQ?= =?utf-8?B?L1ZnKzRhVFRLYTNZUjhQOXE3UkRlV1J3ZERVeVVjSXEwQk0vbjVWTk5TdkNU?= =?utf-8?B?NlhLMXNaOFU4S2NlVjNsSWJFWjJtNTdSc3U3bmppbXhQNGpEcUxtbUM1ZlJ4?= =?utf-8?B?YnBTYzgwOTBrSEZuNWF3VE1ZVFVldEJndFM2ZkxTb1pBc3haeFhRMzBadlNZ?= =?utf-8?B?UnhyMWVyWC9NZWZkSEdpWWxYRUkyczZHVFg5bE9hMHI4MFJ2RlRTVmtnNkRW?= =?utf-8?B?V21nZXN4Wmhmby9ocWJQeEdpZFR0SStHNmRRMW4ydk9NSVdyY3BFZjh2UjhH?= =?utf-8?B?RkVsclN3M1NtemRqa2QxMGxvVnRrQUxUeGlrOTlndWRQTmV5ZmxzemMya3pn?= =?utf-8?B?QzhrWkJGaVdVbHVQa2hqTjhNVnNURXRUdDRkTkNSbEFMNm1ydmptdFdMZk02?= =?utf-8?B?dnllWDFwQlNDbEN0QURNS2lYVXloT3R4T0FxQmtTNEU0bjU0NDhFQjBMS25V?= =?utf-8?B?WWJOMXF5SEFqY3QzYXRUdWVMTkMxWFN5aC9sZ0FjNHBhV0hZMzdZOUNsajZL?= =?utf-8?B?ZmdUVHlSU05OaU9EWEFESnVWWmZaVy9HeVZNSTVXZW56cFozR0Y2YWh2eWNz?= =?utf-8?B?Z0FEd05UbWFualBzSnFZalR2SjF3eWlkRDVRaTNQT3JtUFdPS3VpbHRuaFlZ?= =?utf-8?B?OFE4R25oL0Z6eDBweG9ESi9UZWUyS1FKNS9OQkRBVCtLaDNvcEpIM1ZWNjlS?= =?utf-8?B?c2EzS3BFTjlHU0FPWXdMNTViSVlmSTBRTnN1MHJaNmx1SlZzUGM3QUhqZzVR?= =?utf-8?B?ZXBHRTg4bmZNbjkwcFJMQ1BSNDlYaGZOeDdWaVBuWmJUY2xPUzN0ZVhLZy9l?= =?utf-8?B?Z0JJSnZoVWN4eWdYUW5GQWU1YmxNYWZySTg2Y3RxRmQreHZTTGNWOGVxS2hq?= =?utf-8?B?djJqR3ZnWkYrWUh3L2xXWFVTNFBqVzEydE0vQnptemtvQUZlMk94WnIxUUZl?= =?utf-8?B?N21YZnRDRXV4SjNmNTMwcVRvUHNkT1BBUjA3UnZYZi93cDVlWnV5Sm9ZQXFt?= =?utf-8?B?Y3EzRUs2Tkw4Wi9FUEVmbDRqTitWc0ljT0tOenk5T0FyQXBPcHFBR1k4ck5n?= =?utf-8?B?QW5ibklvNGZOaEhnQ283a0JETFRERndXc013NlZzcGhGRkphaG5PUjFkaHF3?= =?utf-8?B?MFRCSFhSbnVrbHdDZUdxQnU0dnpPWEJQdFhmeGdWaGdnZVVrdHV5MURtTUR4?= =?utf-8?B?OUN3YjJWa0UvNlo0ZmxnUGl0VUhUMjMyZXR4SGR6TU5LWXN3YnZQVmUvRjl2?= =?utf-8?B?WEV0dWxiZXU2cHhoSWF4L21mdXZ5azNETUNyVGtRWnVnNENmTVorRmpUcDVO?= =?utf-8?B?MXFIVlRobnpWRWFydVdSdGR0ZmhGMjNacWRlQjdPaXFhcVVLYnFidlRXdXlK?= =?utf-8?B?ZFVlQmNGNlRQV1lxVnEwS3YvOGFpZWlmS2sxaURnMlJUYU5rbmFxSkdiWkd6?= =?utf-8?B?UElqRk9OMUhnYWVVeEdhU3lRRHNiTERBL0QxNjZEam5VaDg4aldpQ0JLYVIw?= =?utf-8?B?T1Vmc3MyM25sZmNaVFJDc2Jwcmh4cERYUEFSdmlQeUtKeE95SnBrenovR1Nu?= =?utf-8?B?QVhEVGRwYzlORk80T3BUbjVadWJkaW9YTGdZMldick5iMUE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2825;6:9wBRN2bkprTBdlhMyTEM83AfwVdIMIs2Xz2wnD4U38uQ4yICANaNaU67mLlM1+MfU1BnluxhSt/hIiAsdhc82oZJYSi4+5TlXx8SPSmt/qouPLBUPj11hnVkfm6Ew11Ev2VBfequ4jRhHWK3ZElJhM/Jvva6HXuTYsawuqrOEJ6tYNRK0ZgtonBnqvXZwKijGp2k1FZof0FmD+0woOEXVIgfe4JXoZ+udWJeufHJtVk8AEd5lFhTOO1XGYq5ge+y6CPGmDzLh7++LWRLKIJszW9NpO62mal99Wh5Cg6tOpJV0K4+tE5MH47BfGNgb4Kdo5CSpD/6TqMC66rN2w0zVw==;5:wHwsSo+ulf4elIua9O7LLIrlDZ244zf/TdAg9ExWoK9D6cnAlSeeOMfuCJlXCoIxrF8lD8RNsYT+7GT28fXpzPVznRgECy6I586bjbJEIBA/C42ANdrXIX+8QlCXUp8CuO9PJ3w0IqAiA0S1r71bJH1wSzCLu08siIDPqpRXEOI=;24:t9xKr9kbSJ39I8sUr+QxD3L++xr6C5Hf81rpr0orNp6Cnh253mcQQf9Q8OW2iyr/3FZLhe3P5waNLl2C2lYGbIpQKpYVN8t9DcAT4SDCVqU=;7:1cbnMYnAKF6w7sM2/BcDw1QWBDCLdU1+zRKnk4tQXZgyt4/90i5BOHw0ZOncgp3EqBNKY34aSopD3Dzs05ryNbB+nuXx5gDm/+3q3JLMLgyV5l6vtx2XqXa8HVPBTkwlL7D+j4chkGQ8zIaJDY0zbVRMvVCla1BJNbINabIELnQQjIYdipl9D2vV7PSnLy90kwAZGzvx42t9H/Hr7UQbtCQe37GEshD+30nRrU7jrFE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB2825;20:NmXABYrdKfzosfQ2yhEw2yOs1PxyDLEEmWk+s4C5RDlvWZDmFU8nnb6jhNcRQnosGg6bvxJq5yR89ci1yTHgICwMrna9UwBJR0UaSWUTUhGtxf17Nv89v3nP0+RGbsGR7kHXYlt4d0q8g3EmkraAs6tPc3xGM3lfYxbQRnleYOQ= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 16:51:57.3382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2825 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2017 08:32 PM, Pavel Tatashin wrote: > During early boot, kasan uses vmemmap_populate() to establish its shadow > memory. But, that interface is intended for struct pages use. > > Because of the current project, vmemmap won't be zeroed during allocation, > but kasan expects that memory to be zeroed. We are adding a new > kasan_map_populate() function to resolve this difference. > > Therefore, we must use a new interface to allocate and map kasan shadow > memory, that also zeroes memory for us. > What's the point of this patch? We have "arm64: kasan: Avoid using vmemmap_populate to initialise shadow" which does the right thing and basically reverts this patch. This patch as intermediate step looks absolutely useless. We can just avoid vemmap_populate() right away. > Signed-off-by: Pavel Tatashin > --- > arch/arm64/mm/kasan_init.c | 72 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 66 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > index 81f03959a4ab..cb4af2951c90 100644 > --- a/arch/arm64/mm/kasan_init.c > +++ b/arch/arm64/mm/kasan_init.c > @@ -28,6 +28,66 @@ >