From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19FE13A4F3F for ; Wed, 29 Apr 2026 07:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777447440; cv=none; b=MVowzfNDvi4gpT4YWgdBDIhIXPY2wlI1pJ9AtdxY4876KRwyYVt4qDVcxE3ZNW2DCou7rjZBTtgBYIqlCkDrnZGkOWkdyg4Mmca8vT+I0ZoM/eSDNu0PLEjFD1GTFWdhS3WHtGnV8VkHvHHFspesRw3YzYftASRRlrxf6CoU3Hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777447440; c=relaxed/simple; bh=4kMjEWgH0O6MSc6+Ivs0TbjE3sJ/FOasTo+8HTfQQDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qeL8WSnam8ndLPkg1dokhUs5iBrvVNt/CF63eEe+tKV7kl5wdL3cZrNOHXQtFHdVzvP2mV1ZSBbKcwdW7GfNIUImj7tuLeItKTBySpsmTwzednN3M2x1FS/TtHTrRWUwyCMn1ILqyp6pNaDf6pPoPNO3Dp2hmBM9Lbd0uKkbDv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ljn809wL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QukfSswP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ljn809wL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QukfSswP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63T7KnOX1882164 for ; Wed, 29 Apr 2026 07:23:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UvKCNndBBkYUc0nxuFbkUYiO0WRhlXQti+/4X6+udB0=; b=Ljn809wLwDtH+Jki +Z70R9qKW+U6dKJhlu64OADISW1Iw0ExYW0z0WuLKYXgoIcn9l58xSh6Z3EaRJKn +opWAOajEVw0bx3Qs/mKFyy0yWazAua7CHkzC9CCsJCwJDW/niKrzLCPu4J3/xEJ lH1Zx6hrAOLLQhYJpu+9NiZJ5/DFjHNX8bLEm6jP+fVceniOZKN4mSdV2RUzIY42 zx8ps02linokJCndkAeEXE6mGqz5Ca4OWKSjwhsZ1oJmRWttjKwNfRQrPPjyDCPW Ayl49f5E3CsHgs/z6UCGMZkyfnZ2PdI1sbkSYzFXEp/FoEedNs3Y1SHhG6D7hVrr IqJyzw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dudh3r0g9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 07:23:56 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35d9e67f6dcso16706457a91.1 for ; Wed, 29 Apr 2026 00:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777447435; x=1778052235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UvKCNndBBkYUc0nxuFbkUYiO0WRhlXQti+/4X6+udB0=; b=QukfSswP3c1VcFt8QCAnprFaSFgRtDmblOTmCVOYHFZg8lAwrx94OdoGjRBkZln9WD FNWD9k5cEvostEfwjo22lk6VypuW8+evWecBO8tkvvPXw+VPPR1Vg3d4LUxQ0bWBSxIb VkuvrpBNYt+QadFNTL9ERxtPOUFfaLCeLGLtld6kxUVws/XSwVkSZrav0ikD7A/GvMS1 vs9A1xSl0wIj6JezB8Wyi4n79yhvGu+sOx2x454G7Dr4lRY5Dh+znwXh5wIxYOhzC1Bh 1f4fzWV0BuqUVYHo5/RXITiOrqgqgYP9uqZUM9rjzTv+segFt8O+xmU1GBrT+lLKn53Y GBsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777447435; x=1778052235; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UvKCNndBBkYUc0nxuFbkUYiO0WRhlXQti+/4X6+udB0=; b=qhhHVWiZyiIedx1K6aO68NDzI2Il4UStQ8xd0CCKr/JNiEmvsFa/YkkT+pR8ybPMec qhFuiS9rMSmFAYPJuqaWuY3QdIfrjTaUwzVuWsAlzXywpI46bzZE/Zov9sgKTt4uW+R4 EVOd0Dv5q9O+qpwtpY54+E9/KWOEdDAjhCNiaW7rLKoXrzuvTWA/O8vPSsiiAW3QEB+G SbEwOG3H1hKuIT8SCvfpkB+q5nVghQTcyz366wGQ014JDxJBpMVfLJTrMcdL/GN7zcld ZE3GmUIHUaO8PdDic3S0JlrsDHduzZPBtghmuEy0dLyhMwLpa3UsN9bG3kdQpoZtC5Oz 4Piw== X-Forwarded-Encrypted: i=1; AFNElJ8dTvGoDvTpbELioZ197g3Lo7figMwUzNQcRdkpDAGv1+FMDOsYhnxn6g1wVzouBsINMP1tirW0HiYxu2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzWvX3w38xi4Z3TyLTnlBsjB8nEcX+5+ZezChql346pymebbaw8 j3d4JP0fj3EE6ALVvAxUgWSXF1rgHN8bcZ6I3vvsBBIW0BXzgRMm81WxZPK8den4YwUNk6T8A6c TyhAtW35HOFNeFP8nDj/Bm0g9pSXIa6RLRHdGXwwWZSZqDZ6eqHQABCb+MB+VWhBV0xE= X-Gm-Gg: AeBDiesB6VBRNAuJNR/ywJkJwZOK1SgKiQkPF9KqvwfJEEm8Z6Ncqhh8SA+l4m4iQ0+ HuCplqVWiOUJKd/lfB6GgY/KnfOZ8O81uW51Lsr4frgeCucovH5y7D/71XXsXlFZ7HcjzALlxlH c+/e/S29t+9/woOcqE1PLAba3xxW1fyU2UNpcwQFsrskK/XqjyvWmYUo+MDDaSZIvNRZqjhtem/ VT1iVHujzdl5BIqbu7Nrgr+4PkdaAIq+XN6ojzOmLYPP8LJYF2EqJlfmCOsxm5nAs4+q7EIY9mO FH1l/q3bWtaGVrbDqmc/oTQ8vjAeBXz5+YiB6aQpINh7dtKigHYTKikjdYhhObKbWR/p7MgAUtf gqZ808goDutqhVnZvjAZMdAdpKPlNB/G/tLJ4P+b1/h3lrJzqS0LpklwPXjgr+8okiRT/MPpdIj 7AfgLvSOFYZWpiMm5ZDIzZAco39rTgMg== X-Received: by 2002:a17:90b:3fc5:b0:364:74c1:53b7 with SMTP id 98e67ed59e1d1-364a0adec05mr2719577a91.2.1777447435147; Wed, 29 Apr 2026 00:23:55 -0700 (PDT) X-Received: by 2002:a17:90b:3fc5:b0:364:74c1:53b7 with SMTP id 98e67ed59e1d1-364a0adec05mr2719563a91.2.1777447434764; Wed, 29 Apr 2026 00:23:54 -0700 (PDT) Received: from [10.133.33.153] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364a4180219sm1292125a91.5.2026.04.29.00.23.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 00:23:54 -0700 (PDT) Message-ID: <0ae92497-91b7-4eb9-951a-dcd2258f538f@oss.qualcomm.com> Date: Wed, 29 Apr 2026 15:23:51 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: fix warning when unbinding To: Jose Ignacio Tornos Martinez Cc: ath11k@lists.infradead.org, jjohnson@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, stable@vger.kernel.org References: <20260429051414.6625-1-jtornosm@redhat.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260429051414.6625-1-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Fj9dIkwXXHMj7yGxdTXXt_JpZYYo6rnE X-Authority-Analysis: v=2.4 cv=A4dc+aWG c=1 sm=1 tr=0 ts=69f1b20c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=hnrE4znNAVy8RLhoGhIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: Fj9dIkwXXHMj7yGxdTXXt_JpZYYo6rnE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDA3MiBTYWx0ZWRfX/4Jyv700lfZb 0iqKKPSy+7pzCtTxuH2FF0A5LuCPc010jC6HU9T3O6kBWseGzmNxwcOpAFbtBWPfqw2xIbPljsh Nlu6WX6HPCK80q3bB+VkDW/MNH/cJpt4AbcaSjA+C+fktAdWcQdPJ6cKhCvPpqLo231qfars04y oSDWDdlkSRSPNdsgVp/jSSKdB/Wvph894x/iikja6M0IPiYOX38l4RoYIZJy4pDEBnupBOcjeV3 W4YaNZnr3rXuVU4a1jl69Jo9S5/4yC4bhWtm1QI1dMrbRtXGkepApytTe5B4nEj7V+/IcABdjKI poUcanPtGlXXMcUMd3dQoiifsGzrxTgwS82dye9foneYZXPc9Lo9GYRmtmZXQcpYjo9x3xKHR7p P/NK++zaVmAV5XorBIjEaMkJ52mHpUmVeUhOTX7C0IlLQSgZvMUqmbPIJIvl68x2Fll6xZCpNJW F7R0/0NcqVz3HhyiI6w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290072 On 4/29/2026 1:14 PM, Jose Ignacio Tornos Martinez wrote: > Hello Baochen, > > As I try to comment in the commit description, the warning is not at > the intialization, but comes up when the device is unbinded after a > problem at the initialization stage, because due to the problem the > buffers were released (probe). Later after the problem, if the unbinding > is commanded the buffers are released again. > Setting to NUll after releasing avoids the double free. > OK, seems the first release happens during the error handling path of ath11k_core_qmi_firmware_ready(). > The easiest way to reproduce it is to run in a VM the default upstream > kernel (that is always failing on VMs) and just unbind the device > (ath11k_pci). > > The same problem was fixed by me for ath12k driver here ca68ce0d9f4b > ("wifi: ath12k: fix warning when unbinding"), and I have seen the same problem > is also happening for ath11k driver. > > Thanks > > Best regards > José Ignacio >