From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EE136074B for ; Mon, 23 Feb 2026 11:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771845173; cv=none; b=WJEq2LVyamp2OSfZa4XeLcMfZHac31P8tvzu2K0tlxN41ZhAXb5j/MZZgHUMLXtJ9i8H/CQ++lUeEA+yeL5n4CuD3lC1rVEc7xAMGNS9vEpsV7Jh2AED1R2fJhRwYP+tGyDQlRmZH6hYEwKN6a8pt0NR7uhN/8JwB+yD44+dqVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771845173; c=relaxed/simple; bh=q8eA+W36LX/ybN8wpBbHn5OQ+mGmGjizeB/KQ0As6BM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sO/d3OyErP7mUtjIfKKe31sBPWhp1Ul+cN9XYpVbYvPdCGIVR+m7P/IolCiX1krLpcxliZzHmdfAQvmxU2BegSSKOXAmrecy7/F07eLZLpt6S4p/soZ9BgpdXGF7jVSBSO1YeS1hYmt2K02tSHfEnBKIR88bMzNz5mccmsoNvdg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ad4+yNdl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ad4+yNdl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso33286125e9.0 for ; Mon, 23 Feb 2026 03:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771845170; x=1772449970; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xnKDf+x7HLHllT2OTm2TYnpcf3b4bSzsLYz0UOALcks=; b=ad4+yNdl8Tzhv4YEE1rz7gOaW0NU5PjX5oSjwGf385dagtmGevet/HRtjZl3RU+MKb asDhtfmx20n7mfGIh9axKBXVP9Yxy8Y6h+8CJ5egg/AU+lav4U3KggdgtjJjxOxRA0tl c6HCS9k+FHnHJilmrUECSsCjLoa/0YIIEKF4Xzatnic6vddPd3dkfwHFwM5ci7kg6kqh ZTah0z6bLP4EcMipUU0tSnhI53yGIChK5rh5ubKEfpFs684209nzChFzqfsIi9Y+gu73 CvaoWEM1U37aL7aDwL77pba2XefPfz5BQ90Oc8s9rUbiWRQ3ZHQ1TYqE18GPXpoZ3dIh 9yCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771845170; x=1772449970; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xnKDf+x7HLHllT2OTm2TYnpcf3b4bSzsLYz0UOALcks=; b=CvnhyVFHqsgFIGhR6oWZo8Khpn+UARpHNrhYLd7ne+ojLzjF4o6/mxFYjeieXVt3mk H6T5Lh2AV0ZmmEC5NcM7W0quuVPt6LS6F2wteJt86/V8DX4CkGPFOuev942iRUPljI4a 2jfJ9F/A1b+z/z/6g3Tm2alqRVuZZIPgiVZEFV3FmPhVLwzgq2BAk9IBhT8VrlGh5/Xs shqI1kYsAqYwm+kOHmj/yravzkUfjrxEd4dAGYJL8unGfkMOlYUDIqNewvbOuAuE37wo +3SA5N88rPFyDTx7orAyQQETeJme9AYGmcGJ9qbycIU9KwXL676tnc82emCXZ2R3hUUv Wvqw== X-Forwarded-Encrypted: i=1; AJvYcCViDkgU3I54ODkvualkt1d77aRFH0Wa7zDwVBQ1LbAmBi4I5mzyFQYBGHGFh7vigfaS9MuUEgcRthQczAU=@vger.kernel.org X-Gm-Message-State: AOJu0YwWUCSfZ9IxP4HKPG7HU1S5cPxB+dzwRZ0etlQKEwCZ7yOuuRsZ xgCSQ8g4YL8K0xCEKBne/ZcvVu8Eqi7hl2SU+S+09v8KohsPPQBCbM8u X-Gm-Gg: AZuq6aKF8VCgq0hEf2j254AqPkRmSskeahBWY/6z4kpcKY2Y+6JeqNnEiNsY7aHvLtl 2FPOkPqTfdLeMWP5v0P1Nl+tacqMA5XNraZqRXT04uoFkaXZ2AcA9GqoEBTcdfOEOBDG5AyEtyd LTin8qgeWkVlmTXTehRKJH/3/vswkwhJaUNK8tc5tNc5KOgcQEsSawoQia0GBR79tBM41C9t5Dh 6Jcsf4az4jbjS8nRpjb/xw8yTAPO7XBQHwAB9m0v+QiM1R5aEeWHIviQCXnqA2AVHGayrCIwaV+ gWdj91uK+nd6uvmzUneimG2cVamt3PeDgMv40dxE1Hgrwhz42aMGYIXkfb9drWnyGijd+I3lQCR MZx6Kuvk4eCRRnunL65Wa1Tqa1ZUqtpvjlkkaqIV9bbl6rLx9qtuIzggYdc02gJDkZrfiL/vU/K 9mNgaBg+8jsCWHMhy+LNlQuPTeNCWtsBk= X-Received: by 2002:a05:600c:4749:b0:47e:e970:b4e4 with SMTP id 5b1f17b1804b1-483a95e6ceemr116203185e9.29.1771845170097; Mon, 23 Feb 2026 03:12:50 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a8df83bcsm209099825e9.13.2026.02.23.03.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 03:12:49 -0800 (PST) Message-ID: <0ae976f070b0bf5a13ba5985b8e7d0f1efbb2cfd.camel@gmail.com> Subject: Re: [PATCH] iio: dac: mcp47feb02: Fix mutex used before initialization From: Nuno =?ISO-8859-1?Q?S=E1?= To: Felix Gu , Ariana Lazar , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Feb 2026 11:13:33 +0000 In-Reply-To: <20260223-mcp47feb02-v1-1-41f80bdbbb45@gmail.com> References: <20260223-mcp47feb02-v1-1-41f80bdbbb45@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-23 at 16:03 +0800, Felix Gu wrote: > The mcp47feb02_parse_fw() function uses data->lock, but the mutex was > initialized after this function in probe path. >=20 > Fix this by moving devm_mutex_init() before mcp47feb02_parse_fw(). >=20 > Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02") > Signed-off-by: Felix Gu > --- > =C2=A0drivers/iio/dac/mcp47feb02.c | 8 ++++---- > =C2=A01 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c > index b218f0c3a0bd..4ff5abcfecea 100644 > --- a/drivers/iio/dac/mcp47feb02.c > +++ b/drivers/iio/dac/mcp47feb02.c > @@ -1131,14 +1131,14 @@ static int mcp47feb02_probe(struct i2c_client *cl= ient) > =C2=A0 > =C2=A0 indio_dev->name =3D chip_features->name; > =C2=A0 > - ret =3D mcp47feb02_parse_fw(indio_dev, chip_features); > - if (ret) > - return dev_err_probe(dev, ret, "Error parsing firmware data\n"); > - > =C2=A0 ret =3D devm_mutex_init(dev, &data->lock); > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > + ret =3D mcp47feb02_parse_fw(indio_dev, chip_features); > + if (ret) > + return dev_err_probe(dev, ret, "Error parsing firmware data\n"); > + Actually I think the better fix is to not lock at all? Why do we need a loc= k around=20 mcp47feb02_parse_fw() if it's only called from probe()? - Nuno S=C3=A1 >=20