From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B5E392C32 for ; Mon, 9 Mar 2026 10:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773053010; cv=none; b=U/8r9hMEd8316/JkioaWEJkpA8L34yDsUKWDV4+2xHfeXxOwP/ATJpilNRYg0H6cZQUYfQlS4GIFOud3hDoKwxSN3I7EBIsO6VTMAOtHJyt1hhkymHC1CR1YOSKUlbXFCBu+wOsNVrpz3xlTLBJBg2J/2II3/2IyNJZbJameyHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773053010; c=relaxed/simple; bh=0mGwP1npF13+mveUUa9xyEzlo2GsKKm95aBIcO3Yp+c=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VitQeVGljmtaW1H6to3q3NY9sTI5HdGY3HIRA4iJqWDZBSfmzcNyoulzcHKwJoPjEtyjWlhEGBRoNHax1k6eEzzBC8JlOicZYMKLk4fx5pY/THdBMTxeB2AvvUQ3QtQazhnYYHrm1tpzayR97tL77tMaMLIm0+CARJvp8GriCOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DyA2FOdB; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DyA2FOdB" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-439c4bde55cso3892076f8f.1 for ; Mon, 09 Mar 2026 03:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773053007; x=1773657807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=uO33nrQTJBN0oESW+jd8KbSuNkISed6WOuwXvy0bMOE=; b=DyA2FOdB3h7NO9dTA+6YQqYFgoCeMfHuFRgTZoqnk6Oaf8p1jXNMb4ryaZMkQ2IDoa +z32dgtJ/mzmzSnzX2m0mXAAFFX5B2U8IcwkKqQjXui9PJnTKBuxYrl68fwU9O63ziDk lnXUUI0xJ5/CkmBx1YIqibLUC4UziO3hjOxX98Xh6F2xRrciNSuH8SCLUHBt+RIJ3Rd7 cSZLfwBIKZBE+xvPj7Ui3gg9yAD6SZdMd2eNiarG+E/ZXlPU84VDaQ59uLa7NXIlmT6c 3pLpkZntwiQh8WDZ9+/MbFwiYAgVa8JKUiGKRGzM6awdL7N3++icRtG0VK1t1tBqaaDe Y6Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773053007; x=1773657807; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uO33nrQTJBN0oESW+jd8KbSuNkISed6WOuwXvy0bMOE=; b=uYn/sb0d1EuNO2s1RyPkKQPCDDgoSVSF+MUvkyCxAMzGsbTqAvnHEftBlTMRXNakx0 QWeTZ50RYg6bxfEjaVFjryyxLn4EJdF0VsruGTPaWKI2RbEE8acI3g24oUccP5tTRfeu V87VDlPO6HXfDqcrVlMTbiqw+qdDQ8IXiIi9Z3nPG/OdLQ9LPFK9WJhejaGLPNK6xYbU H+BaewFBX0SGFiBsSgroqd9dnF1bD0t6/vamTbR9QmZzc9DIeAuLPZWmzdXxC+Ko/xL8 XBkfqBqzF50kVeiTc9YjqzPFROKVHIjyLnM+3PkorChPvG474x6tMGXdaTiByAC1sphG ZFcQ== X-Forwarded-Encrypted: i=1; AJvYcCVxAqpK1BDUU74TE96GOVlsx947cquOjCH30G2z5lCD110J29cQpp4eRaCIJYOCRIdZ3D89G2vqcS87KWw=@vger.kernel.org X-Gm-Message-State: AOJu0YxFnReoJ6K5GK3TsQaF70KmRTvOzWqJYFUHQtIPui/bHcafJOMA eyPA1iOl8mW+tOSbdcNjL5hNEmMWrmZzkcOACSzasd1sjmY4v5LSkGD3Yh+mfoQk0FA= X-Gm-Gg: ATEYQzwQAgVVXAByX/Sn8MySUEr0YheHk8+jpYpJbyIOPpEbzOrsCkkICddzPTVKY+l nDT6HPvkPTTgFj6Vn2lZ+ED0067Te2WEDozprzghT47RGrmk3IJgzE7f1t1pc0BxtnYdNw23PDe qX3C9S1nmZ47zSUNsQ1st5jOvpPI4Jv7HzJqSVxA5zFUln5vLWyUHQWdx9X+WmHreq1MYq13cch IFhZvOd4WFLIxTDOuGegGWaXzcb9p13A2YiKMALMma/mjba/2QzDFOEE3isR5Nf3T0XUulWrVOH z1mXbJVMWb6xk0QCm0dM8Fmv9HLh9xvH8PJ72ZkgSoMW0fZ9PWDmI5owHy1XdRlsOgfwiYVxJk+ 9B1M5O8+u8UItgIZW3RLztap5UcPJVRvh3uTQD7ezbj614YnJQFQWF0VbevXYlB06YKzXnJyoM+ u1R5f9iFGxVPMm994p4zBQbGLCvheCyYVKDWIJ7MZ15xlrpiA3zszK76hkujpMHH34pXrB3Xjbx wFKeMbVu/pXftM= X-Received: by 2002:a5d:5f82:0:b0:439:be2e:7339 with SMTP id ffacd0b85a97d-439da31dc6bmr18054588f8f.8.1773053007102; Mon, 09 Mar 2026 03:43:27 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:658:37a3:23e2:4cae? ([2a01:e0a:106d:1080:658:37a3:23e2:4cae]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8dbb3sm23001591f8f.4.2026.03.09.03.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 03:43:26 -0700 (PDT) Message-ID: <0af1c6d9-2408-4111-8738-5eea2c5d42f1@linaro.org> Date: Mon, 9 Mar 2026 11:43:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: Fix SVID=DP && unconnected edge case To: Konrad Dybcio , Konrad Dybcio , Bjorn Andersson , Jack Pham Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa References: <20260306-topic-pgaltmode_fixup-v1-1-ec154b2d8e89@oss.qualcomm.com> <7fcbf142-f2c6-4b9e-bb63-befa553aceff@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/9/26 11:38, Konrad Dybcio wrote: > On 3/6/26 3:47 PM, Neil Armstrong wrote: >> On 3/6/26 12:20, Konrad Dybcio wrote:[...] > >> So what's the difference with : >> >> >> if (blah) >>     ... >> else (alt_port->svid == USB_TYPEC_DP_SID) { >>     if (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN) >>         pmic_glink_altmode_safe() >>     else >>         pmic_glink_altmode_enable_dp >> } >> else (blah) >>     ... >> else (blah) >>     ... >> else (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN) >>     pmic_glink_altmode_safe() >> >> >> Before, if mux_ctrl was MUX_CTRL_STATE_NO_CONN, it would set to safe mode whatever the svid, >> now it's either in the DP case or at the end. >> >> I don't see the difference here, except if your desire is to ignore >> the MUX_CTRL_STATE_NO_CONN for USB_TYPEC_TBT_SID and MUX_CTRL_STATE_TUNNELING. >> >> But it doesn't match the commit message at all. > > > The difference is the call to drm_aux_hpd_bridge_notify() in the DP > case, which isn't very visible in the patch diff. Oh I see it now thx, but with this change MUX_CTRL_STATE_NO_CONN will be ignored for USB_TYPEC_TBT_SID and MUX_CTRL_STATE_TUNNELING. Neil > > Konrad