From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969182E8E14 for ; Mon, 10 Nov 2025 08:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762762963; cv=none; b=YWfxGSVH2Wk4y2VBEazpJWTsrQ6KNnJexHpX7/vjzeNf6S9Fve4gznCSzaLi4dOG8d3zGus5LyecDwQCwXUgNcIVBN/ezF10Tx40WKX8jf4yeX0UwPeOjaU3QA3HrpV5pOdBDtByT0drWca026CYoqQKXHlOeHG5dbfjfUrvJXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762762963; c=relaxed/simple; bh=OxTYCu6RPB9p/Wk4BXZhXkRvVuWvgUVw9tNaOk3NdA0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pmdLJKMIgFfPBNzsy4EhOa/1VzZKvPWRqF8vkYudEvIG7OUufApXkKM9U8CPI+lZOxM8bSfLEfivROfItzVjWX0UlGGEJRzy4FtKMfFbkDdMdHG35Ee5IEIcMIvx9fWPxy6ytcWlYDjKW0DhgjkmFamAUp8nB4E4T8ZeWQvQ9Bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vINAV-0005gU-8i; Mon, 10 Nov 2025 09:22:31 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vINAU-007zQ8-2n; Mon, 10 Nov 2025 09:22:30 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vINAU-0000000042S-3C6F; Mon, 10 Nov 2025 09:22:30 +0100 Message-ID: <0af422ff5881ec875ad7eea272e229ce3426956a.camel@pengutronix.de> Subject: Re: [PATCH 3/6] media: staging: media: imx6-mipi-csi2: use devm_clk_bulk_get_all() to fetch clocks From: Philipp Zabel To: Frank Li , Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: imx@lists.linux.dev, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 10 Nov 2025 09:22:30 +0100 In-Reply-To: <20251107-stage-csi2-cleanup-v1-3-5d42535243ac@nxp.com> References: <20251107-stage-csi2-cleanup-v1-0-5d42535243ac@nxp.com> <20251107-stage-csi2-cleanup-v1-3-5d42535243ac@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fr, 2025-11-07 at 15:44 -0500, Frank Li wrote: > Use devm_clk_bulk_get_all_enabled() helper to simplify clock handling. >=20 > Defer all clock prepare and enable to csi2_start(), which previous only > enable pix clock here. >=20 > Do that safely because there are not register access before csi2_start(). What about log_status()? regards Philipp