Re: [PATCH 3/3] arm64: dts: qcom: monaco-evk: Add suspend-only power collapse state

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/5/26 5:29 PM, Maulik Shah wrote:
> To achieve SoC low power mode like chip rail power collapse (CxPC),
> the Monaco EVK board with four PMICs requires coordinated power-down of
> CPUSS and the Safety Island (SAIL) subsystem. This deepest system power
> collapse state is reserved for system-wide suspend (s2idle).
> 
> Add the system_suspend domain idle state, mark it with system-state,
> and reference it from the system power domain.
> 
> Assisted-by: Codex:GPT-6
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 539c9c80a808..b2978be6823d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts

Why is this board-specific?

> @@ -80,6 +80,19 @@ m2_e_uart_ep: endpoint@0 {
>  		};
>  	};
>  
> +	cpus {
> +		domain-idle-states {
> +			system_suspend: domain-suspend {
> +				compatible = "domain-idle-state";
> +				arm,psci-suspend-param = <0x4200C344>;

Please keep the hex numbers lowercase

Konrad

> +				entry-latency-us = <706562>;
> +				exit-latency-us = <706562>;
> +				min-residency-us = <709987>;
> +				system-state;
> +			};
> +		};
> +	};
> +
>  	dmic: audio-codec-0 {
>  		compatible = "dmic-codec";
>  		#sound-dai-cells = <0>;
> @@ -772,6 +785,10 @@ tpm@0 {
>  	};
>  };
>  
> +&system_pd {
> +	domain-idle-states = <&system_sleep>, <&system_suspend>;
> +};
> +
>  &tlmm {
>  	pcie0_default_state: pcie0-default-state {
>  		wake-pins {
>