From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C05D11CAF;
	Thu, 15 Jan 2026 02:47:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1768445266; cv=none; b=iSuyrsZ3hkFRfSyZdgaMbR1IWfSlMzZPcn6h6JEGX/K6/rk7Txjhm98ZUWJXIWGGGxlqIps5zqp8gBWbO4e9wA5g3S2a+tHeHbTINpikGxqUpb2FMtb30JFMUQtqdmZX1IoPXreo4PJh5Y04BlMhdwLg+oOSdGf0FGBtsY5sO6g=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1768445266; c=relaxed/simple;
	bh=HpWGQ7KxmgI6u330vIsF6o1hSqFz0/VdjdpLHAUSvO4=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=S79yc26j3EvTY+ZgchwuMzBYjfVUC2cG8iwKWyvgXUv7Y+voIEbvFFBXDvWbt3J56tKi2KzBVehals7PL7NWMuMA+LIfN144XuYOR3KP+aJf5H2qLmmyPwd3zVWUTJolWuq63a9MhRoJE17rckFSIzDnfO3XKtoWcKrqFVEa1iI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=Mt5MVZ8r; arc=none smtp.client-ip=80.241.56.171
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="Mt5MVZ8r"
Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4ds6ph1n1qz9tR9;
	Thu, 15 Jan 2026 03:47:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812;
	t=1768445260;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=80JGlExrtvjtNMYhQZr3+IVGfbgWQXnBe/kFnPwN3mY=;
	b=Mt5MVZ8rffif9xZf8CPJK1n5PgSiCMnxyofEvQIJtavtvNL/vFeotEO7xX55HmFD+B52VQ
	S7YOAX26FFWcHKNeKny2O+uqn7sJBNbUVIjyNADlA9rWMGOVkhHMEy1GdMBDC5k5fu/SBr
	CaSgjE11wKl3I3ZmppxvXfybDhwd9img7m2TED4KaLP8cLLCpzJ3X/QIB4WnFcVk9jN7tw
	M2UT+pvk1RiOIxtfW/SBdj2xJ/oXQ2knoISjvmrvcvmMrjXne1NNmxdhKiBo4RgHNBKDi7
	a2fcGW5Geva/k+NFyZ8G33MeM7KtsXESs9Gakm4oTcYN2LW/aTgSl2qD+lMErQ==
Message-ID: <0b029410-d960-42a8-9d2a-e731234598fe@mailbox.org>
Date: Thu, 15 Jan 2026 03:47:35 +0100
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] drm/bridge: waveshare-dsi: Add support for 1..4 DSI
 data lanes
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda <andrzej.hajda@intel.com>,
 Conor Dooley <conor+dt@kernel.org>, David Airlie <airlied@gmail.com>,
 Jernej Skrabec <jernej.skrabec@gmail.com>, Jonas Karlman <jonas@kwiboo.se>,
 Joseph Guo <qijian.guo@nxp.com>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>, Rob Herring <robh@kernel.org>,
 Robert Foss <rfoss@kernel.org>, Simona Vetter <simona@ffwll.ch>,
 Thomas Zimmermann <tzimmermann@suse.de>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
References: <20260112234834.226128-1-marek.vasut+renesas@mailbox.org>
 <20260112234834.226128-2-marek.vasut+renesas@mailbox.org>
 <CAMuHMdUJBKnqU_HtF1KpZY-75iTWjZwedLbFSYLpgDfVHGsW1g@mail.gmail.com>
Content-Language: en-US
From: Marek Vasut <marek.vasut@mailbox.org>
In-Reply-To: <CAMuHMdUJBKnqU_HtF1KpZY-75iTWjZwedLbFSYLpgDfVHGsW1g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-MBO-RS-META: sgar6do66mkip7ahr4a67x6pamtme99x
X-MBO-RS-ID: af6e9444839cb156e47

On 1/14/26 10:32 AM, Geert Uytterhoeven wrote:

Hello Geert,

>> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> @@ -66,7 +66,11 @@ static int ws_bridge_attach_dsi(struct ws_bridge *ws)
>>          dsi->mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
>>                            MIPI_DSI_CLOCK_NON_CONTINUOUS;
>>          dsi->format = MIPI_DSI_FMT_RGB888;
>> -       dsi->lanes = 2;
>> +       dsi->lanes = drm_of_get_data_lanes_count_ep(dev->of_node, 0, 0, 1, 4);
>> +       if (dsi->lanes < 0) {
>> +               dev_warn(dev, "Invalid DSI lane count %d, falling back to 2 lanes\n", dsi->lanes);
> 
> "Invalid or missing"?

Fixed in V2

> BTW, I doubt the kerneldoc for drm_of_get_data_lanes_count_ep()
> is correct:
Nice find, fixed in

[PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value 
documentation

Thanks !