From: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax
Date: Mon, 23 Mar 2020 14:30:16 +0100 [thread overview]
Message-ID: <0b19b68b-0bbd-f51c-67da-bd6983ae45b2@shipmail.org> (raw)
In-Reply-To: <4a49f27b-71a6-0e61-70d9-5fcb6cd58c3f@shipmail.org>
Ping?
On 3/3/20 11:28 AM, Thomas Hellström (VMware) wrote:
> Alexander,
>
> Could you ack merging the below patch through a DRM tree?
>
> Thanks,
>
> Thomas Hellstrom
>
>
> From: Thomas Hellstrom <thellstrom@vmware.com>
>
>
> The function is used by upcoming vma_is_special_huge() with which we want
> to use a const vma argument. Since for vma_is_dax() the vma argument is
> only dereferenced for reading, constify it.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Ralph Campbell <rcampbell@nvidia.com>
> Cc: "Jérôme Glisse" <jglisse@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> Reviewed-by: Roland Scheidegger <sroland@vmware.com>
> Acked-by: Christian König <christian.koenig@amd.com>
> ---
> include/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3cd4fe6b845e..2b38ce5b73ad 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp)
> return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
> }
> -static inline bool vma_is_dax(struct vm_area_struct *vma)
> +static inline bool vma_is_dax(const struct vm_area_struct *vma)
> {
> return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host);
> }
>
prev parent reply other threads:[~2020-03-23 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:22 [PATCH v5 0/9] Huge page-table entries for TTM Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 2/9] mm: Introduce vma_is_special_huge Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 3/9] mm: Split huge pages on write-notify or COW Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 4/9] mm: Add vmf_insert_pfn_xxx_prot() for huge page-table entries Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 6/9] drm/vmwgfx: Support huge page faults Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 7/9] drm: Add a drm_get_unmapped_area() helper Thomas Hellström (VMware)
2020-03-03 21:06 ` kbuild test robot
2020-03-03 10:22 ` [PATCH v5 8/9] drm/vmwgfx: Introduce a huge page aligning TTM range manager Thomas Hellström (VMware)
2020-03-03 10:22 ` [PATCH v5 9/9] drm/vmwgfx: Hook up the helpers to align buffer objects Thomas Hellström (VMware)
2020-03-03 10:28 ` Ack to merge through DRM? WAS [PATCH v5 1/9] fs: Constify vma argument to vma_is_dax Thomas Hellström (VMware)
2020-03-23 13:30 ` Thomas Hellström (VMware) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b19b68b-0bbd-f51c-67da-bd6983ae45b2@shipmail.org \
--to=thomas_os@shipmail.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®