From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80619287254 for ; Sun, 29 Mar 2026 19:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811584; cv=none; b=M3EQ1+aSuyiE472eT08PweopBHlwwt0RJ8Z4vGlczrP1wMCtukRSdubh2EMiak35BuI0XOLxZ2Zi8TtlR1/XvvCNrQl6uxHDP07Q2qyAa408rDM4bbi8WKYOJKwwNdyCnS+8wAo6fGuqE9E/u7UEqfGcW0gCI3qySEV7vQ6sJqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811584; c=relaxed/simple; bh=+gtjc7K7Q9IY44WHCSLCf4ByH3kzNJUq4oBtORDPPJk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pv7N6TjbI+ol/aXhb6Nv2kifdrxGumGlo3ojxdj9Zz78B8QAzHr/9mm1ljMXAnI4j8IqJrYEsUIsYDpiwGAg+5JN2K1u3TzoHhp3EIVPZnXDFCBc+Uay+LyY/tfyPHipTzIWgpzk3pFAVqleuE+j3HPd1L6yQqCU0N661KMjRDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PcJ+UmkC; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PcJ+UmkC" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8298fad2063so2107898b3a.3 for ; Sun, 29 Mar 2026 12:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774811583; x=1775416383; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=QGckwBo/T6rYcFnagiWvk5nb04xfskv1xFoj3AxjaK4=; b=PcJ+UmkCXFc5rWp8VALG5jgNGyJe4OZh8DFGE8UnSIK4spQDxCvlUf8SbTjNUA6f8x N4sFTJdANrmvmaRe3dMzRmiCKkNOhDwProZJVfqmhUX6+HPdq/w0WPlS9JXpKxzPxKTm ghmMHyMiyyeQtTaI6VBD3JBlaN8DaYgZglHPGStHnLJ/kaxqE+p6mjRJeYP8LuFkDR+p RGVvKyx8kHu53HC5hKxNdalv2MPf+rEc+6xH9qy5C2MeDg3yqGfHk6cLelGofbqLiHAF uKpGA2RmeBCwHoMFFw6tSmpqiPzF21JALMCvKZjA1LYqNgZaVViofbQQMYCzSQnbVqxV b/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774811583; x=1775416383; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QGckwBo/T6rYcFnagiWvk5nb04xfskv1xFoj3AxjaK4=; b=M1XqEsR47wts3bcgY1Mx8kV2T9SHzaXT88hPjZq9KhzG4BIvkdmhV9kyC9SQhIclv+ CABIyxalgtpm74t6CmMXij7wC+dma/8aAMCPCch7/Cvk/Kx+4pk3IKHIC1cEVyh/V4bO 7VFbFsh5QkbBTYAaiVuqQhtuVFOMOqAuidziZwEIg1CeJrVDsB4oKJ/732hmMU1tL6/P TQqy2hH2fVqtOOOreGMoP2bbJCONLGxQoAu15CVrff8VlaW39rdn2LVbcYNAR+ChrAuL Ir4TocsXiUCAZAAKiBb/XJ4nNeJKihjXbw0whsMgf+mlb6FGy1v5LO1Bp4w31veR8H5n xVNg== X-Forwarded-Encrypted: i=1; AJvYcCXp2uYbN2RrYD+A9E8Pp8F9AYQoh+oAUsRe691bnyCwCGM+naOdstYXlxL0k/+ojs5dbKLNAwqEgYPe1B4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywzt3s01+Z/suH4z6QPDOg+o/2oS04s951SKM8/PjqfzYc4BMIo naLIDUL6DHiMmD6druNzwkpL/7Yyuvv06FTjNT5JfE4N8a5tv/l2xQxy X-Gm-Gg: ATEYQzyTFycIZ37aXGXS0GvKoW7dYLFoDfMHaiL6lTElJlzVQtBu/NL2zPau9bIMWUq BDMryWDXdAerhmEZlUP3OQMTyncPvNEnE5ew1xWYSJEu4CdinHLA7jdQPSRdu8Y0fKTE/NVb9SK F2rY1GBSRsZn46cSaasObWTO0mQig7QsGnoTlT4bvF91W1n4FE+C3m7Q1zHbHNqYy+uUU1ypPok SCG37aCWbQCWwfnFOjDo8r8geej1IGPqzQFI3yuAJ9/DHJMN9vOSO3RApCT4oQR5kEw/PVBR+L6 MkOFKq3olSvnHbRPctNhO2JUlL9aYh6hE5uFkbHeNwCBAvprX7rhAL8S10FT3g+WOSaWLJ6CZwo MYlri7VE9AZbcOSrUitUEoBKX+NwApHl8UwaEIvS4VVN210/Ec6vbRQaRaI93fZSTx3zfsKj+7w EeufSa8mke4XoQSKQYXabeY9FMoTb5p1ZoPplw X-Received: by 2002:a05:6a20:3d85:b0:398:a3e5:d04b with SMTP id adf61e73a8af0-39c87a3c1d9mr10836144637.33.1774811582804; Sun, 29 Mar 2026 12:13:02 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c769179e3d3sm4268644a12.15.2026.03.29.12.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 12:13:02 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 29 Mar 2026 12:13:01 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: Re: [PATCH 3/4] hwmon: (pxe1610) Check return value of page-select write in probe Message-ID: <0b1d3ee0-ea20-4224-959c-8423deae7610@roeck-us.net> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> <20260329170925.34581-4-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329170925.34581-4-sanman.pradhan@hpe.com> On Sun, Mar 29, 2026 at 05:09:48PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > pxe1610_probe() writes PMBUS_PAGE to select page 0 but does not check > the return value. If the write fails, subsequent register reads operate > on an indeterminate page, leading to silent misconfiguration. > > Check the return value and propagate the error using dev_err_probe(), > which also handles -EPROBE_DEFER correctly without log spam. > > Fixes: 28ccdfd11344 ("hwmon: (pmbus) Add Infineon PXE1610 VR driver") > Signed-off-by: Sanman Pradhan Applied, after fixing the "Fixes" SHA. Thanks, Guenter