From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>, rust-for-linux@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>, "Miguel Ojeda" <ojeda@kernel.org>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>
Subject: Re: [PATCH] rust: replace <linux/module.h> with <linux/export.h> in rust/exports.c
Date: Fri, 24 Nov 2023 11:54:01 -0300 [thread overview]
Message-ID: <0b224ebc-fcb0-4825-9222-5f0efc61c62a@gmail.com> (raw)
In-Reply-To: <20231124142617.713096-1-masahiroy@kernel.org>
On 11/24/23 11:26, Masahiro Yamada wrote:
> <linux/export.h> is the right header to include for using
> EXPORT_SYMBOL_GPL. <linux/module.h> includes much more bloat.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> [...]
>
> -#include <linux/module.h>
> +#include <linux/export.h>
>
> [...]
I'll use this in my crates patch. Regardless, LGTM.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-11-24 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 14:26 Masahiro Yamada
2023-11-24 14:36 ` Miguel Ojeda
2023-11-24 14:54 ` Martin Rodriguez Reboredo [this message]
2023-12-13 18:43 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b224ebc-fcb0-4825-9222-5f0efc61c62a@gmail.com \
--to=yakoyoku@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®