From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932989AbdKFSRz (ORCPT ); Mon, 6 Nov 2017 13:17:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59092 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729AbdKFSPp (ORCPT ); Mon, 6 Nov 2017 13:15:45 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 633F260542 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision To: Robin Murphy , dmaengine@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1509989180-22617-1-git-send-email-okaya@codeaurora.org> <1509989180-22617-2-git-send-email-okaya@codeaurora.org> <428c7106-8ebe-0c12-4576-1cfac422923e@arm.com> From: Sinan Kaya Message-ID: <0b24eb03-1f0e-ec65-b12b-65036ef7addc@codeaurora.org> Date: Mon, 6 Nov 2017 13:15:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <428c7106-8ebe-0c12-4576-1cfac422923e@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/2017 1:03 PM, Robin Murphy wrote: >> #ifdef CONFIG_ACPI >> ret = strcmp(acpi_device_hid(adev), "QCOM8062"); >> + if (ret) >> + ret = strcmp(acpi_device_hid(adev), "QCOM8063"); > This string-juggling looks to have already hit the point at which it > doesn't scale well - it would be a lot nicer to make use of > of_device_get_match_data() and the ACPI equivalent to abstract the > version-specific data appropriately. Sure, let me do some research. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.