From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D7F4B488E for ; Thu, 24 Sep 2026 18:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275264; cv=none; b=l63qWsJRcIaReQeUVFYUSLvOGPJPYX/GEBrLRcPxlc0hInl4aEOsN2Na1NHuuFP2bOmlZJAq6umm0DT+O8u8yXFgdyKH5SEGj4O2dcmohMXXCK3dFsD1hz3TeSveinl2isaaOSSCtsA0COzzw4cSf/bn7OpRxLE5JwitfW3QRis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275264; c=relaxed/simple; bh=zQiRRlA/lV8I6Z+/+nU9C5f3vEPSMUOzczA0I6BHBwo=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cmtTJwtYlHMCgk1kE0KM8uyn3BL5PnbvsWH0egGSjyAtTS/MsirnzWiMi1rKKxVa/zc3fVmNna5PRpQdkytQMttnMAUx7drDrsB3NH8BnTAXJO5pHb4Wx+MRAyVQf2jp6Vjw965r4J+g8ciDlOb7I4y4f298ejHanF+aOnjg/iM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100) (envelope-from ) id 1x9oNN-000000007Ly-0Z5c; Thu, 24 Sep 2026 18:40:57 +0000 Date: Thu, 24 Sep 2026 19:40:54 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v7 07/14] drm/bridge: it6505: avoid division by zero in pixel clock calculation Message-ID: <0b274e5636cdbf48a5d287fb2132a162f05f5dfb.1790275151.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: it6505_calc_video_info() checks the sum of the three pixel clock counter samples for zero before dividing it by 3, so sums of 1 or 2 truncate to 0 and the following pixel clock calculation divides by zero. Divide first and check the result. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Daniel Golle --- v7: no changes v6: no changes v5: new patch --- drivers/gpu/drm/bridge/ite-it6505.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 42106bc2056e..180a270ecfc1 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -751,12 +751,13 @@ static void it6505_calc_video_info(struct it6505 *it6505) sum += rddata; } + sum /= 3; + if (sum == 0) { DRM_DEV_DEBUG_DRIVER(dev, "calc video timing error"); return; } - sum /= 3; pclk = 13500 * 2048 / sum; it6505->video_info.clock = pclk; it6505->video_info.hdisplay = hdew; -- 2.55.0