From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC14C46475 for ; Tue, 23 Oct 2018 07:02:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5715A20665 for ; Tue, 23 Oct 2018 07:02:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5715A20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727668AbeJWPYY (ORCPT ); Tue, 23 Oct 2018 11:24:24 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:34956 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbeJWPYY (ORCPT ); Tue, 23 Oct 2018 11:24:24 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gEqhi-00062C-5E; Tue, 23 Oct 2018 09:02:14 +0200 Message-ID: <0b3197a734f71bdfffaf717e63b17e2fe31720a2.camel@sipsolutions.net> Subject: Re: [PATCH v2] wireless: mark expected switch fall-throughs From: Johannes Berg To: "Gustavo A. R. Silva" , "David S. Miller" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook Date: Tue, 23 Oct 2018 09:01:57 +0200 In-Reply-To: <20181023001308.GA4150@embeddedor.com> References: <20181023001308.GA4150@embeddedor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-10-23 at 02:13 +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This code was not tested and GCC 7.2.0 was used to compile it. Look, I'm not going to make this any clearer: I'm not applying patches like that where you've invested no effort whatsoever on verifying that they're correct. johannes