From: "J, KEERTHY" <j-keerthy@ti.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: <tony@atomide.com>, <lee.jones@linaro.org>, <t-kristo@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: tps65218: Use devm_regmap_add_irq_chip and clean up error path in probe
Date: Fri, 7 Dec 2018 05:52:42 +0530 [thread overview]
Message-ID: <0b3949c5-1af0-6830-15db-01271a006615@ti.com> (raw)
In-Reply-To: <20181206205155.eucqfsq2xnk7kks5@earth.universe>
On 12/7/2018 2:21 AM, Sebastian Reichel wrote:
> Hi,
>
> On Thu, Dec 06, 2018 at 11:07:44PM +0530, Keerthy wrote:
>> Use devm_regmap_add_irq_chip and clean up error path in probe.
>>
>> Reported-by: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> Boot tested on am437x-gp-evm.
>
> This is missing cleanup of remove path?
Yes! Thanks for catching it. I will send v2 in a bit.
>
> -- Sebastian
>
>> drivers/mfd/tps65218.c | 14 +++-----------
>> 1 file changed, 3 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
>> index 910f569..2383621 100644
>> --- a/drivers/mfd/tps65218.c
>> +++ b/drivers/mfd/tps65218.c
>> @@ -235,9 +235,9 @@ static int tps65218_probe(struct i2c_client *client,
>>
>> mutex_init(&tps->tps_lock);
>>
>> - ret = regmap_add_irq_chip(tps->regmap, tps->irq,
>> - IRQF_ONESHOT, 0, &tps65218_irq_chip,
>> - &tps->irq_data);
>> + ret = devm_regmap_add_irq_chip(&client->dev, tps->regmap, tps->irq,
>> + IRQF_ONESHOT, 0, &tps65218_irq_chip,
>> + &tps->irq_data);
>> if (ret < 0)
>> return ret;
>>
>> @@ -253,14 +253,6 @@ static int tps65218_probe(struct i2c_client *client,
>> ARRAY_SIZE(tps65218_cells), NULL, 0,
>> regmap_irq_get_domain(tps->irq_data));
>>
>> - if (ret < 0)
>> - goto err_irq;
>> -
>> - return 0;
>> -
>> -err_irq:
>> - regmap_del_irq_chip(tps->irq, tps->irq_data);
>> -
>> return ret;
>> }
>>
>> --
>> 1.9.1
>>
prev parent reply other threads:[~2018-12-07 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 17:37 Keerthy
2018-12-06 20:51 ` Sebastian Reichel
2018-12-07 0:22 ` J, KEERTHY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b3949c5-1af0-6830-15db-01271a006615@ti.com \
--to=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®