mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Martitz <kugel@rockbox.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Daniel Drake <drake@endlessm.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Linux Upstreaming Team <linux@endlessm.com>,
	nouveau@lists.freedesktop.org,
	Linux PM <linux-pm@vger.kernel.org>,
	Peter Wu <peter@lekensteyn.nl>,
	kherbst@redhat.com, andy.shevchenko@linux.intel.com, "Wysocki,
	Rafael J" <rafael.j.wysocki@intel.com>,
	Keith Busch <keith.busch@intel.com>,
	Jon Derrick <jonathan.derrick@intel.com>,
	David Miller <davem@davemloft.net>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	nic_swsd@realtek.com, rchang@marvell.com,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume
Date: Tue, 2 Oct 2018 23:26:35 +0200	[thread overview]
Message-ID: <0b3bc158-b836-7b44-ef09-7c124f479c58@rockbox.org> (raw)
In-Reply-To: <20181002200350.GC120535@bhelgaas-glaptop.roam.corp.google.com>

Am 02.10.18 um 22:03 schrieb Bjorn Helgaas:
> Hi Thomas,
> 
> On Mon, Oct 01, 2018 at 04:25:06PM +0200, Thomas Martitz wrote:
>> Am 01.10.18 um 06:57 schrieb Daniel Drake:
>>> On Sun, Sep 30, 2018 at 5:07 AM Thomas Martitz <kugel@rockbox.org> wrote:
>>>> The latest iteration does not work on my HP system. The GPU fails to
>>>> power up just like the unpatched kernel.
>>>
>>> That's weird, I would not expect a behaviour change in the latest
>>> patch. pci_restore_config_dword() has some debug messages, could you
>>> please make them visible and show logs again?
>>> Also remind us of the PCI device address of the parent bridge (lspci -vt)
>>
>> I'll follow up with more the requested information on bugzilla
>> (Link: https://bugzilla.kernel.org/show_bug.cgi?id=201069).
>>
>> On a quick re-check, it seems to depend on if I used the eGPU before
>> the initial suspend. If I run glxgears (with DRI_PRIME=1) before suspend it
>> seems fine.
> 
> Does the patch ([1]) make things *worse* compared to v4.19-rc5?
> 

No, certainly not. It does look like a different issue since resuming now
works at least if I used the eGPU in some way before suspend 
(DRI_PRIME=1 glxgears seems to be enough, I assume glxinfo would work as 
well).

Without the patch resuming the eGPU does not work whatsoever.

Please ship the patch. I'll hopefully sort this other issue out.

Best regards.


  reply	other threads:[~2018-10-02 21:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180913033745.11178-1-drake@endlessm.com>
     [not found] ` <20180918213244.GE13616@bhelgaas-glaptop.roam.corp.google.com>
2018-09-27 20:52   ` Bjorn Helgaas
2018-09-29 21:06     ` Thomas Martitz
2018-10-01  4:57       ` Daniel Drake
2018-10-01 14:25         ` Thomas Martitz
2018-10-02 20:03           ` Bjorn Helgaas
2018-10-02 21:26             ` Thomas Martitz [this message]
2018-10-02 21:29               ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b3bc158-b836-7b44-ef09-7c124f479c58@rockbox.org \
    --to=kugel@rockbox.org \
    --cc=andy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=drake@endlessm.com \
    --cc=helgaas@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jonathan.derrick@intel.com \
    --cc=keith.busch@intel.com \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=peter@lekensteyn.nl \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rchang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®