From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbeAXWsX (ORCPT ); Wed, 24 Jan 2018 17:48:23 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:42360 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932845AbeAXWsW (ORCPT ); Wed, 24 Jan 2018 17:48:22 -0500 X-Google-Smtp-Source: AH8x225KfwhHV0kRH+km75mc37IWebQyG+UpdrjFvExy89yHjp5hzy6Zc5v7DHU823vIuQVgRDZiYw== Subject: Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node To: "Auer, Lukas" , "linux-kernel@vger.kernel.org" , "aymen.sghaier@nxp.com" , "horia.geanta@nxp.com" , "linux-crypto@vger.kernel.org" Cc: "peng.fan@nxp.com" , "davem@davemloft.net" , "ryan.harkin@linaro.org" , "fabio.estevam@nxp.com" , "rui.silva@linaro.org" , "herbert@gondor.apana.org.au" References: <1516805435-15034-1-git-send-email-pure.logic@nexus-software.ie> <1516805435-15034-4-git-send-email-pure.logic@nexus-software.ie> <1516817565.29323.74.camel@aisec.fraunhofer.de> From: "Bryan O'Donoghue" Message-ID: <0b3c415f-64e4-1fcf-45ef-c447d65e8e89@nexus-software.ie> Date: Wed, 24 Jan 2018 22:48:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1516817565.29323.74.camel@aisec.fraunhofer.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/18 18:12, Auer, Lukas wrote: > On Wed, 2018-01-24 at 14:50 +0000, Bryan O'Donoghue wrote: >> From: Rui Miguel Silva >> >> Add CAAM device node to the i.MX7s device tree. >> >> Signed-off-by: Rui Miguel Silva >> Cc: "Horia Geantă" >> Cc: Aymen Sghaier >> Cc: Fabio Estevam >> Cc: Peng Fan >> Cc: Herbert Xu >> Cc: "David S. Miller" >> Cc: Lukas Auer >> Signed-off-by: Bryan O'Donoghue >> --- >> arch/arm/boot/dts/imx7s.dtsi | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx7s.dtsi >> b/arch/arm/boot/dts/imx7s.dtsi >> index 82ad26e..0da146e 100644 >> --- a/arch/arm/boot/dts/imx7s.dtsi >> +++ b/arch/arm/boot/dts/imx7s.dtsi >> @@ -805,6 +805,32 @@ >> status = "disabled"; >> }; >> >> + crypto: caam@30900000 { >> + compatible = "fsl,sec-v4.0"; >> + fsl,sec-era = <4>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + reg = <0x30900000 0x10000>; >> + ranges = <0 0x30900000 0x10000>; >> + clocks = <&clks IMX7D_CAAM_MEM_CLK>, >> + <&clks >> IMX7D_CAAM_ACLK_CLK>, >> + <&clks IMX7D_CAAM_IPG_CLK>, >> + <&clks IMX7D_EIM_ROOT_CLK>; >> + clock-names = "mem", "aclk", "ipg", >> "emi_slow"; >> + >> + sec_jr0: jr0@1000 { >> + compatible = "fsl,sec-v4.0- >> job-ring"; >> + reg = <0x1000 0x1000>; >> + interrupts = > IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + >> + sec_jr1: jr1@2000 { >> + compatible = "fsl,sec-v4.0- >> job-ring"; >> + reg = <0x2000 0x1000>; >> + interrupts = > IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + }; >> + >> flexcan1: can@30a00000 { >> compatible = "fsl,imx7d-flexcan", >> "fsl,imx6q-flexcan"; >> reg = <0x30a00000 0x10000>; > > Looking at the device tree from the NXP kernel [1], the job ring and > clock configurations should be slightly different. > > The job ring configuration has one additional job ring at offset 3000 > and interrupt 114. Yes true, that should be added. We will do that in v2, thanks for spotting. > The clock configuration has changed to just one CAAM-specific clock in > addition to the ahb clock. This also means that additional > modifications to the CAAM driver are necessary or it will complain that > it doesn't find all clocks. Sure - but, those clock changes aren't merged to upstream just yet, so we won't those changes to this DTS addition yet. Thanks for the review. --- bod