From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D5B3D3331 for ; Mon, 30 Mar 2026 13:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774875998; cv=none; b=nZjW4T+HLCzQt4cDfY8VLLLbJCay13bon7U56YCqfxEUGnu7X6fApdaRpR7WP7XEkmZ0E0a3cuvk5h5eqA4eHuzV84/Qu+BH1l1dH7lL+fYbevJr3WelATLp96h4N5zGsoldS8wvGh6/Q9fROZ1RfwTWPUHNJlcqoRdo88AW20o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774875998; c=relaxed/simple; bh=hnJBIkRTxb/pEx74u11pPM/34htrB6sS8kh15oW/cOk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OvPxXKj8zEydamFZOtVHoOQqWfsGFFCTeLO9zxCDMvble7+dWI2+bsGGNanewkV8DaFYr1k2JlAiaCYKIWDSmkWjWsNRFEJtHqdUZlj6/EDRJEZMYEMuSWzZvRYffcYDvjUDqO7eZe3U7DpMTzky7ZQEnC2QhZ69WgEj8TUlom8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZTQeaf/b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iEBJZwuJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZTQeaf/b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iEBJZwuJ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UApx8T2723830 for ; Mon, 30 Mar 2026 13:06:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /IOBEa7GFyVDrfJ8sYt5+s+/t7ENB46SJEYFrDxrvCM=; b=ZTQeaf/bytoCSzFg EDH8gepEfMTHNA3ea5/l/Z00vj10jB0GWj/hak8WZ2+LJeykTE127InAgZiMx8GO XzS+nfcvuaPOcQSDV/SozA0cdn7P0iTCyazjW3u+in77R91Vp1YhT0ur9yrYylGA xTtTJH2szq98RqFxdWwzcUbh5AdSzfj6Oh2WLltinAPul7VqEGoEu9DTevdoSnzU G7Nu0ewwB0ISQNtX33XcF9XfT8fOiKcE3hVaBq5iYhS0xATgA6sbe5cZvXmLyTAL k10JtG8qp5qG3CD+Cbo58BxEgqrev9YdFl1OYWZEo+XALFovMpnZlEif36TQeUYG zyjM3A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7qt0ggwd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 13:06:36 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b242cbb97aso19531445ad.1 for ; Mon, 30 Mar 2026 06:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774875996; x=1775480796; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/IOBEa7GFyVDrfJ8sYt5+s+/t7ENB46SJEYFrDxrvCM=; b=iEBJZwuJoLqzYX1ayOSt/bomnl1mo84JQYdcC+JOu6KmwGqzJYAOeNy16k5CH0zpUz N45VBk+8UzEbizpC+KanG8U276OK1C7myh/6gTl2CR2ckJEH2AfoMjQLtUWRcb4L2fbr gyoDpqebAVHjfYrbPM4lphPI+CPDJbDuSe2iwG9ktJ3vb//He+oyixcDkSioOuTwXIf4 k6sSTgxlu5/4dH/n/aSHbGAtIWIhRK9xf7XGgRabjr3VsBGXLM+yuSVYukhaOF2H4+A9 2HLG1Zvr4Vek7t20Bkj9fe8Mjj+2vdg7edNY0Qbt5vC3TRcN6if3vrE0tQXXR/jgkDjy CNig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774875996; x=1775480796; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/IOBEa7GFyVDrfJ8sYt5+s+/t7ENB46SJEYFrDxrvCM=; b=DA6/d/SGghMzqp+BgwTnRGkl/QL5v/SCOSsFcSKsdoZyaooLjnAN0C3dhCwVkcRjSx Mm0cl/CVepvn3MqBcw+lrHITjgKG/xvLT0Zhaf+Hr29bIVHNe5HpcpuuX5WqAP+nCJRt h0CoHJz1RwMfzcHLmxuACGf61a29P0JRbU6euX162w2otxxahq2ckrjza+sS1AQ7RPf5 rWUv9Rn3bjaF9nwj6IurjuAq3f2ocTnT4zzNYFBZCimUEAz8V8azuz1Cig7e/ljKieFi Q6bivukNRb9V7D/9A/PiKZEltYbTul+2qUhdcSvHXddB7MCGVQRB+ig5X7VguJR7u54s /n1Q== X-Forwarded-Encrypted: i=1; AJvYcCXkjXUUOchHUjlXcFmhQPRr/4gc34RJhmvscWvT2LLx9U8BfEsu5tUanXnT904otDNK3ZOvKrmi7hw5Fpg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+lSTHaWZfA5pvaCerbRJG1M73GLQ1/4GehYuE6XHauhq6ffUS nSZd6sWngz/No7cLfkcQrcHlfu9Y9id4rJ8ndc4hEoaNx3MIMNhjRoA9hLT7Ww2ZLoiTx242wcb J37ButihMA9aZWKIXKjBcoECGeFLJg3HxOpPSmnqybEvyKLQg07OTZxBeqekJ+Cmn9Xc= X-Gm-Gg: ATEYQzzhP9TD4CRZRrIwXrPXfVk8oRCQEwxvnkbfbzq4+4dE/uiPyzWFiq/UEANVOmo d5ES6HrdjB4T8Ifi3QohcuDGH+AWrtQ6u4l88gNPlEYL/0h2XUTvjft+MP7WKLFwJ+OFomZ6IfW BLygHgQ8WXyZERfpV2K+aZMn3mbkZ8N4T3CxdAj+0fAzuNKZmLanJwroWmDOdQU5a6UoDAH4EJs gKCai90lfb6CvZhQCwvL1Hei9hPxRUY8pf8ctZl092NbCAsnYzZiXhy2DDttXdchUsm4Bk2ve3F WC5OsFf3SMf1suTw4YJF5JBMw69+0Q40xo9aa3Z8HFOPmW6iP1KWpa9UU1FKV7iu/nrZA3SkpSf xf6/pVuxSeB295RUJlzCl44uZNnqtkVuB1ofJtxyUxjRhvVz73qTN8Q== X-Received: by 2002:a17:902:d2ca:b0:2b0:5968:a6d5 with SMTP id d9443c01a7336-2b0cdc2165fmr113600585ad.18.1774875995478; Mon, 30 Mar 2026 06:06:35 -0700 (PDT) X-Received: by 2002:a17:902:d2ca:b0:2b0:5968:a6d5 with SMTP id d9443c01a7336-2b0cdc2165fmr113600345ad.18.1774875994884; Mon, 30 Mar 2026 06:06:34 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24267397bsm88213025ad.27.2026.03.30.06.06.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 06:06:34 -0700 (PDT) Message-ID: <0b41ee7c-83fe-d604-b750-8a5a0bd62bf8@oss.qualcomm.com> Date: Mon, 30 Mar 2026 18:36:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 2/5] media: iris: scale MMCX power domain on SM8250 Content-Language: en-US To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260209-iris-venus-fix-sm8250-v5-0-0a22365d3585@oss.qualcomm.com> <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> <5e2635ac-35de-645b-b5e7-235923f844ce@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=XN09iAhE c=1 sm=1 tr=0 ts=69ca755c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=5/Y9Gi2N1OwmQbPtUd2E/A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=PIOu0JlNxAVOzX5nUJ4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: KYAxZRjnpXU4GZ7M5UhuHWZOSj3cbx3w X-Proofpoint-ORIG-GUID: KYAxZRjnpXU4GZ7M5UhuHWZOSj3cbx3w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDEwMiBTYWx0ZWRfXzyZmat7jwRdj zE2b7x3JLVWtHIuskYTgjuNJMtEkKtgy6uXgo2p34eqgULWQx+dDYBLOexnxfNlg2oAgZlp+ql6 xG/GDMMoypyCp2FbiuXV2sdG34/zjwwoS0jQf8vErezWLM1O+8hZXYCAJKQ3E718jdE3r0/l+ze yjBbExQTzweN2GBfiGCTiGXRVT4hlzSgTYe0j6duBr7SM7X0SzVMJVT9wMkUM0k3EFZkb88cT9H oc9hubqd39KH6zwJGVmnupVGU/7tvMYfrzvklyk/TbgDowE6Nn1nP1rwFAnbZF8V1a8G17RKYB7 uiH2bzFqBs588EYGPY9TXiyduvPoengIo2NHenugSxE2GAo3YUlp01QcIK6zzHLZqlxFJprFuA1 mKIQUZLp1PEjdDoazcUME5meIN2e97U5mmoAiKEDoLkWs2ek4luWwdGk4rgD4yG56CDK98kS1jW Fz8xbAWqDWBFkJKdSPQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300102 On 3/30/2026 4:45 PM, Dmitry Baryshkov wrote: > On Mon, Mar 30, 2026 at 10:55:02AM +0530, Dikshita Agarwal wrote: >> >> >> On 2/9/2026 7:02 AM, Dmitry Baryshkov wrote: >>> On SM8250 most of the video clocks are powered by the MMCX domain, while >>> the PLL is powered on by the MX domain. Extend the driver to support >>> scaling both power domains, while keeping compatibility with the >>> existing DTs, which define only the MX domain. >>> >>> Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") >>> Reviewed-by: Dikshita Agarwal >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- >>> drivers/media/platform/qcom/iris/iris_probe.c | 7 +++++++ >>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> index df8e6bf9430e..aa71f7f53ee3 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { >>> >>> static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; >>> >>> -static const char * const sm8250_opp_pd_table[] = { "mx" }; >>> +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; >>> >>> static const struct platform_clk_data sm8250_clk_table[] = { >>> {IRIS_AXI_CLK, "iface" }, >>> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c >>> index 7b612ad37e4f..74ec81e3d622 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_probe.c >>> +++ b/drivers/media/platform/qcom/iris/iris_probe.c >>> @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) >>> return ret; >>> >>> ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); >>> + /* backwards compatibility for incomplete ABI SM8250 */ >>> + if (ret == -ENODEV && >>> + of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { >>> + iris_opp_pd_data.num_pd_names--; >>> + ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, >>> + &core->opp_pmdomain_tbl); >>> + } >>> if (ret < 0) >>> return ret; >>> >>> >> >> Hitting below compilation error on latest kernel >> >> drivers/media/platform/qcom/iris/iris_probe.c: In function >> ‘iris_init_power_domains’: >> drivers/media/platform/qcom/iris/iris_probe.c:71:46: error: decrement of >> read-only member ‘num_pd_names’ >> 71 | iris_opp_pd_data.num_pd_names--; > > See commit 7ad7f43e568b ("pmdomain: de-constify fields struct > dev_pm_domain_attach_data") Ack, Thanks! Regards, Dikshita > >> >> Could you please check and fix. >> >> Thanks, >> Dikshita >