From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbaGLC1S (ORCPT ); Fri, 11 Jul 2014 22:27:18 -0400 Received: from terminus.zytor.com ([198.137.202.10]:42463 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbaGLC1R (ORCPT ); Fri, 11 Jul 2014 22:27:17 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext From: "H. Peter Anvin" Date: Fri, 11 Jul 2014 19:26:50 -0700 To: Linus Torvalds , Andy Lutomirski CC: Andi Kleen , Al Viro , the arch/x86 maintainers , Linux Kernel Mailing List Message-ID: <0b46d9d7-30f7-4aee-be9e-dd83cf8056d9@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Our current handling of fs/vs is really weird. The best may very well be to explicitly save and restore both fs and he as part of Andi's patchset to support wrxsbase. On July 11, 2014 7:21:54 PM PDT, Linus Torvalds wrote: >On Fri, Jul 11, 2014 at 9:29 AM, Andy Lutomirski >wrote: >> As far as I can tell, these fields have been set to zero on save and >> ignored on restore since Linux was imported into git. Rename them >> '__pad1' and '__pad2' to avoid confusion and to allow them to be >> recycled some day. > >Shouldn't we actually try to save/restore gs/fs properly? Admittedly, >changing them in the signal handler would be insane, but still.. See >our context switching code with the whole segment selector vs base >save/restore code. Hmm? > > Linus -- Sent from my mobile phone. Please pardon brevity and lack of formatting.