From: Helge Deller <deller@gmx.de>
To: hanyu001@208suo.com, James.Bottomley@HansenPartnership.com
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: kernel: Add require space after that ','
Date: Thu, 3 Aug 2023 10:49:32 +0200 [thread overview]
Message-ID: <0b4e25c8-af53-3cd3-3710-c5831752482f@gmx.de> (raw)
In-Reply-To: <6a7de5f72aac9c6e71a5b484e7beb6b1@208suo.com>
On 7/20/23 08:40, hanyu001@208suo.com wrote:
> Fix checkpatch warnings:
>
> ./arch/parisc/kernel/unaligned.c:522: ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Hanyu, thanks for your patches!
You should use another email program, or use git send-mail because
your email program seems to convert tabs to spaces or breaks lines,
so that I can't cleanly apply some of your patches.
I've applied this one, but please resend the other patches if you want.
Helge
> ---
> arch/parisc/kernel/unaligned.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/parisc/kernel/unaligned.c b/arch/parisc/kernel/unaligned.c
> index 752d0d0..3d346f2 100644
> --- a/arch/parisc/kernel/unaligned.c
> +++ b/arch/parisc/kernel/unaligned.c
> @@ -472,7 +472,7 @@ void handle_unaligned(struct pt_regs *regs)
> case OPCODE_LDWA_I:
> case OPCODE_LDW_S:
> case OPCODE_LDWA_S:
> - ret = emulate_ldw(regs, R3(regs->iir),0);
> + ret = emulate_ldw(regs, R3(regs->iir), 0);
> break;
>
> case OPCODE_STH:
> @@ -481,7 +481,7 @@ void handle_unaligned(struct pt_regs *regs)
>
> case OPCODE_STW:
> case OPCODE_STWA:
> - ret = emulate_stw(regs, R2(regs->iir),0);
> + ret = emulate_stw(regs, R2(regs->iir), 0);
> break;
>
> #ifdef CONFIG_64BIT
> @@ -489,12 +489,12 @@ void handle_unaligned(struct pt_regs *regs)
> case OPCODE_LDDA_I:
> case OPCODE_LDD_S:
> case OPCODE_LDDA_S:
> - ret = emulate_ldd(regs, R3(regs->iir),0);
> + ret = emulate_ldd(regs, R3(regs->iir), 0);
> break;
>
> case OPCODE_STD:
> case OPCODE_STDA:
> - ret = emulate_std(regs, R2(regs->iir),0);
> + ret = emulate_std(regs, R2(regs->iir), 0);
> break;
> #endif
>
> @@ -502,24 +502,24 @@ void handle_unaligned(struct pt_regs *regs)
> case OPCODE_FLDWS:
> case OPCODE_FLDWXR:
> case OPCODE_FLDWSR:
> - ret = emulate_ldw(regs,FR3(regs->iir),1);
> + ret = emulate_ldw(regs, FR3(regs->iir), 1);
> break;
>
> case OPCODE_FLDDX:
> case OPCODE_FLDDS:
> - ret = emulate_ldd(regs,R3(regs->iir),1);
> + ret = emulate_ldd(regs, R3(regs->iir), 1);
> break;
>
> case OPCODE_FSTWX:
> case OPCODE_FSTWS:
> case OPCODE_FSTWXR:
> case OPCODE_FSTWSR:
> - ret = emulate_stw(regs,FR3(regs->iir),1);
> + ret = emulate_stw(regs, FR3(regs->iir), 1);
> break;
>
> case OPCODE_FSTDX:
> case OPCODE_FSTDS:
> - ret = emulate_std(regs,R3(regs->iir),1);
> + ret = emulate_std(regs, R3(regs->iir), 1);
> break;
>
> case OPCODE_LDCD_I:
prev parent reply other threads:[~2023-08-03 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_A984B205A9D93A7668CF1721A52EBA2B820A@qq.com>
2023-07-20 6:40 ` hanyu001
2023-08-03 8:49 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4e25c8-af53-3cd3-3710-c5831752482f@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hanyu001@208suo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®