From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB46C47404 for ; Fri, 4 Oct 2019 12:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1A89207FF for ; Fri, 4 Oct 2019 12:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730739AbfJDM7k (ORCPT ); Fri, 4 Oct 2019 08:59:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:45830 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726024AbfJDM7j (ORCPT ); Fri, 4 Oct 2019 08:59:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DFB78ABF4; Fri, 4 Oct 2019 12:59:37 +0000 (UTC) Message-ID: <0b544f5bc31857fef2d13bd16275cf09ace58b89.camel@suse.de> Subject: Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711 From: Nicolas Saenz Julienne To: Adrian Hunter , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Cc: wahrenst@gmx.net, Matthias Brugger , Ulf Hansson , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 04 Oct 2019 14:59:35 +0200 In-Reply-To: <20191004125226.27037-1-nsaenzjulienne@suse.de> References: <20191004125226.27037-1-nsaenzjulienne@suse.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-E7U/NXt/RvithmmAJCzu" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-E7U/NXt/RvithmmAJCzu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-10-04 at 14:52 +0200, Nicolas Saenz Julienne wrote: > The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12 > after multiblock reads even when ACMD12 is disabled. This triggers > spurious interrupts after the data transfer is done with the following > message: >=20 > mmc1: Got data interrupt 0x00000002 even though no data operation was i= n > progress. > mmc1: sdhci: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D SDHCI REGISTER DUMP = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002 > mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000 > mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033 > mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017 > mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080 > mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107 > mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 > mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b > mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 > mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525 > mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008 > mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f > mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00 > mmc1: sdhci: Host ctl2: 0x00000001 > mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208 > mmc1: sdhci: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock > reads and suppress the spurious interrupts. >=20 > Signed-off-by: Nicolas Saenz Julienne > Tested-by: Matthias Brugger Forgot to add: Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM271= 1") I'll resend if needed. Regards, Nicolas --=-E7U/NXt/RvithmmAJCzu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl2XQjcACgkQlfZmHno8 x/5CBQf/WvHZDFKw37mxwtwN2x5i0WFg95fBCi+6Hk6D0vDWuVUVMZBYneEUmyIt p42PpscEU854tHmqpqDn6/g2+O/9+g1XW3HOoOj4WjoP27d8uZPCPa0v8eWpahdI vGVhVjoCIuFlu3rsBW1tz/zvzVGmRICBY8ZurPqA7Pi+mepPAnWgjC99v4RDUEZc iqYqSupt4qyT7bhs5JOFywXm1Qu+KHQ0XoqGQdBD/vEVNuJn2bu0gOhvqKeWCWdl l6cHyjZjtHvtILFZyo1+Ys2DjVJnjPBY3zRBFG2C8I+2Ep3ust80fZ6SbZnMqDGx jjaH2rBVoZ7Ic5dAcBPXmjieSdo/Bg== =mtyS -----END PGP SIGNATURE----- --=-E7U/NXt/RvithmmAJCzu--