From: "Li,Rongqing" <lirongqing@baidu.com>
To: "Rafael J. Wysocki (Intel)" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [外部邮件] Re: [PATCH v2] PCI/ACPI: Check the found handle in acpi_get_rc_resources()
Date: Mon, 16 Nov 2026 03:05:07 +0000 [thread overview]
Message-ID: <0b5ce94eb1bf496781dd89c12295d229@baidu.com> (raw)
In-Reply-To: <CAJZ5v0hBVwOksptV2ThK9iCpHbSZDh0Z+R3dtojCtkze4_0eQg@mail.gmail.com>
> > From: Li RongQing <lirongqing@baidu.com>
> >
> > acpi_get_devices() returns AE_OK even when the namespace walk finishes
> > without a match, in which case the return_value argument is not written.
> > The caller passes an uninitialized acpi_handle and hands it to
> > acpi_fetch_acpi_dev(), which dereferences it as an ACPI node.
> >
> > Initialize the handle and reject a missing match.
> >
> > Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for
> > ARM64 platform")
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
> > ---
> > Diff with v1: add fixes tag
> >
> > drivers/pci/pci-acpi.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index
> > e260089..e90e749 100644
> > --- a/drivers/pci/pci-acpi.c
> > +++ b/drivers/pci/pci-acpi.c
> > @@ -82,7 +82,7 @@ int acpi_get_rc_resources(struct device *dev, const
> > char *hid, u16 segment, {
> > struct acpi_device *adev;
> > acpi_status status;
> > - acpi_handle handle;
> > + acpi_handle handle = NULL;
> > int ret;
> >
> > status = acpi_get_devices(hid, acpi_match_rc, &segment,
> > &handle); @@ -92,6 +92,9 @@ int acpi_get_rc_resources(struct device
> *dev, const char *hid, u16 segment,
> > return -ENODEV;
> > }
> >
> > + if (!handle)
> > + return -ENODEV;
>
> acpi_fetch_acpi_dev() will return NULL if handle is NULL, won't it?
>
Agreed that acpi_fetch_acpi_dev(NULL) is safe today — acpi_get_data_full() rejects NULL up front. But that safety is incidental, not contractual: the handle layer doesn't uniformly reject NULL (acpi_ns_validate_handle() even maps it to the root node), so relying on it makes the fix fragile to future changes. The explicit check states the "no match ⇒ -ENODEV" intent directly and costs 3 lines. If you prefer the minimal diff, I can drop it — the initialization alone is also correct.
Thanks
[Li,Rongqing]
> > +
> > adev = acpi_fetch_acpi_dev(handle);
> > if (!adev)
> > return -ENODEV;
> > --
prev parent reply other threads:[~2026-11-16 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 9:12 lirongqing
2026-11-15 17:06 ` Rafael J. Wysocki (Intel)
2026-11-16 3:05 ` Li,Rongqing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b5ce94eb1bf496781dd89c12295d229@baidu.com \
--to=lirongqing@baidu.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®