From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A02E378D7D for ; Fri, 30 Jan 2026 12:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769776180; cv=none; b=M0P/stnpy8Yh1HYmYXmzoZHJksB5P4V2Q8arh41PKMtApPwMA/zQmtLLqlLrhdLKohGVs6NsnYj0DzRcf2pjGBbI/oM59pHeK/waMPYls4TvNXAVMYhsKZuwzF6ruP7ipdGGVEJ1RuFFXfQT/+TOV7/awuHJj/OX0WA1kuN60KA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769776180; c=relaxed/simple; bh=JkbyxrYkyRVm5anzYwPv6egnAPQl+91/SVNeXxzRxcc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Sf0PQDo1SLh5QFPqzofriuMu66oylaIA6leGpuDRh4q6HWCl4AcDOTU4Q9l2jMLKsXk+BbUw9TW9IXFglRzhIu5Fzm73RG5XRWkFXhDHOIFDALWqbijt2kxmYwH8Cm5cJyzpPGNEC0/6Cg7S1r7ywnJmIeoBHzeyehCPo50hILU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZXAUIgRx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eTSkNLhO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZXAUIgRx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eTSkNLhO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UB4YbG995888 for ; Fri, 30 Jan 2026 12:29:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RfwyPOvS+wpVPPTCUEOdDVk2QBN2pxqX7UqPeosiBA4=; b=ZXAUIgRx4hZ5i4Qt bNB3tII/6jRofBBL5JgziPOHw4JXzs7XTmR0lQflwyl4irTOXieYW9q6xMz+E5pM qb7foZk7TPJLZvoZYhCtp8I63Bjq7QU+may0LYLmXQzN1B3LJ2RCOEOJBUJe3Urr /1x25ALg+ZVQLLsIN0B2Orhljak6vp2owu8nA7VIkW3xzAOQPWYtViy15+mEVdME P+8PiltpygB6YBsHdWpVRh3I6aqbn9e6ZfJuk+uY8TvO4E/5V7E+FbgwktAVV4Rt SZIZDZjkM/WBcI3g1bALvJcWEQjXbjCBGr2ef5lorQ2R/KZyFGfCpjOkKxRZVtj9 q9AulQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0bvvk29a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 12:29:34 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c7177d4ab4so13248685a.2 for ; Fri, 30 Jan 2026 04:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769776174; x=1770380974; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RfwyPOvS+wpVPPTCUEOdDVk2QBN2pxqX7UqPeosiBA4=; b=eTSkNLhOa1dQPwS3pDw12GFZcOnGunS9N1JrHlDPtN45bP/t2PSgzCzGG/hebh2Oma 7+Q5P9YqflP2LxU1yzo/1Y4PyQyfOlEs84jA/9bipCboDQEZEy2NQ4nBQFVjN63+dJ43 OKX/++9PC3lWW/ug7fant32LxpGRmmctQMeBTQ9G5bB1HfBuNH+tQZBgMsYxJKAhaBWO yofA7YULNTcsQqQkjq0gC0ZjplkFX6lXGPmIxCITUymFsyuhE3yAzYw2pWvWzmY4jkgU pegr65nkfs4zXpHeOxXIs81Pd9K0CC8LYT6757tnzzXhiKrP5kezM+cbL3ur21EuyHqB J94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769776174; x=1770380974; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RfwyPOvS+wpVPPTCUEOdDVk2QBN2pxqX7UqPeosiBA4=; b=YCt29vzznv2OukQi5SWQHFQt6eMKOfDBR6LFdqi4tdO+vE8l7UNzoB08ywT9wE6lkC rWyWRye3J0w+ywrxJ2GJyuBqaL6FnQ5iheY2f/9kdr7jhdK7bfWwel6jFlYNebZ3JqJF oLGRZsOr4MTSYfDlPNscbRpD3tmkJrzCnGe3+2fBfiQQXohTa7iEBhfd8AidxZqpx0s/ mcrO6X+CgpOkGyNtB3m1xcuopEqodIjow940s6/yRLCm3wAZzFRw4cage75yE3cQ5hMK /jWhwsuj7zodtnLaqBjfUyMvo5NRWM+gEYWxFteH0DsSYC162o7+RoiMIhvtHxUDkLZZ tw/A== X-Forwarded-Encrypted: i=1; AJvYcCVHv4XwZiQZak1I1z68x66OtdqO+lYS6cs+/GiT1TQY3JcGT7L3E9BkM6rBbaiJ0TKxBaPbB+Ec2/+h2+s=@vger.kernel.org X-Gm-Message-State: AOJu0YwpeDovn5zKCM517b1xvkdcq9Gb/+CqXqbKlS+osJ+hEhk/7gpK VCEi7dnLU66qiZkhmuG4mL7COTidOu3lOBBafAwXSYDDVGf//WcHBSmiRl6FJtL2DMyF8JUAgK7 blSrvIbqo0AXv1eRveWL05VqOtufBIf1bVlTxw7O0YXajDDAlAV011DzPfXUXFzGcbRs= X-Gm-Gg: AZuq6aIMMGtz8Jils5yu6qVYlfLx+uDVgeJhlrvYXv8iUNpDhRWj3v7Jts6gSoCHDaZ PdXIcdoe8e4DLM1fBy3fwkUUi9eGh412NXMW/tOn6ZsQAgZEZ6wqMv2dik37mAx3Go4WnHVug9W Ih4GFkzRwQnojg7nkkMzQrq/gzEQudUaz1K/hD4VMAGRMzo/O6SEirIF5WuCp1Y+WAz1Q9DUdfA ti9Z4taZjT+ngpWQGDXyD1zzWRQ/3wLuFusxmPdReo4jIF7RyV4tyvCs8uz9cBvJgbDU6nkieCk amoHC0u4+5uItLQH6MH0Fh87dC2oBGGbZWQ20ZWmzkrGJq3AfNt7RDuQgnuSu21lzlsdI1a3gdL 5To/poG/WRAcUaG16AHdTuuO9PDJvNDX2/Llh57Zx/589QSpd4hArp7D57tiHHw74Gls= X-Received: by 2002:a05:620a:46a9:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c9eb369787mr271757585a.11.1769776173190; Fri, 30 Jan 2026 04:29:33 -0800 (PST) X-Received: by 2002:a05:620a:46a9:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c9eb369787mr271751985a.11.1769776172555; Fri, 30 Jan 2026 04:29:32 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc6995sm406280566b.24.2026.01.30.04.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 04:29:31 -0800 (PST) Message-ID: <0b628651-79ea-4ae1-8898-125beac7a2b7@oss.qualcomm.com> Date: Fri, 30 Jan 2026 13:29:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/12] i2c: qcom-geni: Store of_device_id data in driver private struct To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> <20260112104722.591521-12-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260112104722.591521-12-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZdEQ98VA c=1 sm=1 tr=0 ts=697ca42e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=GxAstmoraj778iUyJ78A:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=zZCYzV9kfG8A:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: YujGJ2agu8fqCQo0IQvWtCT5wZNAhlUF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDEwMiBTYWx0ZWRfXzg5kDHSTXoNI 2m4l3lxO26pkEpMx6OzMkeUUETd0rtc1hKa+fA5/AbkSV7exzDo4W726KTYgvhLMfX40SzaBkLi 0FELbziBZ3v1t+EziIU9y5JJhQ+N2Il8yKhYEYGnldl+siS8TLEMho/q0KV+BdkVh0bk9iITrEw vpPADK17Y9N3BXFdIK1Oh3Q2fm65rU20AbretZ/V+hh2meokN0disqC5OoFv7eLQPf4ko4fOKad 2LXKLvVh71h5Qin+hdqMs2UzMYBnFAn148r22xa4SaDuzFDdJhs8XDd/Tob43YV6BOpVTLwbxkB O0lnQaZuDli8ZEVHh0jwFamFxvbgi5ZxBZIxXyaKR5hF1tLkCR8PWZE/OzBkz1PHJZjq7ySiDwI 7nrwh1O+olFTxmxUIy4Yy8CgYzRJ7eyffPUg3ewAEmwAVpiC/JR1or1gC7BLEYLpaca/EDrQR9X A5F3wI5yJTPFMw27cnA== X-Proofpoint-ORIG-GUID: YujGJ2agu8fqCQo0IQvWtCT5wZNAhlUF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300102 On 1/12/26 11:47 AM, Praveen Talari wrote: > To avoid repeatedly fetching and checking platform data across various > functions, store the struct of_device_id data directly in the i2c > private structure. This change enhances code maintainability and reduces > redundancy. > > Signed-off-by: Praveen Talari > --- > drivers/i2c/busses/i2c-qcom-geni.c | 32 ++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index b0a18e3d57d9..1c9356e13b97 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -77,6 +77,13 @@ enum geni_i2c_err_code { > #define XFER_TIMEOUT HZ > #define RST_TIMEOUT HZ > > +struct geni_i2c_desc { > + bool has_core_clk; > + char *icc_ddr; Again, this should be a NOP after patch 1, that we can drop Konrad