From: Paolo Abeni <pabeni@redhat.com>
To: Steen Hegelund <steen.hegelund@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: UNGLinuxDriver@microchip.com,
Randy Dunlap <rdunlap@infradead.org>,
Casper Andersson <casper.casan@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Wan Jiabing <wanjiabing@vivo.com>,
Nathan Huckleberry <nhuck@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Daniel Machon <daniel.machon@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Dan Carpenter <error27@gmail.com>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH net-next v2 06/10] net: microchip: sparx5: Add ES0 VCAP model and updated KUNIT VCAP model
Date: Thu, 16 Feb 2023 09:09:46 +0100 [thread overview]
Message-ID: <0b639b4294ffa61776756d33fc345e60a576d0ec.camel@redhat.com> (raw)
In-Reply-To: <20230214104049.1553059-7-steen.hegelund@microchip.com>
On Tue, 2023-02-14 at 11:40 +0100, Steen Hegelund wrote:
> This provides the VCAP model for the Sparx5 ES0 (Egress Stage 0) VCAP.
>
> This VCAP provides rewriting functionality in the egress path.
>
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> ---
> .../microchip/sparx5/sparx5_vcap_ag_api.c | 385 +++++++++++++++++-
> .../net/ethernet/microchip/vcap/vcap_ag_api.h | 174 +++++++-
> .../microchip/vcap/vcap_api_debugfs_kunit.c | 4 +-
> .../microchip/vcap/vcap_model_kunit.c | 270 +++++++-----
> .../microchip/vcap/vcap_model_kunit.h | 10 +-
> 5 files changed, 721 insertions(+), 122 deletions(-)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> index 561001ee0516..556d6ea0acd1 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> @@ -3,8 +3,8 @@
> * Microchip VCAP API
> */
>
> -/* This file is autogenerated by cml-utils 2023-01-17 16:55:38 +0100.
> - * Commit ID: cc027a9bd71002aebf074df5ad8584fe1545e05e
> +/* This file is autogenerated by cml-utils 2023-02-10 11:15:56 +0100.
> + * Commit ID: c30fb4bf0281cd4a7133bdab6682f9e43c872ada
> */
If the following has been already discussed, I'm sorry for the
duplicates, I missed the relevant thread.
Since this drivers contains quite a bit of auto-generated code, I'm
wondering if you could share the tool and/or the source file, too. That
would make reviews more accurate.
Thanks,
Paolo
next prev parent reply other threads:[~2023-02-16 8:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 10:40 [PATCH net-next v2 00/10] Adding Sparx5 ES0 VCAP support Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 01/10] net: microchip: sparx5: Discard frames with SMAC multicast addresses Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 02/10] net: microchip: sparx5: Clear rule counter even if lookup is disabled Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 03/10] net: microchip: sparx5: Egress VLAN TPID configuration follows IFH Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 05/10] net: microchip: sparx5: Improve the error handling for linked rules Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 06/10] net: microchip: sparx5: Add ES0 VCAP model and updated KUNIT VCAP model Steen Hegelund
2023-02-16 8:09 ` Paolo Abeni [this message]
2023-02-16 9:07 ` Steen Hegelund
2023-02-16 9:38 ` Paolo Abeni
2023-02-14 10:40 ` [PATCH net-next v2 07/10] net: microchip: sparx5: Updated register interface with VCAP ES0 access Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 08/10] net: microchip: sparx5: Add ES0 VCAP keyset configuration for Sparx5 Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 09/10] net: microchip: sparx5: Add TC support for the ES0 VCAP Steen Hegelund
2023-02-14 10:40 ` [PATCH net-next v2 10/10] net: microchip: sparx5: Add TC vlan action " Steen Hegelund
2023-02-16 8:30 ` [PATCH net-next v2 00/10] Adding Sparx5 ES0 VCAP support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b639b4294ffa61776756d33fc345e60a576d0ec.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=casper.casan@gmail.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=steen.hegelund@microchip.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®