From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754327AbcIISGP (ORCPT ); Fri, 9 Sep 2016 14:06:15 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:45251 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbcIISGM (ORCPT ); Fri, 9 Sep 2016 14:06:12 -0400 Subject: Re: [PATCH v2 1/1] usb: dwc3: fix Clear Stall EP command failure To: Felipe Balbi , Lu Baolu , John Youn References: <1473396687-26361-1-git-send-email-baolu.lu@linux.intel.com> <87inu5347z.fsf@linux.intel.com> CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" From: John Youn Message-ID: <0b65ea30-bfb0-6526-2084-3f09112ccaf5@synopsys.com> Date: Fri, 9 Sep 2016 11:04:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87inu5347z.fsf@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.64.22] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/2016 12:47 AM, Felipe Balbi wrote: > > Hi John, > > Lu Baolu writes: >> Commit 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear >> Stall EP command") sets ClearPendIN bit for all IN endpoints of >> v2.60a+ cores. This causes ClearStall command fails on 2.60+ cores >> operating in HighSpeed mode. >> >> In page 539 of 2.60a specification: >> >> "When issuing Clear Stall command for IN endpoints in SuperSpeed >> mode, the software must set the "ClearPendIN" bit to '1' to >> clear any pending IN transcations, so that the device does not >> expect any ACK TP from the host for the data sent earlier." >> >> It's obvious that we only need to apply this rule to those IN >> endpoints that currently operating in SuperSpeed mode. >> >> Fixes: 50c763f8c1bac ("usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command") >> Cc: # v4.7+ >> Signed-off-by: Lu Baolu >> --- >> v1->v2: >> - check current instead of maximum speed >> - improve the commit message >> >> drivers/usb/dwc3/gadget.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 7a8d3d8..4fd9fda 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -348,7 +348,8 @@ static int dwc3_send_clear_stall_ep_cmd(struct dwc3_ep *dep) >> * IN transfers due to a mishandled error condition. Synopsys >> * STAR 9000614252. >> */ >> - if (dep->direction && (dwc->revision >= DWC3_REVISION_260A)) >> + if (dep->direction && (dwc->revision >= DWC3_REVISION_260A) && >> + (dwc->gadget.speed >= USB_SPEED_SUPER)) >> cmd |= DWC3_DEPCMD_CLEARPENDIN; >> >> memset(¶ms, 0, sizeof(params)); > > since this is patching what you changed, can you have a look? It makes > sense to me. > Looks good to me John